r/vpc_endpoint - add `dns_options` and `ip_address_type` argument #25190

DrFaust92 · 2022-06-06T12:14:25Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccVPCEndpoint_ PKG=ec2
--- PASS: TestAccVPCEndpoint_disappears (44.99s)
--- PASS: TestAccVPCEndpoint_gatewayBasic (51.87s)
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (67.38s)
--- PASS: TestAccVPCEndpoint_gatewayPolicy (84.57s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (98.01s)
--- PASS: TestAccVPCEndpoint_tags (99.39s)
--- PASS: TestAccVPCEndpoint_interfaceBasic (151.59s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (277.36s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (347.46s)
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (484.52s)
--- PASS: TestAccVPCEndpoint_ipType (71.34s)

…ashicorp#14601).

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpoint_gatewayBasic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpoint_gatewayBasic -timeout 180m === RUN TestAccVPCEndpoint_gatewayBasic === PAUSE TestAccVPCEndpoint_gatewayBasic === CONT TestAccVPCEndpoint_gatewayBasic --- PASS: TestAccVPCEndpoint_gatewayBasic (30.72s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 34.762s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCPrefixListDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCPrefixListDataSource_ -timeout 180m === RUN TestAccVPCPrefixListDataSource_basic === PAUSE TestAccVPCPrefixListDataSource_basic === RUN TestAccVPCPrefixListDataSource_filter === PAUSE TestAccVPCPrefixListDataSource_filter === RUN TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter === PAUSE TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter === CONT TestAccVPCPrefixListDataSource_basic === CONT TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter === CONT TestAccVPCPrefixListDataSource_filter --- PASS: TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter (4.49s) --- PASS: TestAccVPCPrefixListDataSource_basic (18.75s) --- PASS: TestAccVPCPrefixListDataSource_filter (17.17s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 29.464s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpoint_gatewayBasic\|TestAccVPCEndpoint_interfaceBasic\|TestAccVPCEndpoint_disappears' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpoint_gatewayBasic\|TestAccVPCEndpoint_interfaceBasic\|TestAccVPCEndpoint_disappears -timeout 180m === RUN TestAccVPCEndpoint_gatewayBasic === PAUSE TestAccVPCEndpoint_gatewayBasic === RUN TestAccVPCEndpoint_interfaceBasic === PAUSE TestAccVPCEndpoint_interfaceBasic === RUN TestAccVPCEndpoint_disappears === PAUSE TestAccVPCEndpoint_disappears === CONT TestAccVPCEndpoint_gatewayBasic === CONT TestAccVPCEndpoint_disappears --- PASS: TestAccVPCEndpoint_disappears (34.96s) === CONT TestAccVPCEndpoint_interfaceBasic --- PASS: TestAccVPCEndpoint_gatewayBasic (39.17s) --- PASS: TestAccVPCEndpoint_interfaceBasic (70.19s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 115.148s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpoint_ipAddressType' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpoint_ipAddressType -timeout 180m === RUN TestAccVPCEndpoint_ipAddressType === PAUSE TestAccVPCEndpoint_ipAddressType === CONT TestAccVPCEndpoint_ipAddressType --- PASS: TestAccVPCEndpoint_ipAddressType (330.17s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 334.085s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpointDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointDataSource_ -timeout 180m === RUN TestAccVPCEndpointDataSource_gatewayBasic === PAUSE TestAccVPCEndpointDataSource_gatewayBasic === RUN TestAccVPCEndpointDataSource_byID === PAUSE TestAccVPCEndpointDataSource_byID === RUN TestAccVPCEndpointDataSource_byFilter === PAUSE TestAccVPCEndpointDataSource_byFilter === RUN TestAccVPCEndpointDataSource_byTags === PAUSE TestAccVPCEndpointDataSource_byTags === RUN TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags === PAUSE TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags === RUN TestAccVPCEndpointDataSource_interface === PAUSE TestAccVPCEndpointDataSource_interface === CONT TestAccVPCEndpointDataSource_gatewayBasic === CONT TestAccVPCEndpointDataSource_byTags --- PASS: TestAccVPCEndpointDataSource_byTags (31.39s) === CONT TestAccVPCEndpointDataSource_interface --- PASS: TestAccVPCEndpointDataSource_gatewayBasic (31.66s) === CONT TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags --- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (31.21s) === CONT TestAccVPCEndpointDataSource_byFilter --- PASS: TestAccVPCEndpointDataSource_byFilter (29.74s) === CONT TestAccVPCEndpointDataSource_byID --- PASS: TestAccVPCEndpointDataSource_byID (67.13s) --- PASS: TestAccVPCEndpointDataSource_interface (137.23s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 172.994s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCEndpoint_\|TestAccVPCEndpointService_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpoint_\|TestAccVPCEndpointService_ -timeout 180m
=== RUN   TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== RUN   TestAccVPCEndpointService_disappears
=== PAUSE TestAccVPCEndpointService_disappears
=== RUN   TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN   TestAccVPCEndpointService_networkLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_networkLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_supportedIPAddressTypes
=== PAUSE TestAccVPCEndpointService_supportedIPAddressTypes
=== RUN   TestAccVPCEndpointService_allowedPrincipals
=== PAUSE TestAccVPCEndpointService_allowedPrincipals
=== RUN   TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_privateDNSName
=== PAUSE TestAccVPCEndpointService_privateDNSName
=== RUN   TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN   TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN   TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN   TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN   TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN   TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpointService_basic
=== CONT  TestAccVPCEndpoint_disappears
--- PASS: TestAccVPCEndpoint_disappears (27.48s)
=== CONT  TestAccVPCEndpoint_ipAddressType
--- PASS: TestAccVPCEndpointService_basic (218.63s)
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (330.12s)
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccVPCEndpoint_ipAddressType (470.19s)
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (290.28s)
=== CONT  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (260.93s)
=== CONT  TestAccVPCEndpointService_allowedPrincipals
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (365.90s)
=== CONT  TestAccVPCEndpoint_interfaceBasic
--- PASS: TestAccVPCEndpoint_interfaceBasic (82.47s)
=== CONT  TestAccVPCEndpoint_gatewayBasic
--- PASS: TestAccVPCEndpoint_gatewayBasic (29.15s)
=== CONT  TestAccVPCEndpointService_privateDNSName
--- PASS: TestAccVPCEndpointService_allowedPrincipals (281.93s)
=== CONT  TestAccVPCEndpointService_gatewayLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_privateDNSName (257.65s)
=== CONT  TestAccVPCEndpoint_gatewayPolicy
--- PASS: TestAccVPCEndpoint_gatewayPolicy (52.03s)
=== CONT  TestAccVPCEndpoint_ignoreEquivalent
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (188.00s)
=== CONT  TestAccVPCEndpointService_networkLoadBalancerARNs
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (41.31s)
=== CONT  TestAccVPCEndpointService_supportedIPAddressTypes
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (257.50s)
=== CONT  TestAccVPCEndpointService_tags
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (408.42s)
=== CONT  TestAccVPCEndpointService_disappears
--- PASS: TestAccVPCEndpointService_tags (258.14s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (51.81s)
=== CONT  TestAccVPCEndpoint_tags
--- PASS: TestAccVPCEndpoint_tags (57.28s)
--- PASS: TestAccVPCEndpointService_disappears (232.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1856.484s
% make testacc TESTARGS='-run=TestAccVPCEndpointDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpointDataSource_ -timeout 180m
=== RUN   TestAccVPCEndpointDataSource_gatewayBasic
=== PAUSE TestAccVPCEndpointDataSource_gatewayBasic
=== RUN   TestAccVPCEndpointDataSource_byID
=== PAUSE TestAccVPCEndpointDataSource_byID
=== RUN   TestAccVPCEndpointDataSource_byFilter
=== PAUSE TestAccVPCEndpointDataSource_byFilter
=== RUN   TestAccVPCEndpointDataSource_byTags
=== PAUSE TestAccVPCEndpointDataSource_byTags
=== RUN   TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
=== PAUSE TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
=== RUN   TestAccVPCEndpointDataSource_interface
=== PAUSE TestAccVPCEndpointDataSource_interface
=== CONT  TestAccVPCEndpointDataSource_gatewayBasic
=== CONT  TestAccVPCEndpointDataSource_byTags
--- PASS: TestAccVPCEndpointDataSource_byTags (31.39s)
=== CONT  TestAccVPCEndpointDataSource_interface
--- PASS: TestAccVPCEndpointDataSource_gatewayBasic (31.66s)
=== CONT  TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
--- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (31.21s)
=== CONT  TestAccVPCEndpointDataSource_byFilter
--- PASS: TestAccVPCEndpointDataSource_byFilter (29.74s)
=== CONT  TestAccVPCEndpointDataSource_byID
--- PASS: TestAccVPCEndpointDataSource_byID (67.13s)
--- PASS: TestAccVPCEndpointDataSource_interface (137.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	172.994s

ewbankkit · 2022-06-22T20:59:12Z

% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

ewbankkit · 2022-06-22T21:01:53Z

@DrFaust92 Thanks for the contribution 🎉 👏.

github-actions · 2022-06-23T23:09:44Z

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-07-24T02:41:29Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

DrFaust92 added 4 commits June 6, 2022 11:54

address type

f91d183

docs + dns type

101da9c

supressdiff

7b08f07

computed

4c04b6d

github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2022

DrFaust92 added 2 commits June 6, 2022 15:14

changelog

945c8f5

test

d221b55

DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2022

DrFaust92 marked this pull request as ready for review June 6, 2022 12:34

github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jun 6, 2022

ewbankkit added 11 commits June 21, 2022 15:59

Merge branch 'main' into HEAD

738ff97

r/aws_vpc_endpoint_service: Use 'ServiceConnectivityType_Values()' (h…

2c0e65e

…ashicorp#14601).

Additional error code to skip.

81ae922

Add 'FindPrefixLists' and friends.

a010879

Fix typos.

1d8753c

Use 'aws_iam_session_context' for AllowedPrincipal.

38b4141

github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 22, 2022

ewbankkit approved these changes Jun 22, 2022

View reviewed changes

ewbankkit merged commit 9ad2e81 into hashicorp:main Jun 22, 2022

github-actions bot added this to the v4.20.0 milestone Jun 22, 2022

github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/vpc_endpoint - add `dns_options` and `ip_address_type` argument #25190

r/vpc_endpoint - add `dns_options` and `ip_address_type` argument #25190

DrFaust92 commented Jun 6, 2022 •

edited by ewbankkit

Loading

ewbankkit left a comment

ewbankkit commented Jun 22, 2022

ewbankkit commented Jun 22, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jul 24, 2022

r/vpc_endpoint - add dns_options and ip_address_type argument #25190

r/vpc_endpoint - add dns_options and ip_address_type argument #25190

Conversation

DrFaust92 commented Jun 6, 2022 • edited by ewbankkit Loading

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Jun 22, 2022

ewbankkit commented Jun 22, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jul 24, 2022

r/vpc_endpoint - add `dns_options` and `ip_address_type` argument #25190

r/vpc_endpoint - add `dns_options` and `ip_address_type` argument #25190

DrFaust92 commented Jun 6, 2022 •

edited by ewbankkit

Loading