Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/datasync_location_efs - add access point args #25182

Merged
merged 8 commits into from
Jun 21, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 5, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccDataSyncLocationEFS_ PKG=datasync
--- PASS: TestAccDataSyncLocationEFS_disappears (230.13s)
--- PASS: TestAccDataSyncLocationEFS_access (256.13s)
--- PASS: TestAccDataSyncLocationEFS_subdirectory (256.25s)
--- PASS: TestAccDataSyncLocationEFS_basic (256.69s)
--- PASS: TestAccDataSyncLocationEFS_tags (625.30s)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/datasync Issues and PRs that pertain to the datasync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 5, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review June 6, 2022 06:43
.changelog/25182.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 21, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSyncLocationEFS_' PKG=datasync ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 3  -run=TestAccDataSyncLocationEFS_ -timeout 180m
=== RUN   TestAccDataSyncLocationEFS_basic
=== PAUSE TestAccDataSyncLocationEFS_basic
=== RUN   TestAccDataSyncLocationEFS_accessPointARN
=== PAUSE TestAccDataSyncLocationEFS_accessPointARN
=== RUN   TestAccDataSyncLocationEFS_disappears
=== PAUSE TestAccDataSyncLocationEFS_disappears
=== RUN   TestAccDataSyncLocationEFS_subdirectory
=== PAUSE TestAccDataSyncLocationEFS_subdirectory
=== RUN   TestAccDataSyncLocationEFS_tags
=== PAUSE TestAccDataSyncLocationEFS_tags
=== CONT  TestAccDataSyncLocationEFS_basic
=== CONT  TestAccDataSyncLocationEFS_subdirectory
=== CONT  TestAccDataSyncLocationEFS_disappears
--- PASS: TestAccDataSyncLocationEFS_subdirectory (168.79s)
=== CONT  TestAccDataSyncLocationEFS_accessPointARN
--- PASS: TestAccDataSyncLocationEFS_accessPointARN (158.08s)
=== CONT  TestAccDataSyncLocationEFS_tags
--- PASS: TestAccDataSyncLocationEFS_disappears (340.11s)
--- PASS: TestAccDataSyncLocationEFS_basic (348.77s)
--- PASS: TestAccDataSyncLocationEFS_tags (173.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	514.560s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor

% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

@ewbankkit ewbankkit merged commit d5f0784 into hashicorp:main Jun 21, 2022
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 21, 2022
@DrFaust92 DrFaust92 deleted the datasync-efs-args branch June 23, 2022 06:10
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/datasync Issues and PRs that pertain to the datasync service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants