-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/datasync_location_efs - add access point args #25182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDataSyncLocationEFS_' PKG=datasync ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 3 -run=TestAccDataSyncLocationEFS_ -timeout 180m
=== RUN TestAccDataSyncLocationEFS_basic
=== PAUSE TestAccDataSyncLocationEFS_basic
=== RUN TestAccDataSyncLocationEFS_accessPointARN
=== PAUSE TestAccDataSyncLocationEFS_accessPointARN
=== RUN TestAccDataSyncLocationEFS_disappears
=== PAUSE TestAccDataSyncLocationEFS_disappears
=== RUN TestAccDataSyncLocationEFS_subdirectory
=== PAUSE TestAccDataSyncLocationEFS_subdirectory
=== RUN TestAccDataSyncLocationEFS_tags
=== PAUSE TestAccDataSyncLocationEFS_tags
=== CONT TestAccDataSyncLocationEFS_basic
=== CONT TestAccDataSyncLocationEFS_subdirectory
=== CONT TestAccDataSyncLocationEFS_disappears
--- PASS: TestAccDataSyncLocationEFS_subdirectory (168.79s)
=== CONT TestAccDataSyncLocationEFS_accessPointARN
--- PASS: TestAccDataSyncLocationEFS_accessPointARN (158.08s)
=== CONT TestAccDataSyncLocationEFS_tags
--- PASS: TestAccDataSyncLocationEFS_disappears (340.11s)
--- PASS: TestAccDataSyncLocationEFS_basic (348.77s)
--- PASS: TestAccDataSyncLocationEFS_tags (173.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 514.560s
@DrFaust92 Thanks for the contribution 🎉 👏. |
% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint... |
This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: