Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ssm_parameter: Allow Intelligent-Tiering to upgrade to Advanced #25174

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jun 4, 2022

AWS SSM Parameters with Intelligent-Tiering were not upgrading from Standard to Advanced if needed.

Removes hard-coded default of Standard to use the default configured for the account and region.

Closes #18521
Closes #25037

Output from acceptance testing:

$ make testacc PKG=ssm TESTS=TestAccSSMParameter

--- PASS: TestAccSSMParameter_disappears (106.85s)
--- PASS: TestAccSSMParametersByPathDataSource_withRecursion (130.32s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (137.32s)
--- PASS: TestAccSSMParameter_overwriteWithTags (146.87s)
--- PASS: TestAccSSMParameter_secure (146.89s)
--- PASS: TestAccSSMParameter_noOverwriteWithTags (147.05s)
--- PASS: TestAccSSMParameter_fullPath (147.11s)
--- PASS: TestAccSSMParameter_basic (149.06s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (204.45s)
--- PASS: TestAccSSMParameterDataSource_basic (209.50s)
--- PASS: TestAccSSMParameter_updateType (216.19s)
--- PASS: TestAccSSMParameter_updateToOverwriteWithTags (220.86s)
--- PASS: TestAccSSMParametersByPathDataSource_basic (114.14s)
--- PASS: TestAccSSMParameter_overwrite (222.88s)
--- PASS: TestAccSSMParameter_updateDescription (223.01s)
--- PASS: TestAccSSMParameter_Secure_keyUpdate (223.90s)
--- PASS: TestAccSSMParameterDataSource_fullPath (95.61s)
--- PASS: TestAccSSMParameter_overwriteCascade (236.64s)
--- PASS: TestAccSSMParameter_secureWithKey (99.41s)
--- PASS: TestAccSSMParameter_DataType_ec2Image (97.65s)
--- PASS: TestAccSSMParameter_tier (246.33s)
--- PASS: TestAccSSMParameter_tags (246.96s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (247.06s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (248.32s)
--- PASS: TestAccSSMParameter_changeNameForcesNew (103.43s)

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 4, 2022
@gdavison gdavison marked this pull request as ready for review June 6, 2022 17:57
@bassmanitram
Copy link

This is awesome - I really didn't expect this to be actioned so quickly! Thank you!

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a changelog entry too? otherwise LGTM 🚀

@gdavison gdavison merged commit b918496 into main Jun 9, 2022
@gdavison gdavison deleted the b-update-paramstore-intelligent-tier branch June 9, 2022 21:39
@github-actions github-actions bot added this to the v4.18.0 milestone Jun 9, 2022
github-actions bot pushed a commit that referenced this pull request Jun 9, 2022
@github-actions
Copy link

This functionality has been released in v4.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants