Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "status" filtering in "aws_ram_resource_share" datasource. #25157

Closed
mkielar opened this issue Jun 3, 2022 · 2 comments · Fixed by #25159
Closed

Allow "status" filtering in "aws_ram_resource_share" datasource. #25157

mkielar opened this issue Jun 3, 2022 · 2 comments · Fixed by #25159
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ram Issues and PRs that pertain to the ram service.
Milestone

Comments

@mkielar
Copy link
Contributor

mkielar commented Jun 3, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When a RAM Share is deleted it remains "visible" to API Calls for a long period of time. Even worse, when the RAM Share gets replaced by terraform (e.g. as a result of #25156), the old and new RAM Shares have the same name and tags, and are practically indistinguishable to the aws_ram_resource_share datasource.

Thus, the proposal to:

  1. Either, allow "status" filtering in "aws_ram_resource_share" datasource, so we could only pick Active ones,
  2. Or, filter out Deleted RAM Shares to prevent Multiple resource shares found for: <name> errors.

New or Affected Resource(s)

  • aws_ram_resource_share

Potential Terraform Configuration

data "aws_ram_resource_share" "this" {
  count    = local.tg_enabled
  provider = aws.network

  name           = local.transit_gateway_share
  resource_owner = "SELF"

  status = "Active"
}

References

@mkielar mkielar added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 3, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ram Issues and PRs that pertain to the ram service. labels Jun 3, 2022
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Jun 3, 2022
@github-actions github-actions bot added this to the v4.18.0 milestone Jun 6, 2022
@github-actions
Copy link

This functionality has been released in v4.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ram Issues and PRs that pertain to the ram service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants