Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_acmpca_policy - new resource #25109

Merged
merged 4 commits into from
Jun 2, 2022
Merged

r/aws_acmpca_policy - new resource #25109

merged 4 commits into from
Jun 2, 2022

Conversation

kurtmc
Copy link
Contributor

@kurtmc kurtmc commented May 30, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14784

Output from acceptance testing:

$ make testacc TESTS=TestAccACMPCAPolicy PKG=acmpca
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 20 -run='TestAccACMPCAPolicy'  -timeout 180m
=== RUN   TestAccACMPCAPolicy
=== PAUSE TestAccACMPCAPolicy
=== CONT  TestAccACMPCAPolicy
--- PASS: TestAccACMPCAPolicy (22.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acmpca     23.136s

@github-actions github-actions bot added service/acmpca Issues and PRs that pertain to the acmpca service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels May 30, 2022
@kurtmc kurtmc force-pushed the feature/acmpca_policy branch 2 times, most recently from 77785de to 7ab7514 Compare May 30, 2022 10:52
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels May 30, 2022
@kurtmc kurtmc marked this pull request as ready for review May 30, 2022 10:55
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels May 30, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 30, 2022
@kurtmc kurtmc changed the title Implement aws_acmpca_policy r/aws_acmpca_policy - new resource May 30, 2022
@kurtmc kurtmc force-pushed the feature/acmpca_policy branch 4 times, most recently from a2b3c1d to b3f39ec Compare June 1, 2022 02:52
ewbankkit
ewbankkit approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccACMPCAPolicy_' PKG=acmpca ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 2  -run=TestAccACMPCAPolicy_ -timeout 180m
=== RUN   TestAccACMPCAPolicy_Basic
=== PAUSE TestAccACMPCAPolicy_Basic
=== CONT  TestAccACMPCAPolicy_Basic
--- PASS: TestAccACMPCAPolicy_Basic (24.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	30.782s

@ewbankkit
Copy link
Contributor

@kurtmc Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor 

% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

@ewbankkit ewbankkit merged commit 7bc9573 into hashicorp:main Jun 2, 2022
@github-actions github-actions bot added this to the v4.17.0 milestone Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
@kurtmc kurtmc deleted the feature/acmpca_policy branch July 4, 2022 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/acmpca Issues and PRs that pertain to the acmpca service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.17.0
Development

Successfully merging this pull request may close these issues.

ACMPCA: Support resource policies
3 participants
@kurtmc @ewbankkit @DrFaust92