-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/redshift_endpoint_access - new resource #25073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRedshiftEndpointAccess_' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2 -run=TestAccRedshiftEndpointAccess_ -timeout 180m
=== RUN TestAccRedshiftEndpointAccess_basic
=== PAUSE TestAccRedshiftEndpointAccess_basic
=== RUN TestAccRedshiftEndpointAccess_sgs
=== PAUSE TestAccRedshiftEndpointAccess_sgs
=== RUN TestAccRedshiftEndpointAccess_disappears
=== PAUSE TestAccRedshiftEndpointAccess_disappears
=== RUN TestAccRedshiftEndpointAccess_disappears_cluster
=== PAUSE TestAccRedshiftEndpointAccess_disappears_cluster
=== CONT TestAccRedshiftEndpointAccess_basic
=== CONT TestAccRedshiftEndpointAccess_disappears
--- PASS: TestAccRedshiftEndpointAccess_disappears (641.42s)
=== CONT TestAccRedshiftEndpointAccess_disappears_cluster
--- PASS: TestAccRedshiftEndpointAccess_basic (643.08s)
=== CONT TestAccRedshiftEndpointAccess_sgs
--- PASS: TestAccRedshiftEndpointAccess_disappears_cluster (635.85s)
--- PASS: TestAccRedshiftEndpointAccess_sgs (931.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 1578.140s
% make providerlint
==> Checking source code with providerlint... |
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22113
Output from acceptance testing: