Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend r/aws_appflow_flow validation for attribute task_properties to avoid conflicting type assumption #24889

Merged
merged 5 commits into from
May 26, 2022

Conversation

zhelding
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24888.

Output from acceptance testing:

❯ make testacc TESTS=TestAccAppFlowFlow PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowFlow'  -timeout 180m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_tags
=== CONT  TestAccAppFlowFlow_TaskProperties
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_disappears (19.57s)
--- PASS: TestAccAppFlowFlow_TaskProperties (20.54s)
--- PASS: TestAccAppFlowFlow_basic (23.52s)
--- PASS: TestAccAppFlowFlow_update (35.47s)
--- PASS: TestAccAppFlowFlow_tags (50.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appflow    50.310s

Unfortunately, we don't have a ValidateFunc that allows us to check the keys and values of a TypeMap object -- except for a simple regex check.

@github-actions github-actions bot added service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appflow Issues and PRs that pertain to the appflow service. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels May 19, 2022
@zhelding zhelding self-assigned this May 19, 2022
- resulted from improperly targeted terrafmt command
@github-actions github-actions bot removed service/appsync Issues and PRs that pertain to the appsync service. service/apigateway Issues and PRs that pertain to the apigateway service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. labels May 19, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAppFlowFlow_ PKG=appflow ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2 -run='TestAccAppFlowFlow_'  -timeout 180m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_basic (29.49s)
=== CONT  TestAccAppFlowFlow_TaskProperties
--- PASS: TestAccAppFlowFlow_TaskProperties (25.94s)
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_tags (70.45s)
=== CONT  TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_disappears (23.84s)
--- PASS: TestAccAppFlowFlow_update (45.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	106.874s

@ewbankkit
Copy link
Contributor

Does this require a CHANGELOG entry?

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label May 23, 2022
@zhelding
Copy link
Contributor Author

Does this require a CHANGELOG entry?

Good catch! Should have a bug-fix changelog. Can add one when I'm back in on Thursday.

@zhelding zhelding merged commit 3704e58 into main May 26, 2022
@zhelding zhelding deleted the b-flow-task_properties-validate branch May 26, 2022 20:34
@github-actions github-actions bot added this to the v4.16.0 milestone May 26, 2022
github-actions bot pushed a commit that referenced this pull request May 26, 2022
@github-actions
Copy link

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appflow Issues and PRs that pertain to the appflow service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_appflow_flow has conflicting type assumption on task_properties attribute
2 participants