td/aws_connect

[GlennChia]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnectHoursOfOperation_serial' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectHoursOfOperation_serial -timeout 180m
=== RUN   TestAccConnectHoursOfOperation_serial
=== RUN   TestAccConnectHoursOfOperation_serial/basic
=== RUN   TestAccConnectHoursOfOperation_serial/disappears
=== RUN   TestAccConnectHoursOfOperation_serial/update_config
--- PASS: TestAccConnectHoursOfOperation_serial (303.87s)
    --- PASS: TestAccConnectHoursOfOperation_serial/basic (102.40s)
    --- PASS: TestAccConnectHoursOfOperation_serial/disappears (80.00s)
    --- PASS: TestAccConnectHoursOfOperation_serial/update_config (121.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    303.932s

$ make testacc TESTARGS='-run=TestAccConnectQuickConnectDataSource' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectQuickConnectDataSource -timeout 180m
=== RUN   TestAccConnectQuickConnectDataSource_id
--- PASS: TestAccConnectQuickConnectDataSource_id (125.88s)
=== RUN   TestAccConnectQuickConnectDataSource_name
--- PASS: TestAccConnectQuickConnectDataSource_name (80.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    206.286s
...

$ make testacc TESTARGS='-run=TestAccConnectQueueDataSource' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectQueueDataSource -timeout 180m
=== RUN   TestAccConnectQueueDataSource_queueID
--- PASS: TestAccConnectQueueDataSource_queueID (93.22s)
=== RUN   TestAccConnectQueueDataSource_name
--- PASS: TestAccConnectQueueDataSource_name (82.86s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    176.137s

$ make testacc TESTARGS='-run=TestAccConnectInstance_serial' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectInstance_serial -timeout 180m
=== RUN   TestAccConnectInstance_serial
=== RUN   TestAccConnectInstance_serial/directory
=== RUN   TestAccConnectInstance_serial/saml
=== RUN   TestAccConnectInstance_serial/basic
--- PASS: TestAccConnectInstance_serial (1098.08s)
    --- PASS: TestAccConnectInstance_serial/directory (906.46s)
    --- PASS: TestAccConnectInstance_serial/saml (91.48s)
    --- PASS: TestAccConnectInstance_serial/basic (100.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1098.138s

Changes

• Removed timeouts from Contact Flows
• Support customised timeouts for Instances
• Improve Hours of Operation rsrc, Queue data src, Quick Connect data src Tests

[gdavison]

Looks good! 🚀

--- PASS: TestAccConnectHoursOfOperation_serial (286.98s)
--- PASS: TestAccConnectHoursOfOperation_serial/disappears (79.32s)
--- PASS: TestAccConnectHoursOfOperation_serial/update_config (99.03s)
--- PASS: TestAccConnectHoursOfOperation_serial/basic (108.62s)
--- PASS: TestAccConnectInstance_serial (1140.50s)
--- PASS: TestAccConnectInstance_serial/basic (131.56s)
--- PASS: TestAccConnectInstance_serial/directory (925.34s)
--- PASS: TestAccConnectInstance_serial/saml (83.60s)
--- PASS: TestAccConnectQueueDataSource_queueID (89.00s)
--- PASS: TestAccConnectQueueDataSource_name (89.94s)
--- PASS: TestAccConnectQuickConnectDataSource_id (90.48s)
--- PASS: TestAccConnectQuickConnectDataSource_name (89.36s)

[github-actions]

This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.