-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/redshift_cluster - add aqua_configuration_status
argument
#24856
Conversation
rebased and found some issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRedshiftCluster_\|TestAccRedshiftClusterDataSource_' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2 -run=TestAccRedshiftCluster_\|TestAccRedshiftClusterDataSource_ -timeout 180m
=== RUN TestAccRedshiftClusterDataSource_basic
=== PAUSE TestAccRedshiftClusterDataSource_basic
=== RUN TestAccRedshiftClusterDataSource_vpc
=== PAUSE TestAccRedshiftClusterDataSource_vpc
=== RUN TestAccRedshiftClusterDataSource_logging
=== PAUSE TestAccRedshiftClusterDataSource_logging
=== RUN TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== PAUSE TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== RUN TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== RUN TestAccRedshiftCluster_aqua
=== PAUSE TestAccRedshiftCluster_aqua
=== RUN TestAccRedshiftCluster_disappears
=== PAUSE TestAccRedshiftCluster_disappears
=== RUN TestAccRedshiftCluster_withFinalSnapshot
=== PAUSE TestAccRedshiftCluster_withFinalSnapshot
=== RUN TestAccRedshiftCluster_kmsKey
=== PAUSE TestAccRedshiftCluster_kmsKey
=== RUN TestAccRedshiftCluster_enhancedVPCRoutingEnabled
=== PAUSE TestAccRedshiftCluster_enhancedVPCRoutingEnabled
=== RUN TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== RUN TestAccRedshiftCluster_snapshotCopy
=== PAUSE TestAccRedshiftCluster_snapshotCopy
=== RUN TestAccRedshiftCluster_iamRoles
=== PAUSE TestAccRedshiftCluster_iamRoles
=== RUN TestAccRedshiftCluster_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_publiclyAccessible
=== RUN TestAccRedshiftCluster_updateNodeCount
=== PAUSE TestAccRedshiftCluster_updateNodeCount
=== RUN TestAccRedshiftCluster_updateNodeType
=== PAUSE TestAccRedshiftCluster_updateNodeType
=== RUN TestAccRedshiftCluster_tags
=== PAUSE TestAccRedshiftCluster_tags
=== RUN TestAccRedshiftCluster_forceNewUsername
=== PAUSE TestAccRedshiftCluster_forceNewUsername
=== RUN TestAccRedshiftCluster_changeAvailabilityZone
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone
=== RUN TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== RUN TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== RUN TestAccRedshiftCluster_changeEncryption1
=== PAUSE TestAccRedshiftCluster_changeEncryption1
=== RUN TestAccRedshiftCluster_changeEncryption2
=== PAUSE TestAccRedshiftCluster_changeEncryption2
=== RUN TestAccRedshiftCluster_availabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation
=== RUN TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== RUN TestAccRedshiftCluster_restoreFromSnapshot
=== PAUSE TestAccRedshiftCluster_restoreFromSnapshot
=== CONT TestAccRedshiftClusterDataSource_basic
=== CONT TestAccRedshiftCluster_publiclyAccessible
--- PASS: TestAccRedshiftClusterDataSource_basic (259.61s)
=== CONT TestAccRedshiftCluster_withFinalSnapshot
--- PASS: TestAccRedshiftCluster_publiclyAccessible (288.73s)
=== CONT TestAccRedshiftCluster_iamRoles
--- PASS: TestAccRedshiftCluster_iamRoles (274.88s)
=== CONT TestAccRedshiftCluster_snapshotCopy
--- PASS: TestAccRedshiftCluster_snapshotCopy (229.02s)
=== CONT TestAccRedshiftCluster_loggingEnabled
--- PASS: TestAccRedshiftCluster_withFinalSnapshot (563.25s)
=== CONT TestAccRedshiftCluster_enhancedVPCRoutingEnabled
--- PASS: TestAccRedshiftCluster_loggingEnabled (262.91s)
=== CONT TestAccRedshiftCluster_kmsKey
--- PASS: TestAccRedshiftCluster_kmsKey (238.58s)
=== CONT TestAccRedshiftCluster_basic
--- PASS: TestAccRedshiftCluster_enhancedVPCRoutingEnabled (399.00s)
=== CONT TestAccRedshiftCluster_disappears
--- PASS: TestAccRedshiftCluster_basic (243.99s)
=== CONT TestAccRedshiftCluster_aqua
--- PASS: TestAccRedshiftCluster_disappears (404.76s)
=== CONT TestAccRedshiftClusterDataSource_logging
--- PASS: TestAccRedshiftCluster_aqua (350.11s)
=== CONT TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
--- PASS: TestAccRedshiftClusterDataSource_logging (268.10s)
=== CONT TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (303.50s)
=== CONT TestAccRedshiftCluster_restoreFromSnapshot
--- PASS: TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled (548.54s)
=== CONT TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (2.85s)
=== CONT TestAccRedshiftCluster_availabilityZoneRelocation
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (569.62s)
=== CONT TestAccRedshiftCluster_changeEncryption2
--- PASS: TestAccRedshiftCluster_changeEncryption2 (1708.83s)
=== CONT TestAccRedshiftCluster_changeEncryption1
--- PASS: TestAccRedshiftCluster_restoreFromSnapshot (1245.52s)
=== CONT TestAccRedshiftCluster_forceNewUsername
--- PASS: TestAccRedshiftCluster_forceNewUsername (540.52s)
=== CONT TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
--- PASS: TestAccRedshiftCluster_changeEncryption1 (1219.85s)
=== CONT TestAccRedshiftCluster_changeAvailabilityZone
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (904.06s)
=== CONT TestAccRedshiftClusterDataSource_vpc
=== CONT TestAccRedshiftCluster_updateNodeType
--- PASS: TestAccRedshiftClusterDataSource_vpc (224.60s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (1587.51s)
=== CONT TestAccRedshiftCluster_tags
--- PASS: TestAccRedshiftCluster_tags (336.27s)
=== CONT TestAccRedshiftCluster_updateNodeCount
--- PASS: TestAccRedshiftCluster_updateNodeType (1465.55s)
--- PASS: TestAccRedshiftCluster_updateNodeCount (1250.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 7202.260s
% make providerlint
==> Checking source code with providerlint... % make golangci-lint
==> Checking source code with golangci-lint... |
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #18869
Output from acceptance testing: