Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: nodejs16.x support for aws_lambda_function #24714

Closed
willfarrell opened this issue May 9, 2022 · 10 comments · Fixed by #24768
Closed

Feature Request: nodejs16.x support for aws_lambda_function #24714

willfarrell opened this issue May 9, 2022 · 10 comments · Fixed by #24768
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.

Comments

@willfarrell
Copy link

willfarrell commented May 9, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The Nodejs v16 runtime has been released for Lambda. Official announcement coming soon.

Currently returns:

Error: expected runtime to be one of [nodejs nodejs4.3 nodejs6.10 nodejs8.10 nodejs10.x nodejs12.x nodejs14.x java8 java8.al2 java11 python2.7 python3.6 python3.7 python3.8 python3.9 dotnetcore1.0 dotnetcore2.0 dotnetcore2.1 dotnetcore3.1 dotnet6 nodejs4.3-edge go1.x ruby2.5 ruby2.7 provided provided.al2], got nodejs16.x

I expect it to be resolved when the go SDK is updated, and no change needed.

New or Affected Resource(s)

  • aws_lambda_function

References

Requires AWS SDK for GO v1.44.13: #24768.

@willfarrell willfarrell added the enhancement Requests to existing resources that expand the functionality or scope. label May 9, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/lambda Issues and PRs that pertain to the lambda service. labels May 9, 2022
@ewbankkit
Copy link
Contributor

We will need to wait for the AWS SDK for Go release that adds the enumeration value.

@ewbankkit ewbankkit added upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels May 10, 2022
@xfournet
Copy link

@ewbankkit this has been released in v1.44.13 (2022-05-12)

@wilcoxmd
Copy link

Hi 👋 . Will Node.js 16 support only be available in v4 of the provider? Or is there a chance of compatibility coming to v3 as well?

@willfarrell
Copy link
Author

I don't think it's coming to v3 :(. But hopefully an easier migration path to v4 becomes available. #23106

@RobvH
Copy link

RobvH commented May 18, 2022

I'd like to encourage the team to make this available for v3.

@wilcoxmd
Copy link

wilcoxmd commented May 18, 2022

I'd like to encourage the team to make this available for v3.

Same.

As additional context, Node.js 16 support is especially important now that more engineers are starting to work on new laptops with Apple silicon. Previous Node versions aren't compatible with the local environments on those dev machines. If possible, it would be a huge help if we could get support for it in v3 of the provider so that our local environments could start to match our deployed ones more quickly while we continue to work toward a v4 upgrade.

@samwisekind
Copy link

@wilcoxmd @willfarrell @RobvH This was just released for in v3.75.2:

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v3.75.2

@wilcoxmd
Copy link

Amazing! Thanks to all for helping make this happen!

@anGie44
Copy link
Contributor

anGie44 commented May 20, 2022

FYI: v3.75.2 is not yet available as we ran into an issue during the release but we'll likely get the release out on releases.hashicorp.com later today (#24901)

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
7 participants