Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Data Source: aws_secretsmanager_secrets (plural) #24421

Closed
johnathan99j opened this issue Apr 26, 2022 · 4 comments · Fixed by #24514
Closed

Request for Data Source: aws_secretsmanager_secrets (plural) #24421

johnathan99j opened this issue Apr 26, 2022 · 4 comments · Fixed by #24514
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Milestone

Comments

@johnathan99j
Copy link

johnathan99j commented Apr 26, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It would be very useful to be able to retrieve a list of aws_secretsmanager_secrets by applying a filter, akin to aws_vpcs (vs aws_vpc).

This would be useful for the same reasons that other plural data sources are useful elsewhere but as a specific example, a list of secrets could be used when creating a aws_db_proxy resource where the proxy needs 20 existing secrets attached to it, the ability to have all these retrieved at once in a single data source list via filter is vastly superior to making many single data sources.

As mentioned in #13304 (comment) (#13304), the filter attribute doesn't follow the same vein as for other data sources so would unfortunately require a bit more work to accomplish but I still believe it's a worthwhile feature for the provider to have.

New or Affected Resource(s)

  • aws_secretsmanager_secrets data source
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 26, 2022
@justinretzolk justinretzolk added new-data-source Introduces a new data source. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 26, 2022
@kamilturek
Copy link
Collaborator

I'll take this one.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label May 3, 2022
@github-actions github-actions bot added this to the v4.13.0 milestone May 3, 2022
@johnathan99j
Copy link
Author

Thanks for the prompt work on this @kamilturek!

@github-actions
Copy link

github-actions bot commented May 5, 2022

This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants