d/aws_networkmanager_core_policy_document

[drewmullen]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Partially Closes #23782

PR also includes a new guide: "Using Terraform awscc provider with aws provider"
TODO Open a new PR to update the link once the new guide has been published.

Output from acceptance testing:

$ make testacc TESTS=TestAccCoreNetworkPolicyDocumentDataSource_basic PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccCoreNetworkPolicyDocumentDataSource_basic'  -timeout 180m
=== RUN   TestAccCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccCoreNetworkPolicyDocumentDataSource_basic (13.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     18.615s

[maryelizbeth]

Left a few suggestions! Thanks for putting this together, @drewmullen!

[drewmullen]

Guessing the markdownlint issue has to do with my stubbed <change-me>. Just need to know what URL the new guide will be at then i can update that URL...

-> For more information about building AWS Core Network policy documents with Terraform, see the [Using AWS & AWSCC Provider Together Guide](https://learn.hashicorp.com/terraform/aws/<changeme>).

[GlennChia]

Changes LGTM!

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccCoreNetworkPolicyDocumentDataSource_ PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccCoreNetworkPolicyDocumentDataSource_'  -timeout 180m
=== RUN   TestAccCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccCoreNetworkPolicyDocumentDataSource_basic (16.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	23.805s

[ewbankkit]

New CloudFormation Resource Schema definitions and generated Terraform resources/data sources: hashicorp/terraform-provider-awscc#497.

v0.21.0 of the Terraform AWS Cloud Control API Provider is available for download: https://registry.terraform.io/providers/hashicorp/awscc/latest.

[ewbankkit]

@drewmullen Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.