Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Aurora Serverless v2 #24349

Closed
njoerd114 opened this issue Apr 21, 2022 · 12 comments · Fixed by #24363
Closed

Support Aurora Serverless v2 #24349

njoerd114 opened this issue Apr 21, 2022 · 12 comments · Fixed by #24363
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@njoerd114
Copy link
Contributor

njoerd114 commented Apr 21, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS just recently announced the general availability of RDS Aurora Serverless v2. The new serverless mechanism drastically improves scalability.

New or Affected Resource(s)

  • aws_rds_cluster
  • aws_rds_cluster_instance

Potential Terraform Configuration

resource "aws_rds_cluster" "default" {
  # ...
  serverlessv2_scaling_configuration  {
    min_capacity = 0.5
    max_capacity = 128
  }
  # ...
}

resource "aws_rds_cluster_instance" "cluster_instances" {
  instance_class     = "db.serverless"
  engine             = aws_rds_cluster.default.engine
  engine_version     = aws_rds_cluster.default.engine_version
}

References

@njoerd114 njoerd114 added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 21, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. labels Apr 21, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 22, 2022
@njoerd114
Copy link
Contributor Author

I'm looking into contributing the necessary changes, I think I'm going to be able to submit a PR tonight.

@justinretzolk
Copy link
Member

Hey @njoerd114 👋 Thank you for taking the time to raise this, and for taking the time to submit a PR as well! We wanted to touch base here, given that this issue received so much attention so quickly, to let y'all know that we've noticed and will be prioritizing working on getting this in soon! 🙂

@travis2090
Copy link

Has there been any progress on incorporating this? We are looking to upgrade to v2 as soon as possible.

@jtbrush56
Copy link

Hi! How’s this process coming? We are currently trying to deploy v2 and this is what we need to keep our infrastructure in code. @njoerd114 already submitted the PR 4 days ago.

@travis-jorge
Copy link
Contributor

Hey @njoerd114 👋 Thank you for taking the time to raise this, and for taking the time to submit a PR as well! We wanted to touch base here, given that this issue received so much attention so quickly, to let y'all know that we've noticed and will be prioritizing working on getting this in soon! 🙂

@justinretzolk do we have an eta on getting this merged in? We really need this as soon as possible so we can migrate before we ramp up production v1 kinda sucks.

@nodomain
Copy link

nodomain commented Apr 26, 2022

Highly appreciated here as well ... going to replace >50 RDS instances with serverless v2 hopefully :)

@github-actions github-actions bot added this to the v4.12.0 milestone Apr 26, 2022
@jtbrush56
Copy link

I saw this was added to the 4.12.0 milestone. Is there any estimate to when that will be released? Thanks everyone for all your contributions!

@elocalgitbot
Copy link

Thanks @ewbankkit!

@github-actions
Copy link

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit
Copy link
Contributor

Here's one we use in the acceptance tests:

data "aws_rds_engine_version" "test" {
  engine             = "aurora-postgresql"
  preferred_versions = ["13.6"]
}
resource "aws_rds_cluster" "test" {
  cluster_identifier  = "testing123"
  master_password     = "barbarbarbar"
  master_username     = "foo"
  skip_final_snapshot = true
  engine              = data.aws_rds_engine_version.test.engine
  engine_version      = data.aws_rds_engine_version.test.version
  serverlessv2_scaling_configuration {
    max_capacity = 12
    min_capacity = 1
  }
}

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants