-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/shield_protection_group: use protection_group_arn
parameter when updating tags
#24296
Conversation
protection_group_arn
parameter when updating tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccShieldProtectionGroup_ PKG=shield ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 2 -run='TestAccShieldProtectionGroup_' -timeout 180m
=== RUN TestAccShieldProtectionGroup_basic
=== PAUSE TestAccShieldProtectionGroup_basic
=== RUN TestAccShieldProtectionGroup_disappears
=== PAUSE TestAccShieldProtectionGroup_disappears
=== RUN TestAccShieldProtectionGroup_aggregation
=== PAUSE TestAccShieldProtectionGroup_aggregation
=== RUN TestAccShieldProtectionGroup_members
=== PAUSE TestAccShieldProtectionGroup_members
=== RUN TestAccShieldProtectionGroup_protectionGroupID
=== PAUSE TestAccShieldProtectionGroup_protectionGroupID
=== RUN TestAccShieldProtectionGroup_resourceType
=== PAUSE TestAccShieldProtectionGroup_resourceType
=== RUN TestAccShieldProtectionGroup_tags
=== PAUSE TestAccShieldProtectionGroup_tags
=== CONT TestAccShieldProtectionGroup_basic
=== CONT TestAccShieldProtectionGroup_protectionGroupID
--- PASS: TestAccShieldProtectionGroup_basic (21.56s)
=== CONT TestAccShieldProtectionGroup_tags
--- PASS: TestAccShieldProtectionGroup_protectionGroupID (34.76s)
=== CONT TestAccShieldProtectionGroup_resourceType
--- PASS: TestAccShieldProtectionGroup_tags (38.00s)
=== CONT TestAccShieldProtectionGroup_aggregation
--- PASS: TestAccShieldProtectionGroup_resourceType (28.85s)
=== CONT TestAccShieldProtectionGroup_members
--- PASS: TestAccShieldProtectionGroup_members (18.33s)
=== CONT TestAccShieldProtectionGroup_disappears
--- PASS: TestAccShieldProtectionGroup_aggregation (27.72s)
--- PASS: TestAccShieldProtectionGroup_disappears (10.88s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/shield 98.331s
This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24245
Output from acceptance testing: