Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/shield_protection_group: use protection_group_arn parameter when updating tags #24296

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24245

Output from acceptance testing:

--- PASS: TestAccShieldProtectionGroup_disappears (50.71s)
--- PASS: TestAccShieldProtectionGroup_basic (72.69s)
--- PASS: TestAccShieldProtectionGroup_members (77.52s)
--- PASS: TestAccShieldProtectionGroup_aggregation (111.73s)
--- PASS: TestAccShieldProtectionGroup_protectionGroupID (113.33s)
--- PASS: TestAccShieldProtectionGroup_resourceType (115.03s)
--- PASS: TestAccShieldProtectionGroup_tags (126.84s)

@anGie44 anGie44 changed the title r/shield_protection_group: use protection_group_arn parameter when updating tags r/shield_protection_group: use protection_group_arn parameter when updating tags Apr 18, 2022
@github-actions github-actions bot added service/shield Issues and PRs that pertain to the shield service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Apr 18, 2022
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Apr 18, 2022
@anGie44 anGie44 marked this pull request as ready for review April 18, 2022 16:34
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccShieldProtectionGroup_ PKG=shield ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 2 -run='TestAccShieldProtectionGroup_'  -timeout 180m
=== RUN   TestAccShieldProtectionGroup_basic
=== PAUSE TestAccShieldProtectionGroup_basic
=== RUN   TestAccShieldProtectionGroup_disappears
=== PAUSE TestAccShieldProtectionGroup_disappears
=== RUN   TestAccShieldProtectionGroup_aggregation
=== PAUSE TestAccShieldProtectionGroup_aggregation
=== RUN   TestAccShieldProtectionGroup_members
=== PAUSE TestAccShieldProtectionGroup_members
=== RUN   TestAccShieldProtectionGroup_protectionGroupID
=== PAUSE TestAccShieldProtectionGroup_protectionGroupID
=== RUN   TestAccShieldProtectionGroup_resourceType
=== PAUSE TestAccShieldProtectionGroup_resourceType
=== RUN   TestAccShieldProtectionGroup_tags
=== PAUSE TestAccShieldProtectionGroup_tags
=== CONT  TestAccShieldProtectionGroup_basic
=== CONT  TestAccShieldProtectionGroup_protectionGroupID
--- PASS: TestAccShieldProtectionGroup_basic (21.56s)
=== CONT  TestAccShieldProtectionGroup_tags
--- PASS: TestAccShieldProtectionGroup_protectionGroupID (34.76s)
=== CONT  TestAccShieldProtectionGroup_resourceType
--- PASS: TestAccShieldProtectionGroup_tags (38.00s)
=== CONT  TestAccShieldProtectionGroup_aggregation
--- PASS: TestAccShieldProtectionGroup_resourceType (28.85s)
=== CONT  TestAccShieldProtectionGroup_members
--- PASS: TestAccShieldProtectionGroup_members (18.33s)
=== CONT  TestAccShieldProtectionGroup_disappears
--- PASS: TestAccShieldProtectionGroup_aggregation (27.72s)
--- PASS: TestAccShieldProtectionGroup_disappears (10.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	98.331s

@anGie44 anGie44 added this to the v4.11.0 milestone Apr 18, 2022
@anGie44 anGie44 merged commit 488da7b into main Apr 18, 2022
@anGie44 anGie44 deleted the b-shield-protection-group-panic branch April 18, 2022 18:26
github-actions bot pushed a commit that referenced this pull request Apr 18, 2022
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/shield Issues and PRs that pertain to the shield service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash attempting to update aws_shield_protection_group
2 participants