fix: add validation to passwords field of elasticache replication group

[scottd018]

This PR adds in the validation logic using existing validation with the SDK to validate that a user password for an elasticache cluster is within a specific range. Without this, a module may fail after initial validation which is especially problematic for long running Terraform scripts.

Signed-off-by: Dustin Scott [email protected]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24273

Output from acceptance testing:

$ make testacc TESTS=TestAccElastiCacheUser_* PKG=elasticache
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUser_*'  -timeout 180m
=== RUN   TestAccElastiCacheUserDataSource_basic
=== PAUSE TestAccElastiCacheUserDataSource_basic
=== RUN   TestAccElastiCacheUserGroupAssociation_basic
=== PAUSE TestAccElastiCacheUserGroupAssociation_basic
=== RUN   TestAccElastiCacheUserGroupAssociation_update
=== PAUSE TestAccElastiCacheUserGroupAssociation_update
=== RUN   TestAccElastiCacheUserGroupAssociation_disappears
=== PAUSE TestAccElastiCacheUserGroupAssociation_disappears
=== RUN   TestAccElastiCacheUserGroup_basic
=== PAUSE TestAccElastiCacheUserGroup_basic
=== RUN   TestAccElastiCacheUserGroup_update
=== PAUSE TestAccElastiCacheUserGroup_update
=== RUN   TestAccElastiCacheUserGroup_tags
=== PAUSE TestAccElastiCacheUserGroup_tags
=== RUN   TestAccElastiCacheUserGroup_disappears
=== PAUSE TestAccElastiCacheUserGroup_disappears
=== RUN   TestAccElastiCacheUser_basic
=== PAUSE TestAccElastiCacheUser_basic
=== RUN   TestAccElastiCacheUser_update
=== PAUSE TestAccElastiCacheUser_update
=== RUN   TestAccElastiCacheUser_tags
=== PAUSE TestAccElastiCacheUser_tags
=== RUN   TestAccElastiCacheUser_disappears
=== PAUSE TestAccElastiCacheUser_disappears
=== CONT  TestAccElastiCacheUserDataSource_basic
=== CONT  TestAccElastiCacheUser_basic
=== CONT  TestAccElastiCacheUser_disappears
=== CONT  TestAccElastiCacheUser_update
=== CONT  TestAccElastiCacheUserGroup_update
=== CONT  TestAccElastiCacheUserGroup_tags
=== CONT  TestAccElastiCacheUser_tags
=== CONT  TestAccElastiCacheUserGroup_basic
=== CONT  TestAccElastiCacheUserGroup_disappears
=== CONT  TestAccElastiCacheUserGroupAssociation_update
=== CONT  TestAccElastiCacheUserGroupAssociation_disappears
=== CONT  TestAccElastiCacheUserGroupAssociation_basic
--- PASS: TestAccElastiCacheUser_basic (81.37s)
--- PASS: TestAccElastiCacheUserDataSource_basic (82.32s)
--- PASS: TestAccElastiCacheUser_disappears (104.62s)
--- PASS: TestAccElastiCacheUser_tags (144.28s)
--- PASS: TestAccElastiCacheUser_update (145.23s)
--- PASS: TestAccElastiCacheUserGroup_disappears (208.57s)
--- PASS: TestAccElastiCacheUserGroup_basic (210.24s)
--- PASS: TestAccElastiCacheUserGroup_tags (269.85s)
--- PASS: TestAccElastiCacheUserGroupAssociation_basic (334.15s)
--- PASS: TestAccElastiCacheUserGroupAssociation_disappears (334.54s)
--- PASS: TestAccElastiCacheUserGroup_update (335.89s)
--- PASS: TestAccElastiCacheUserGroupAssociation_update (459.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        461.141s

[github-actions]

Welcome @scottd018 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccElastiCacheUser_ PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run='TestAccElastiCacheUser_'  -timeout 180m
=== RUN   TestAccElastiCacheUser_basic
=== PAUSE TestAccElastiCacheUser_basic
=== RUN   TestAccElastiCacheUser_update
=== PAUSE TestAccElastiCacheUser_update
=== RUN   TestAccElastiCacheUser_tags
=== PAUSE TestAccElastiCacheUser_tags
=== RUN   TestAccElastiCacheUser_disappears
=== PAUSE TestAccElastiCacheUser_disappears
=== CONT  TestAccElastiCacheUser_basic
=== CONT  TestAccElastiCacheUser_tags
--- PASS: TestAccElastiCacheUser_basic (78.56s)
=== CONT  TestAccElastiCacheUser_disappears
--- PASS: TestAccElastiCacheUser_tags (84.54s)
=== CONT  TestAccElastiCacheUser_update
--- PASS: TestAccElastiCacheUser_disappears (71.48s)
--- PASS: TestAccElastiCacheUser_update (124.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	216.950s

[ewbankkit]

@scottd018 Thanks for the contribution 🎉 👏.

[scottd018]

Thanks @ewbankkit !

[github-actions]

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.