-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack_set.operation_preferences.failure_tolerance_count can be zero #24250
stack_set.operation_preferences.failure_tolerance_count can be zero #24250
Conversation
…tage to be positive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccCloudFormationStackSet_operationPreferences PKG=cloudformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSet_operationPreferences' -timeout 180m
=== RUN TestAccCloudFormationStackSet_operationPreferences
=== PAUSE TestAccCloudFormationStackSet_operationPreferences
=== CONT TestAccCloudFormationStackSet_operationPreferences
--- PASS: TestAccCloudFormationStackSet_operationPreferences (125.20s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation 128.933s
@MarkCBell Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Currently, an aws_cloudformation_stack_set with:
fails with
Validation Error: Exactly one of FailureTolerancePercentage and FailureToleranceCount must be specified since both parameters are present
. This is because currently theFailureToleranceCount
andFailureTolerancePercentage
attributes are both set (possibly to a default value of 0) and then one is removed if it is zero and the other is non-zero. Therefore with theoperation_preferences
block above both remain, leading to theValidation Error
being raised. This PR removes the requirement that the other be non-zero and so allows the aboveoperation_preferences
block to work.Note that although this does not apply to max_concurrent_percentage / max_concurrent_count since at least one of these must be at least one, I propose making the same change there just to keep the logic the same.