Do not validate items that conflict

[MarkCBell]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

The failure_tolerance_count and failure_tolerance_percentage conflict with each other, so one should be validated only if the other has failed. The same applies for max_concurrent_count and max_concurrent_percentage.

Closes #24161

[github-actions]

Welcome @MarkCBell 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

Prior to fix:

% make testacc TESTS=TestAccCloudFormationStackSet_operationPreferences PKG=cloudformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSet_operationPreferences'  -timeout 180m
=== RUN   TestAccCloudFormationStackSet_operationPreferences
=== PAUSE TestAccCloudFormationStackSet_operationPreferences
=== CONT  TestAccCloudFormationStackSet_operationPreferences
    stack_set_test.go:268: Step 4/5 error: Error running apply: exit status 1
        
        Error: error updating CloudFormation StackSet (tf-acc-test-1440391482554017189): InvalidParameter: 1 validation error(s) found.
        - minimum field value of 1, UpdateStackSetInput.OperationPreferences.MaxConcurrentCount.
        
        
          with aws_cloudformation_stack_set.test,
          on terraform_plugin_test.tf line 25, in resource "aws_cloudformation_stack_set" "test":
          25: resource "aws_cloudformation_stack_set" "test" {
        
--- FAIL: TestAccCloudFormationStackSet_operationPreferences (47.90s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	51.741s
FAIL
make: *** [testacc] Error 1

After fix:

% make testacc TESTS=TestAccCloudFormationStackSet_operationPreferences PKG=cloudformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSet_operationPreferences'  -timeout 180m
=== RUN   TestAccCloudFormationStackSet_operationPreferences
=== PAUSE TestAccCloudFormationStackSet_operationPreferences
=== CONT  TestAccCloudFormationStackSet_operationPreferences
--- PASS: TestAccCloudFormationStackSet_operationPreferences (81.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	85.855s

[ewbankkit]

@MarkCBell Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[MarkCBell]

@ewbankkit Thank you for working on this. However I believe that there is a bug in the logic that you have added to internal/service/cloudformation/type.go. Specifically, in order for one of FailureTolerancePercentage or FailureToleranceCount to be removed (set to nil) either ftc > 0 or ftp > 0. Therefore a block such as:

  operation_preferences {
    failure_tolerance_percentage = 0
    max_concurrent_percentage = 100
  }

will trigger neither case since ftp has be set to 0 and ftc has defaulted to zero. Therefore if you attempt to run a stack set with the above operations_preferences, terraform fails with Validation Error: Exactly one of FailureTolerancePercentage and FailureToleranceCount must be specified since both parameters are present.

You could address this by modifying the logic to:

	if ftc, ftp := aws.Int64Value(apiObject.FailureToleranceCount), aws.Int64Value(apiObject.FailureTolerancePercentage); ftp == 0 {
		apiObject.FailureTolerancePercentage = nil
	} else if ftc == 0 {
		apiObject.FailureToleranceCount = nil
        }

I will open a new issue / PR proposing this change.

Note that this does not apply to max_concurrent_percentage / max_concurrent_count since at least one of these must be at least one.

[MarkCBell]

@ewbankkit I have proposed this change in PR #24250

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.