-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/s3_bucket_website_configuration: add routing_rules
parameter to assist in configuring rules with empty string values
#24198
Conversation
15e6adb
to
4a85b55
Compare
@@ -142,6 +147,17 @@ func ResourceBucketWebsiteConfiguration() *schema.Resource { | |||
}, | |||
}, | |||
}, | |||
"routing_rules": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently not entirely sure if we should keep both params or deprecate routing_rule
in favor of this one 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm or we can always deprecate one of these later if for example we migrate to the plugin-framework and that better supports empty string values in nested types
…ssist in configuring rules with empty string values not interpreted when using 'routing_rule' instead
3b9d873
to
7917db3
Compare
Output of acceptance tests after rebase: Commercial:
GovCloud:
** CI failures look unrelated atm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3BucketWebsiteConfiguration_ -timeout 180m
=== RUN TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT TestAccS3BucketWebsiteConfiguration_basic
=== CONT TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== CONT TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (24.86s)
=== CONT TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (24.90s)
=== CONT TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (39.64s)
=== CONT TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (35.62s)
=== CONT TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (37.80s)
=== CONT TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (35.21s)
=== CONT TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (38.67s)
=== CONT TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (24.55s)
=== CONT TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (22.14s)
=== CONT TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (40.92s)
=== CONT TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (83.27s)
=== CONT TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (36.65s)
=== CONT TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (21.71s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (25.04s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (39.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 200.774s
Co-authored-by: Kit Ewbank <[email protected]>
This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #24048
Description
routing_rules
parameter used in theaws_s3_bucket
resource as workaround for practitioners, which perhaps was used for these circumstances.Output from acceptance testing: