Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_backup_report_plan: Wait for correct DeploymentStatus after lifecycle operations #23967

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 31, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23966.

Output from acceptance testing:

% make testacc TESTS=TestAccBackupReportPlan_ PKG=backup ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 3 -run='TestAccBackupReportPlan_'  -timeout 180m
=== RUN   TestAccBackupReportPlan_basic
=== PAUSE TestAccBackupReportPlan_basic
=== RUN   TestAccBackupReportPlan_updateTags
=== PAUSE TestAccBackupReportPlan_updateTags
=== RUN   TestAccBackupReportPlan_updateReportDeliveryChannel
=== PAUSE TestAccBackupReportPlan_updateReportDeliveryChannel
=== RUN   TestAccBackupReportPlan_disappears
=== PAUSE TestAccBackupReportPlan_disappears
=== CONT  TestAccBackupReportPlan_basic
=== CONT  TestAccBackupReportPlan_updateReportDeliveryChannel
=== CONT  TestAccBackupReportPlan_disappears
--- PASS: TestAccBackupReportPlan_disappears (22.77s)
=== CONT  TestAccBackupReportPlan_updateTags
--- PASS: TestAccBackupReportPlan_updateReportDeliveryChannel (41.37s)
--- PASS: TestAccBackupReportPlan_basic (41.84s)
--- PASS: TestAccBackupReportPlan_updateTags (57.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	84.089s```

@github-actions github-actions bot added service/backup Issues and PRs that pertain to the backup service. size/L Managed by automation to categorize the size of a PR. labels Mar 31, 2022
@ewbankkit ewbankkit force-pushed the b-aws_backup_report_plan-async branch from 7423099 to 78def11 Compare March 31, 2022 13:24
@ewbankkit ewbankkit merged commit 56ecfd5 into main Mar 31, 2022
@ewbankkit ewbankkit deleted the b-aws_backup_report_plan-async branch March 31, 2022 14:34
@github-actions github-actions bot added this to the v4.9.0 milestone Mar 31, 2022
github-actions bot pushed a commit that referenced this pull request Mar 31, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/backup Issues and PRs that pertain to the backup service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/backup: Report Plan tests fail when running post-test destroy
1 participant