Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/conns: add retry handling for InternalErrorException when calling FMS PutPolicy #23952

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 30, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23946

Notes:

  • Tests already passing in nightly CI so I only ran the update test since the error may not be apparent with our test configs

Output from acceptance testing:

--- PASS: TestAccFMS_serial (1082.54s)
    --- PASS: TestAccFMS_serial/Policy (1082.54s)
        --- PASS: TestAccFMS_serial/Policy/update (1082.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	1086.300s

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. labels Mar 30, 2022
@anGie44 anGie44 changed the title internal/conns: add retry handling for InternalErrorException when calling FMS PutPolicy internal/conns: add retry handling for InternalErrorException when calling FMS PutPolicy Mar 30, 2022
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 30, 2022
@anGie44 anGie44 marked this pull request as ready for review March 30, 2022 21:40
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v4.9.0 milestone Apr 1, 2022
@anGie44 anGie44 merged commit dede268 into main Apr 1, 2022
@anGie44 anGie44 deleted the f-fms-policy-retry branch April 1, 2022 13:37
github-actions bot pushed a commit that referenced this pull request Apr 1, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. enhancement Requests to existing resources that expand the functionality or scope. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource aws_fms_policy get error creating FMS Policy InternalErrorException
2 participants