Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_cloudwatch_event_bus #23792

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

amancevice
Copy link
Contributor

@amancevice amancevice commented Mar 21, 2022

Adds aws_cloudwatch_event_bus data resource. This is my first contribution to terraform and I'm a Go novice so please let me know if I have done anything incorrectly and I will do my best to resolve!

Example usage:

data "aws_cloudwatch_event_bus" "example" {
  name = "my-event-bus"
}

output "event_bus_arn" {
  value = data.aws_cloudwatch_event_bus.example.arn
}

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19101

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccEventsBusDataSource*' ACCTEST_PARALLELISM=5 PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 5  -run=TestAccEventsBusDataSource* -timeout 180m
=== RUN   TestAccEventsBusDataSource_basic
=== PAUSE TestAccEventsBusDataSource_basic
=== CONT  TestAccEventsBusDataSource_basic
--- PASS: TestAccEventsBusDataSource_basic (12.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	14.518s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/events Issues and PRs that pertain to the events service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Mar 21, 2022
Add aws_cloudwatch_event_bus data resource
@amancevice amancevice marked this pull request as ready for review March 21, 2022 21:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @amancevice 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 21, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccEventsBusDataSource_ PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBusDataSource_'  -timeout 180m
=== RUN   TestAccEventsBusDataSource_basic
=== PAUSE TestAccEventsBusDataSource_basic
=== CONT  TestAccEventsBusDataSource_basic
--- PASS: TestAccEventsBusDataSource_basic (15.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	19.345s

@ewbankkit
Copy link
Contributor

@amancevice Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 52f8b09 into hashicorp:main Mar 22, 2022
@amancevice amancevice deleted the add-event-bus-data-resource branch March 22, 2022 17:13
@github-actions github-actions bot added this to the v4.7.0 milestone Mar 22, 2022
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/events Issues and PRs that pertain to the events service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data resource for aws_cloudwatch_event_bus
3 participants