aws_launch_template: fix network interface device_index of 0 being ignored

[fcheung]

0 is a legal device index, moreover a launchtemplate requires a network interface with a device index of 0 to be functional

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23766

Output from acceptance testing:

$make testacc TESTS=TestAccEC2LaunchTemplate_networkInterface PKG=ec2 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2LaunchTemplate_networkInterface'  -timeout 180m
=== RUN   TestAccEC2LaunchTemplate_networkInterface
=== PAUSE TestAccEC2LaunchTemplate_networkInterface
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceAddresses
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceAddresses
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceType
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceType
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceCardIndex
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceCardIndex
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceIPv4PrefixCount
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceIPv4PrefixCount
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceIPv4Prefixes
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceIPv4Prefixes
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceIPv6PrefixCount
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceIPv6PrefixCount
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceIPv6Prefixes
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceIPv6Prefixes
=== CONT  TestAccEC2LaunchTemplate_networkInterface
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceIPv4PrefixCount
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceIPv6PrefixCount
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceIPv6Prefixes
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceAddresses
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceIPv4Prefixes
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceType
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceCardIndex
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceType (18.13s)
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceCardIndex (18.83s)
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceIPv4Prefixes (19.00s)
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceIPv6Prefixes (19.14s)
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceIPv6PrefixCount (19.14s)
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceIPv4PrefixCount (19.50s)
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceAddresses (24.70s)
--- PASS: TestAccEC2LaunchTemplate_networkInterface (24.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	27.604s

I tried to write a failing test (adding resource.TestCheckResourceAttr(resourceName, "network_interfaces.0.device_index", "0")) but that test seemed to pass even without the change in this pr

[bschaatsbergen]

LGTM

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccEC2LaunchTemplate_networkInterface PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run='TestAccEC2LaunchTemplate_networkInterface'  -timeout 180m
=== RUN   TestAccEC2LaunchTemplate_networkInterface
=== PAUSE TestAccEC2LaunchTemplate_networkInterface
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceAddresses
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceAddresses
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceType
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceType
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceCardIndex
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceCardIndex
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceIPv4PrefixCount
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceIPv4PrefixCount
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceIPv4Prefixes
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceIPv4Prefixes
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceIPv6PrefixCount
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceIPv6PrefixCount
=== RUN   TestAccEC2LaunchTemplate_networkInterfaceIPv6Prefixes
=== PAUSE TestAccEC2LaunchTemplate_networkInterfaceIPv6Prefixes
=== CONT  TestAccEC2LaunchTemplate_networkInterface
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceIPv4PrefixCount
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceIPv4PrefixCount (15.70s)
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceType
--- PASS: TestAccEC2LaunchTemplate_networkInterface (22.27s)
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceCardIndex
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceType (14.14s)
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceIPv6PrefixCount
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceCardIndex (15.17s)
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceIPv6Prefixes
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceIPv6PrefixCount (14.61s)
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceIPv4Prefixes
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceIPv6Prefixes (14.60s)
=== CONT  TestAccEC2LaunchTemplate_networkInterfaceAddresses
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceIPv4Prefixes (14.78s)
--- PASS: TestAccEC2LaunchTemplate_networkInterfaceAddresses (22.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	78.226s

[ewbankkit]

@fcheung Thanks for the contribution 🎉 👏 and sorry that you hit this problem.
I tweaked your PR a bit by adding the same logic for network_card_index and adding verification of all network_interfaces attributes to the acceptance test case.

[stylianosrigas]

@ewbankkit Do you have an estimated time for the v4.7.0 release that fixes the launch template issues?

[ewbankkit]

We usually release on Thursdays.

[github-actions]

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.