Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dms_replication_task: Support starting/stoping a replication task #23692

Merged
merged 11 commits into from
Mar 17, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Mar 15, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #2083

Output from acceptance testing:

$ make testacc TESTS=TestAccDMSReplicationTask PKG=dms

=== RUN   TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN   TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_basic
=== CONT  TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_cdcStartPosition
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (450.98s)
--- PASS: TestAccDMSReplicationTask_basic (471.25s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (945.17s)
PASS
...

@github-actions github-actions bot added service/databasemigrationservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 15, 2022
@johnsonaj johnsonaj force-pushed the r/aws_dms_replication_task_start branch from b064a90 to 5252d6c Compare March 16, 2022 17:48
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 16, 2022
@johnsonaj johnsonaj changed the title r/aws_dms_replication_task: support start/stop replication task r/aws_dms_replication_task: Support starting/stoping a replication task Mar 16, 2022
@johnsonaj johnsonaj marked this pull request as ready for review March 16, 2022 21:07
.changelog/23692.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccDMSReplicationTask_ PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3 -run='TestAccDMSReplicationTask_'  -timeout 180m
=== RUN   TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN   TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_basic
=== CONT  TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_cdcStartPosition
--- PASS: TestAccDMSReplicationTask_basic (482.75s)
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (647.88s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (945.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	949.465s

@johnsonaj johnsonaj merged commit 7126f59 into main Mar 17, 2022
@johnsonaj johnsonaj deleted the r/aws_dms_replication_task_start branch March 17, 2022 16:49
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 17, 2022
github-actions bot pushed a commit that referenced this pull request Mar 17, 2022
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Starting AWS Database Migration Service Replication Task
2 participants