Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudsearch_domain: Incorrect diffs for index_field #23687

Merged
merged 7 commits into from
Mar 15, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 15, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23570.

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccCloudSearchDomain_' PKG=cloudsearch    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudsearch/... -v -count 1 -parallel 20  -run=TestAccCloudSearchDomain_ -timeout 180m
=== RUN   TestAccCloudSearchDomain_basic
=== PAUSE TestAccCloudSearchDomain_basic
=== RUN   TestAccCloudSearchDomain_disappears
=== PAUSE TestAccCloudSearchDomain_disappears
=== RUN   TestAccCloudSearchDomain_indexFields
=== PAUSE TestAccCloudSearchDomain_indexFields
=== RUN   TestAccCloudSearchDomain_update
=== PAUSE TestAccCloudSearchDomain_update
=== CONT  TestAccCloudSearchDomain_basic
=== CONT  TestAccCloudSearchDomain_indexFields
=== CONT  TestAccCloudSearchDomain_update
=== CONT  TestAccCloudSearchDomain_disappears
--- PASS: TestAccCloudSearchDomain_disappears (713.17s)
--- PASS: TestAccCloudSearchDomain_basic (849.13s)
--- PASS: TestAccCloudSearchDomain_indexFields (1981.33s)
--- PASS: TestAccCloudSearchDomain_update (1995.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch	2001.576s

@github-actions github-actions bot added service/cloudsearch Issues and PRs that pertain to the cloudsearch service. size/M Managed by automation to categorize the size of a PR. labels Mar 15, 2022
@ewbankkit ewbankkit marked this pull request as ready for review March 15, 2022 13:40
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 15, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Mar 15, 2022
@YakDriver YakDriver self-assigned this Mar 15, 2022
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Output from acceptance tests:

% make testacc TESTS=TestAccCloudSearchDomain_ PKG=cloudsearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudsearch/... -v -count 1 -parallel 20 -run='TestAccCloudSearchDomain_'  -timeout 180m
--- PASS: TestAccCloudSearchDomain_basic (650.12s)
--- PASS: TestAccCloudSearchDomain_disappears (816.20s)
--- PASS: TestAccCloudSearchDomain_indexFields (1649.70s)
--- PASS: TestAccCloudSearchDomain_update (1761.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch	1763.074s

@ewbankkit ewbankkit merged commit 14066a3 into main Mar 15, 2022
@ewbankkit ewbankkit deleted the b-aws_cloudsearch_domain-index_field-diff branch March 15, 2022 16:08
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 15, 2022
github-actions bot pushed a commit that referenced this pull request Mar 15, 2022
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudsearch Issues and PRs that pertain to the cloudsearch service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cloudsearch_domain tries to update in-place index_field on each run
2 participants