Add Multi-AZ support for RDS clusters #23684

bschaatsbergen · 2022-03-15T09:39:10Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

make testacc TESTS=TestAccRDSCluster_ PKG=rds                                                                                                                (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_'  -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_allowMajorVersionUpgrade
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgrade
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== RUN   TestAccRDSCluster_onlyMajorVersion
=== PAUSE TestAccRDSCluster_onlyMajorVersion
=== RUN   TestAccRDSCluster_availabilityZones
=== PAUSE TestAccRDSCluster_availabilityZones
=== RUN   TestAccRDSCluster_storageType
=== PAUSE TestAccRDSCluster_storageType
=== RUN   TestAccRDSCluster_allocatedStorage
=== PAUSE TestAccRDSCluster_allocatedStorage
=== RUN   TestAccRDSCluster_iops
=== PAUSE TestAccRDSCluster_iops
=== RUN   TestAccRDSCluster_dbClusterInstanceClass
=== PAUSE TestAccRDSCluster_dbClusterInstanceClass
=== RUN   TestAccRDSCluster_backtrackWindow
=== PAUSE TestAccRDSCluster_backtrackWindow
=== RUN   TestAccRDSCluster_clusterIdentifierPrefix
=== PAUSE TestAccRDSCluster_clusterIdentifierPrefix
=== RUN   TestAccRDSCluster_dbSubnetGroupName
=== PAUSE TestAccRDSCluster_dbSubnetGroupName
=== RUN   TestAccRDSCluster_s3Restore
=== PAUSE TestAccRDSCluster_s3Restore
=== RUN   TestAccRDSCluster_pointInTimeRestore
=== PAUSE TestAccRDSCluster_pointInTimeRestore
=== RUN   TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== PAUSE TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== RUN   TestAccRDSCluster_generatedName
=== PAUSE TestAccRDSCluster_generatedName
=== RUN   TestAccRDSCluster_takeFinalSnapshot
=== PAUSE TestAccRDSCluster_takeFinalSnapshot
=== RUN   TestAccRDSCluster_missingUserNameCausesError
=== PAUSE TestAccRDSCluster_missingUserNameCausesError
=== RUN   TestAccRDSCluster_tags
=== PAUSE TestAccRDSCluster_tags
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSCluster_updateIAMRoles
=== PAUSE TestAccRDSCluster_updateIAMRoles
=== RUN   TestAccRDSCluster_kmsKey
=== PAUSE TestAccRDSCluster_kmsKey
=== RUN   TestAccRDSCluster_encrypted
=== PAUSE TestAccRDSCluster_encrypted
=== RUN   TestAccRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot
=== RUN   TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_backupsUpdate
=== PAUSE TestAccRDSCluster_backupsUpdate
=== RUN   TestAccRDSCluster_iamAuth
=== PAUSE TestAccRDSCluster_iamAuth
=== RUN   TestAccRDSCluster_deletionProtection
=== PAUSE TestAccRDSCluster_deletionProtection
=== RUN   TestAccRDSCluster_engineMode
=== PAUSE TestAccRDSCluster_engineMode
=== RUN   TestAccRDSCluster_EngineMode_global
=== PAUSE TestAccRDSCluster_EngineMode_global
=== RUN   TestAccRDSCluster_EngineMode_multiMaster
=== PAUSE TestAccRDSCluster_EngineMode_multiMaster
=== RUN   TestAccRDSCluster_EngineMode_parallelQuery
=== PAUSE TestAccRDSCluster_EngineMode_parallelQuery
=== RUN   TestAccRDSCluster_engineVersion
=== PAUSE TestAccRDSCluster_engineVersion
=== RUN   TestAccRDSCluster_engineVersionWithPrimaryInstance
=== PAUSE TestAccRDSCluster_engineVersionWithPrimaryInstance
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== RUN   TestAccRDSCluster_port
=== PAUSE TestAccRDSCluster_port
=== RUN   TestAccRDSCluster_scaling
=== PAUSE TestAccRDSCluster_scaling
=== RUN   TestAccRDSCluster_Scaling_defaultMinCapacity
=== PAUSE TestAccRDSCluster_Scaling_defaultMinCapacity
=== RUN   TestAccRDSCluster_snapshotIdentifier
=== PAUSE TestAccRDSCluster_snapshotIdentifier
=== RUN   TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless
    cluster_test.go:1629: serverless does not support snapshot restore on an empty volume
--- SKIP: TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless (0.00s)
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== RUN   TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== RUN   TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== RUN   TestAccRDSCluster_enableHTTPEndpoint
=== PAUSE TestAccRDSCluster_enableHTTPEndpoint
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== CONT  TestAccRDSCluster_takeFinalSnapshot
=== CONT  TestAccRDSCluster_deletionProtection
=== CONT  TestAccRDSCluster_engineVersionWithPrimaryInstance
=== CONT  TestAccRDSCluster_engineVersion
=== CONT  TestAccRDSCluster_EngineMode_parallelQuery
=== CONT  TestAccRDSCluster_EngineMode_multiMaster
=== CONT  TestAccRDSCluster_EngineMode_global
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
=== CONT  TestAccRDSCluster_engineMode
=== CONT  TestAccRDSCluster_s3Restore
=== CONT  TestAccRDSCluster_pointInTimeRestore
=== CONT  TestAccRDSCluster_dbSubnetGroupName
=== CONT  TestAccRDSCluster_clusterIdentifierPrefix
=== CONT  TestAccRDSCluster_iamAuth
=== CONT  TestAccRDSCluster_backupsUpdate
=== CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== CONT  TestAccRDSCluster_backtrackWindow
=== CONT  TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_missingUserNameCausesError (15.64s)
=== CONT  TestAccRDSCluster_copyTagsToSnapshot
--- PASS: TestAccRDSCluster_EngineMode_multiMaster (143.78s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_clusterIdentifierPrefix (163.13s)
=== CONT  TestAccRDSCluster_iops
--- PASS: TestAccRDSCluster_dbSubnetGroupName (163.65s)
=== CONT  TestAccRDSCluster_encrypted
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (181.60s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_backupsUpdate (182.61s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_backtrackWindow (182.98s)
=== CONT  TestAccRDSCluster_storageType
--- PASS: TestAccRDSCluster_EngineMode_global (183.47s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_basic (186.87s)
=== CONT  TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_EngineMode_parallelQuery (203.15s)
=== CONT  TestAccRDSCluster_generatedName
--- PASS: TestAccRDSCluster_iamAuth (203.47s)
=== CONT  TestAccRDSCluster_kmsKey
--- PASS: TestAccRDSCluster_takeFinalSnapshot (204.35s)
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_deletionProtection (224.61s)
=== CONT  TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (249.09s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_availabilityZones (147.12s)
=== CONT  TestAccRDSCluster_enableHTTPEndpoint
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (168.11s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
--- PASS: TestAccRDSCluster_encrypted (187.26s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
--- PASS: TestAccRDSCluster_generatedName (157.03s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
--- PASS: TestAccRDSCluster_tags (177.92s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
--- PASS: TestAccRDSCluster_kmsKey (165.35s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSCluster_pointInTimeRestore (371.68s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_updateIAMRoles (218.99s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (289.21s)
=== CONT  TestAccRDSCluster_snapshotIdentifier
--- PASS: TestAccRDSCluster_engineMode (502.00s)
=== CONT  TestAccRDSCluster_onlyMajorVersion
--- PASS: TestAccRDSCluster_engineVersion (509.54s)
=== CONT  TestAccRDSCluster_Scaling_defaultMinCapacity
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (398.45s)
=== CONT  TestAccRDSCluster_scaling
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (381.24s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_tags
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (452.55s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterPassword
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (392.02s)
=== CONT  TestAccRDSCluster_port
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (396.73s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (351.98s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
--- PASS: TestAccRDSCluster_snapshotIdentifier (391.41s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery (526.18s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (466.67s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
--- PASS: TestAccRDSCluster_port (217.85s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
--- PASS: TestAccRDSCluster_scaling (412.78s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (392.88s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (205.32s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== CONT  TestAccRDSCluster_s3Restore
    cluster_test.go:481: Step 1/1 error: Error running apply: exit status 1
        
        Error: Error waiting for RDS Cluster state to be "available": unexpected state 'migration-failed', wanted target 'available'. last error: %!s(<nil>)
        
          with aws_rds_cluster.test,
          on terraform_plugin_test.tf line 74, in resource "aws_rds_cluster" "test":
          74: resource "aws_rds_cluster" "test" {
        
=== CONT  TestAccRDSCluster_iops
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (394.23s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (204.22s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (757.87s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (433.55s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_onlyMajorVersion (762.47s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (1297.76s)
--- PASS: TestAccRDSCluster_allocatedStorage (1117.48s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (440.71s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1304.05s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (182.04s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (361.87s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (458.61s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (183.65s)
--- PASS: TestAccRDSCluster_iops (1229.57s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (413.35s)
--- PASS: TestAccRDSCluster_storageType (1282.81s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (412.36s)
--- FAIL: TestAccRDSCluster_s3Restore (1588.66s)
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (1673.03s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
    cluster_test.go:101: Step 3/3 error: Check failed: Check 4/4 error: aws_rds_cluster.test: Attribute 'engine_version' expected "13.5", got "12.9"


--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (1922.92s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (2096.21s)
--- FAIL: TestAccRDSCluster_allowMajorVersionUpgrade (1697.99s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (1897.84s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (1972.25s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (1991.96s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/rds        3106.801s
FAIL
make: *** [GNUmakefile:36: testacc] Error 1

…upport Multi-AZ DB clusters

…orage, iops and db_cluster_instance_class

…_cluster_instance_class attributes

…upport Multi-AZ DB clusters

…orage, iops and db_cluster_instance_class

…_cluster_instance_class attributes

…chaatsbergen/terraform-provider-aws into add-multi-az-rds-engine-types

…if not set.

bschaatsbergen · 2022-03-15T11:55:48Z

Heya @YakDriver & @ewbankkit, I re-created the PR as the previous one became a bit messy to review after the rebases I did. I'll touch up the documentation of aws_rds_cluster later today and include it in the PR.

bschaatsbergen · 2022-03-15T22:40:45Z

Not quite sure why terrafmt is complaining about my changes in cluster_test.go and the docs I updated. Besides that, I think we're good to go @ewbankkit @YakDriver ! 🥳

…ers.

ewbankkit · 2022-03-16T21:23:08Z

@bschaatsbergen It's tabs vs. spaces that causes the terrafmt errors. terrafmt requires spaces.

bschaatsbergen · 2022-03-16T22:13:19Z

@bschaatsbergen It's tabs vs. spaces that causes the terrafmt errors. terrafmt requires spaces.

Ah crap, that's good to know for the future. Thanks for fixing it!

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCluster_basic\|TestAccRDSCluster_availabilityZones\|TestAccRDSCluster_storageType\|TestAccRDSCluster_allocatedStorage\|TestAccRDSCluster_iops\|TestAccRDSCluster_dbClusterInstanceClass\|TestAccRDSCluster_scaling' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSCluster_basic\|TestAccRDSCluster_availabilityZones\|TestAccRDSCluster_storageType\|TestAccRDSCluster_allocatedStorage\|TestAccRDSCluster_iops\|TestAccRDSCluster_dbClusterInstanceClass\|TestAccRDSCluster_scaling -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_availabilityZones
=== PAUSE TestAccRDSCluster_availabilityZones
=== RUN   TestAccRDSCluster_storageType
=== PAUSE TestAccRDSCluster_storageType
=== RUN   TestAccRDSCluster_allocatedStorage
=== PAUSE TestAccRDSCluster_allocatedStorage
=== RUN   TestAccRDSCluster_iops
=== PAUSE TestAccRDSCluster_iops
=== RUN   TestAccRDSCluster_dbClusterInstanceClass
=== PAUSE TestAccRDSCluster_dbClusterInstanceClass
=== RUN   TestAccRDSCluster_scaling
=== PAUSE TestAccRDSCluster_scaling
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_iops
=== CONT  TestAccRDSCluster_scaling
--- PASS: TestAccRDSCluster_basic (162.63s)
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
--- PASS: TestAccRDSCluster_iops (367.07s)
=== CONT  TestAccRDSCluster_storageType
--- PASS: TestAccRDSCluster_scaling (387.85s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (1200.41s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_availabilityZones (126.73s)
--- PASS: TestAccRDSCluster_storageType (1263.22s)
--- PASS: TestAccRDSCluster_allocatedStorage (1252.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1643.992s

ewbankkit · 2022-03-16T22:27:25Z

@bschaatsbergen Thanks for the contribution 🎉 👏.

github-actions · 2022-03-18T20:22:17Z

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-09T02:34:43Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

YakDriver and others added 27 commits March 10, 2022 20:48

rds: Fix some acceptance tests

923fd86

Add constants for instance classes

8a96c73

rds/cluster: Debugging

8f43566

rds/instance: Modernize tests

5071312

rds/option_group_test: Make version dynamic

c8c9186

rds/ds/orderable: Make version dynamic

3f97227

rds/snapshot: Make version dynamic

6425207

snapshot/tests: Dynamic version

377d439

Additional test fixes

1f748cf

Continue skipping unfixed test

b12939f

Flint and steel

d54c884

More flint

cb0944d

Fix additional tests

c587562

rds: Fix additional issues

7a2dea7

Update changelog

a585794

Add session to client

f158a60

Glint in your eye

c7f22d7

Remove bad comment

b0a7915

hashicorp#23475 - Add mysql and postgres to validEngine func to s…

d445f14

…upport Multi-AZ DB clusters

hashicorp#23475 - Add required parameters: storage_type, allocated_st…

3b3aecc

…orage, iops and db_cluster_instance_class

Add acceptance tests for storage_type, allocated_storage, iops and db…

7523b4d

…_cluster_instance_class attributes

hashicorp#23475 - Add mysql and postgres to validEngine func to s…

00a4655

…upport Multi-AZ DB clusters

hashicorp#23475 - Add required parameters: storage_type, allocated_st…

b9d67e0

…orage, iops and db_cluster_instance_class

Add acceptance tests for storage_type, allocated_storage, iops and db…

38d2cdd

…_cluster_instance_class attributes

Create 23533.txt

c274ff2

Set iops to minimum value in acceptance tests

cdca52c

Merge branch 'add-multi-az-rds-engine-types' of https://github.com/bs…

e868d0c

…chaatsbergen/terraform-provider-aws into add-multi-az-rds-engine-types

bschaatsbergen mentioned this pull request Mar 15, 2022

Add Multi-AZ support for RDS clusters #23533

Closed

github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. labels Mar 15, 2022

github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Mar 15, 2022

bschaatsbergen added 2 commits March 15, 2022 10:40

Update changelog txt

d8de3ce

Set allocated_storage to Computed as default response yields a 1 …

8de533a

…if not set.

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 15, 2022

bschaatsbergen added 2 commits March 15, 2022 22:44

Touch up acceptance tests, get rid of AZs

c259b4a

Add Multi-AZ RDS cluster documentation

cdb08cf

github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 15, 2022

bschaatsbergen added 2 commits March 15, 2022 22:59

Update rds_cluster.html.markdown

c60f530

Set expected iops to 1000

2d7e1fe

bschaatsbergen and others added 4 commits March 15, 2022 23:43

Lint Multi-AZ acceptance tests

c5806a6

Point out which attributes are required to set for multi-az rds clust…

0c53ba8

…ers.

r/aws_rds_cluster: Fix terrafmt errors.

f4bc47f

Tweak CHANGELOG entry.

7b652d2

Fix terrafmt website errors.

fd38a00

ewbankkit approved these changes Mar 16, 2022

View reviewed changes

ewbankkit merged commit 0e164df into hashicorp:main Mar 16, 2022

github-actions bot added this to the v4.6.0 milestone Mar 16, 2022

bschaatsbergen deleted the add-multi-az-rds-support branch March 16, 2022 22:36

darraghenright mentioned this pull request Mar 28, 2022

Multi-AZ cluster database deployments on RDS for Postgres and MySQL terraform-aws-modules/terraform-aws-rds#394

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Multi-AZ support for RDS clusters #23684

Add Multi-AZ support for RDS clusters #23684

bschaatsbergen commented Mar 15, 2022 •

edited

Loading

bschaatsbergen commented Mar 15, 2022

bschaatsbergen commented Mar 15, 2022 •

edited

Loading

ewbankkit commented Mar 16, 2022

bschaatsbergen commented Mar 16, 2022

ewbankkit left a comment

ewbankkit commented Mar 16, 2022

github-actions bot commented Mar 18, 2022

github-actions bot commented May 9, 2022

Add Multi-AZ support for RDS clusters #23684

Add Multi-AZ support for RDS clusters #23684

Conversation

bschaatsbergen commented Mar 15, 2022 • edited Loading

Community Note

bschaatsbergen commented Mar 15, 2022

bschaatsbergen commented Mar 15, 2022 • edited Loading

ewbankkit commented Mar 16, 2022

bschaatsbergen commented Mar 16, 2022

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Mar 16, 2022

github-actions bot commented Mar 18, 2022

github-actions bot commented May 9, 2022

bschaatsbergen commented Mar 15, 2022 •

edited

Loading

bschaatsbergen commented Mar 15, 2022 •

edited

Loading