New resource for Route53 Traffic Policy and Traffic Policy Instance, datasource for Route53 Traffic Policy #23602

coderGo93 · 2022-03-10T00:11:39Z

Added a new resource, doc and tests for Route53 Traffic Policy called aws_route53_traffic_policy
Added a new datasource, doc and tests for Route53 Traffic Policy Document called aws_route53_traffic_policy_document
Added a new resource, doc and tests for Route53 Traffic Policy Instance called aws_route53_traffic_policy_instance

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

Resource Route 53 Traffic Policy

$ make testacc TESTARGS='-run=TestAccTrafficPolicy_' PKG=route53      [16:55:52]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20  -run=TestAccTrafficPolicy_ -timeout 180m
=== RUN   TestAccTrafficPolicy_basic
=== PAUSE TestAccTrafficPolicy_basic
=== RUN   TestAccTrafficPolicy_disappears
=== PAUSE TestAccTrafficPolicy_disappears
=== RUN   TestAccTrafficPolicy_complete
=== PAUSE TestAccTrafficPolicy_complete
=== CONT  TestAccTrafficPolicy_basic
=== CONT  TestAccTrafficPolicy_complete
=== CONT  TestAccTrafficPolicy_disappears
--- PASS: TestAccTrafficPolicy_disappears (14.30s)
--- PASS: TestAccTrafficPolicy_basic (19.19s)
--- PASS: TestAccTrafficPolicy_complete (30.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    33.095s

Datasource Route 53 Traffic Policy Document

$ make testacc TESTARGS='-run=TestAccDataSourceTrafficPolicyDocument_' PKG=route53          [10:28:42]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20  -run=TestAccDataSourceTrafficPolicyDocument_ -timeout 180m
=== RUN   TestAccDataSourceTrafficPolicyDocument_basic
=== PAUSE TestAccDataSourceTrafficPolicyDocument_basic
=== RUN   TestAccDataSourceTrafficPolicyDocument_complete
=== PAUSE TestAccDataSourceTrafficPolicyDocument_complete
=== CONT  TestAccDataSourceTrafficPolicyDocument_basic
=== CONT  TestAccDataSourceTrafficPolicyDocument_complete
--- PASS: TestAccDataSourceTrafficPolicyDocument_basic (12.97s)
--- PASS: TestAccDataSourceTrafficPolicyDocument_complete (13.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    16.056s

Resource Route 53 Traffic Policy Instance

$ make testacc TESTARGS='-run=TestAccTrafficPolicyInstance_' PKG=route53                    [17:04:52]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20  -run=TestAccTrafficPolicyInstance_ -timeout 180m
=== RUN   TestAccTrafficPolicyInstance_basic
=== PAUSE TestAccTrafficPolicyInstance_basic
=== RUN   TestAccTrafficPolicyInstance_disappears
=== PAUSE TestAccTrafficPolicyInstance_disappears
=== RUN   TestAccTrafficPolicyInstance_complete
=== PAUSE TestAccTrafficPolicyInstance_complete
=== CONT  TestAccTrafficPolicyInstance_basic
=== CONT  TestAccTrafficPolicyInstance_complete
=== CONT  TestAccTrafficPolicyInstance_disappears
--- PASS: TestAccTrafficPolicyInstance_disappears (116.59s)
--- PASS: TestAccTrafficPolicyInstance_basic (128.91s)
--- PASS: TestAccTrafficPolicyInstance_complete (211.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    214.002s

ewbankkit · 2022-03-10T13:10:37Z

Supersedes #14331.
Supersedes #14352.

This reverts commit a6293a2.

This reverts commit 11a3018.

This reverts commit c79230c.

This reverts commit be4171f.

Acceptance test output: % make testacc TESTS=TestAccTrafficPolicy_basic PKG=route53 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccTrafficPolicy_basic' -timeout 180m === RUN TestAccTrafficPolicy_basic === PAUSE TestAccTrafficPolicy_basic === CONT TestAccTrafficPolicy_basic --- PASS: TestAccTrafficPolicy_basic (19.28s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 26.600s

Acceptance test output: % make testacc TESTS=TestAccTrafficPolicy_ PKG=route53 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccTrafficPolicy_' -timeout 180m === RUN TestAccTrafficPolicy_basic === PAUSE TestAccTrafficPolicy_basic === RUN TestAccTrafficPolicy_disappears === PAUSE TestAccTrafficPolicy_disappears === RUN TestAccTrafficPolicy_update === PAUSE TestAccTrafficPolicy_update === CONT TestAccTrafficPolicy_basic === CONT TestAccTrafficPolicy_update === CONT TestAccTrafficPolicy_disappears --- PASS: TestAccTrafficPolicy_disappears (13.66s) --- PASS: TestAccTrafficPolicy_basic (18.33s) --- PASS: TestAccTrafficPolicy_update (29.13s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 33.269s

…anceByID' and callers.

Acceptance test output: % make testacc TESTS=TestAccRoute53TrafficPolicyInstance_ PKG=route53 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53TrafficPolicyInstance_' -timeout 180m === RUN TestAccRoute53TrafficPolicyInstance_basic === PAUSE TestAccRoute53TrafficPolicyInstance_basic === RUN TestAccRoute53TrafficPolicyInstance_disappears === PAUSE TestAccRoute53TrafficPolicyInstance_disappears === RUN TestAccRoute53TrafficPolicyInstance_update === PAUSE TestAccRoute53TrafficPolicyInstance_update === CONT TestAccRoute53TrafficPolicyInstance_basic === CONT TestAccRoute53TrafficPolicyInstance_update === CONT TestAccRoute53TrafficPolicyInstance_disappears --- PASS: TestAccRoute53TrafficPolicyInstance_basic (134.02s) --- PASS: TestAccRoute53TrafficPolicyInstance_disappears (139.24s) --- PASS: TestAccRoute53TrafficPolicyInstance_update (199.29s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 206.030s

… names.

…(deadcode)".

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTS=TestAccRoute53TrafficPolicy PKG=route53 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3 -run='TestAccRoute53TrafficPolicy'  -timeout 180m
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== RUN   TestAccRoute53TrafficPolicyInstance_basic
=== PAUSE TestAccRoute53TrafficPolicyInstance_basic
=== RUN   TestAccRoute53TrafficPolicyInstance_disappears
=== PAUSE TestAccRoute53TrafficPolicyInstance_disappears
=== RUN   TestAccRoute53TrafficPolicyInstance_update
=== PAUSE TestAccRoute53TrafficPolicyInstance_update
=== RUN   TestAccRoute53TrafficPolicy_basic
=== PAUSE TestAccRoute53TrafficPolicy_basic
=== RUN   TestAccRoute53TrafficPolicy_disappears
=== PAUSE TestAccRoute53TrafficPolicy_disappears
=== RUN   TestAccRoute53TrafficPolicy_update
=== PAUSE TestAccRoute53TrafficPolicy_update
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== CONT  TestAccRoute53TrafficPolicyInstance_update
=== CONT  TestAccRoute53TrafficPolicy_disappears
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_basic (13.92s)
=== CONT  TestAccRoute53TrafficPolicy_update
--- PASS: TestAccRoute53TrafficPolicy_disappears (15.53s)
=== CONT  TestAccRoute53TrafficPolicyInstance_basic
--- PASS: TestAccRoute53TrafficPolicy_update (30.47s)
=== CONT  TestAccRoute53TrafficPolicyInstance_disappears
--- PASS: TestAccRoute53TrafficPolicyInstance_basic (139.79s)
=== CONT  TestAccRoute53TrafficPolicy_basic
--- PASS: TestAccRoute53TrafficPolicy_basic (18.04s)
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_complete
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_complete (11.99s)
--- PASS: TestAccRoute53TrafficPolicyInstance_disappears (158.03s)
--- PASS: TestAccRoute53TrafficPolicyInstance_update (205.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	210.736s

GovCloud

% make testacc TESTS=TestAccRoute53TrafficPolicy PKG=route53 ACCTEST_PARALLELISM=3           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3 -run='TestAccRoute53TrafficPolicy'  -timeout 180m
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== RUN   TestAccRoute53TrafficPolicyInstance_basic
=== PAUSE TestAccRoute53TrafficPolicyInstance_basic
=== RUN   TestAccRoute53TrafficPolicyInstance_disappears
=== PAUSE TestAccRoute53TrafficPolicyInstance_disappears
=== RUN   TestAccRoute53TrafficPolicyInstance_update
=== PAUSE TestAccRoute53TrafficPolicyInstance_update
=== RUN   TestAccRoute53TrafficPolicy_basic
=== PAUSE TestAccRoute53TrafficPolicy_basic
=== RUN   TestAccRoute53TrafficPolicy_disappears
=== PAUSE TestAccRoute53TrafficPolicy_disappears
=== RUN   TestAccRoute53TrafficPolicy_update
=== PAUSE TestAccRoute53TrafficPolicy_update
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== CONT  TestAccRoute53TrafficPolicyInstance_update
=== CONT  TestAccRoute53TrafficPolicy_disappears
=== CONT  TestAccRoute53TrafficPolicyInstance_update
    traffic_policy_instance_test.go:23: Route 53 Traffic Policies are not supported in aws-us-gov partition
--- SKIP: TestAccRoute53TrafficPolicyInstance_update (1.13s)
=== CONT  TestAccRoute53TrafficPolicy_update
=== CONT  TestAccRoute53TrafficPolicy_disappears
    traffic_policy_instance_test.go:23: Route 53 Traffic Policies are not supported in aws-us-gov partition
=== CONT  TestAccRoute53TrafficPolicy_update
    traffic_policy_instance_test.go:23: Route 53 Traffic Policies are not supported in aws-us-gov partition
--- SKIP: TestAccRoute53TrafficPolicy_update (0.00s)
=== CONT  TestAccRoute53TrafficPolicy_basic
--- SKIP: TestAccRoute53TrafficPolicy_disappears (1.13s)
=== CONT  TestAccRoute53TrafficPolicyInstance_basic
=== CONT  TestAccRoute53TrafficPolicy_basic
    traffic_policy_instance_test.go:23: Route 53 Traffic Policies are not supported in aws-us-gov partition
--- SKIP: TestAccRoute53TrafficPolicy_basic (0.00s)
=== CONT  TestAccRoute53TrafficPolicyInstance_disappears
    traffic_policy_instance_test.go:23: Route 53 Traffic Policies are not supported in aws-us-gov partition
--- SKIP: TestAccRoute53TrafficPolicyInstance_disappears (0.00s)
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_complete
=== CONT  TestAccRoute53TrafficPolicyInstance_basic
    traffic_policy_instance_test.go:23: Route 53 Traffic Policies are not supported in aws-us-gov partition
--- SKIP: TestAccRoute53TrafficPolicyInstance_basic (0.00s)
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_basic (10.86s)
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_complete (10.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	14.856s

ewbankkit · 2022-03-22T15:29:21Z

@coderGo93 Thanks for the contribution 🎉 👏.

github-actions · 2022-03-25T00:02:09Z

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-05T02:31:36Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Michal Wieczorek and others added 14 commits August 21, 2020 15:33

resource/aws_route53_traffic_policy: new resource

935a604

resource/aws_route53_traffic_policy: new resource

d43efaa

Add read at the end of update func

be4171f

Add import testing

c79230c

Switch to terraform-plugin-sdk v2

11a3018

resource/aws_route53_traffic_policy_instance: new resource

a6293a2

feat: added resource for route53 traffic policy

db95826

docs: added resource for route53 traffic policy

274ff1c

refactor: refactorized in update traffice policy resource

617a177

feat: added datasource for traffic policy

70ac896

docs: added datasource for traffic policy

625732c

feat: added resource for traffic policy instance

d5f4a84

docs: added resource for traffic policy instance

e56ab1e

fixes typo

65282a4

added changelog

437414a

ewbankkit added new-data-source Introduces a new data source. new-resource Introduces a new resource. labels Mar 10, 2022

refactor: changed datasource to traffic policy document

e5a6741

justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 15, 2022

ewbankkit added 4 commits March 21, 2022 12:02

Revert "resource/aws_route53_traffic_policy_instance: new resource"

5f3659c

This reverts commit a6293a2.

Revert "Switch to terraform-plugin-sdk v2"

25f54c2

This reverts commit 11a3018.

Revert "Add import testing"

db9e305

This reverts commit c79230c.

Revert "Add read at the end of update func"

296d99a

This reverts commit be4171f.

ewbankkit mentioned this pull request Mar 21, 2022

resource/aws_route53_traffic_policy: new resource #14331

Closed

ewbankkit self-assigned this Mar 21, 2022

ewbankkit added 15 commits March 21, 2022 16:47

Data source in alphabetical order.

79764cf

Generate list paginators.

44f4c83

r/aws_route53_traffic_policy: Tidy up resource Create.

f12239e

Add optional output file argument to lister generator.

8a1d808

Seperate list generator output files.

f79eae8

r/aws_route53_traffic_policy: Add Sweeper.

0597814

Add 'Route53' to acceptance test function names.

79d1213

r/aws_route53_traffic_policy_instance: Remove 'state' attribute.

8f25300

Add 'Route53' to acceptance test function names.

ed2d010

r/aws_route53_traffic_policy_instance: Tidy up 'FindTrafficPolicyInst…

bb0bc4c

…anceByID' and callers.

r/aws_route53_traffic_policy_instance: Remove 'message' attribute.

c1ee0e6

r/aws_route53_traffic_policy_instance: Add Sweeper.

efeb888

github-actions bot added generators Relates to code generators. sweeper Pertains to changes to or issues with the sweeper. labels Mar 22, 2022

ewbankkit added 3 commits March 22, 2022 09:57

d/aws_route53_traffic_policy_document: Tweak acceptance test function…

9e3bcf6

… names.

Fix golangci-lint error "'listTrafficPolicyInstancesPages' is unused …

5cf1edb

…(deadcode)".

Route 53 Traffic Policies not available in AWS GovCloud.

4f3dd99

ewbankkit approved these changes Mar 22, 2022

View reviewed changes

ewbankkit removed their assignment Mar 22, 2022

ewbankkit merged commit 4083f34 into hashicorp:main Mar 22, 2022

github-actions bot added this to the v4.7.0 milestone Mar 22, 2022

github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource for Route53 Traffic Policy and Traffic Policy Instance, datasource for Route53 Traffic Policy #23602

New resource for Route53 Traffic Policy and Traffic Policy Instance, datasource for Route53 Traffic Policy #23602

coderGo93 commented Mar 10, 2022 •

edited by ewbankkit

Loading

ewbankkit commented Mar 10, 2022 •

edited

Loading

ewbankkit left a comment

ewbankkit commented Mar 22, 2022

github-actions bot commented Mar 25, 2022

github-actions bot commented May 5, 2022

New resource for Route53 Traffic Policy and Traffic Policy Instance, datasource for Route53 Traffic Policy #23602

New resource for Route53 Traffic Policy and Traffic Policy Instance, datasource for Route53 Traffic Policy #23602

Conversation

coderGo93 commented Mar 10, 2022 • edited by ewbankkit Loading

Community Note

ewbankkit commented Mar 10, 2022 • edited Loading

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Mar 22, 2022

github-actions bot commented Mar 25, 2022

github-actions bot commented May 5, 2022

coderGo93 commented Mar 10, 2022 •

edited by ewbankkit

Loading

ewbankkit commented Mar 10, 2022 •

edited

Loading