-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_synthetics_canrany: Add environment variables to run config #23574
resource/aws_synthetics_canrany: Add environment variables to run config #23574
Conversation
08db187
to
67cf9bf
Compare
67cf9bf
to
e73956e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small notes and suggestion for test coverage, otherwise looks great! 🚀
Output of acceptance tests:
--- PASS: TestAccSyntheticsCanary_basic (101.57s)
--- PASS: TestAccSyntheticsCanary_disappears (45.79s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (110.83s)
--- PASS: TestAccSyntheticsCanary_runTracing (107.60s)
--- PASS: TestAccSyntheticsCanary_run (104.56s)
--- PASS: TestAccSyntheticsCanary_s3 (48.70s)
--- PASS: TestAccSyntheticsCanary_tags (135.20s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (71.57s)
--- PASS: TestAccSyntheticsCanary_startCanary (113.68s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (99.94s)
--- PASS: TestAccSyntheticsCanary_vpc (2172.63s)
Co-authored-by: angie pinilla <[email protected]>
Co-authored-by: angie pinilla <[email protected]>
Co-authored-by: angie pinilla <[email protected]>
f84fa6a
to
6ad6885
Compare
6ad6885
to
cc1e9db
Compare
This functionality has been released in v4.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
The reason why this was not implemented until now is that |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #17948
Output from acceptance testing: