Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_synthetics_canrany: Add environment variables to run config #23574

Merged
merged 13 commits into from
Mar 9, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Mar 8, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17948

Output from acceptance testing:

$ make testacc TESTS=TestAccSyntheticsCanary_run PKG=synthetics

=== RUN   TestAccSyntheticsCanary_runtimeVersion
=== PAUSE TestAccSyntheticsCanary_runtimeVersion
=== RUN   TestAccSyntheticsCanary_run
=== PAUSE TestAccSyntheticsCanary_run
=== RUN   TestAccSyntheticsCanary_runTracing
=== PAUSE TestAccSyntheticsCanary_runTracing
=== RUN   TestAccSyntheticsCanary_runEnvironmentVariables
=== PAUSE TestAccSyntheticsCanary_runEnvironmentVariables
=== CONT  TestAccSyntheticsCanary_runtimeVersion
=== CONT  TestAccSyntheticsCanary_runTracing
=== CONT  TestAccSyntheticsCanary_runEnvironmentVariables
=== CONT  TestAccSyntheticsCanary_run
--- PASS: TestAccSyntheticsCanary_runtimeVersion (94.30s)
--- PASS: TestAccSyntheticsCanary_runTracing (94.37s)
--- PASS: TestAccSyntheticsCanary_run (128.28s)
--- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (179.27s)
PASS

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/synthetics Issues and PRs that pertain to the synthetics service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Mar 8, 2022
@johnsonaj johnsonaj force-pushed the r/aws_synthetics_carany_environment_variables branch 2 times, most recently from 08db187 to 67cf9bf Compare March 8, 2022 17:16
@johnsonaj johnsonaj force-pushed the r/aws_synthetics_carany_environment_variables branch from 67cf9bf to e73956e Compare March 8, 2022 17:19
@johnsonaj johnsonaj marked this pull request as ready for review March 8, 2022 22:53
@anGie44 anGie44 self-assigned this Mar 9, 2022
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small notes and suggestion for test coverage, otherwise looks great! 🚀

Output of acceptance tests:

--- PASS: TestAccSyntheticsCanary_basic (101.57s)
--- PASS: TestAccSyntheticsCanary_disappears (45.79s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (110.83s)
--- PASS: TestAccSyntheticsCanary_runTracing (107.60s)
--- PASS: TestAccSyntheticsCanary_run (104.56s)
--- PASS: TestAccSyntheticsCanary_s3 (48.70s)
--- PASS: TestAccSyntheticsCanary_tags (135.20s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (71.57s)
--- PASS: TestAccSyntheticsCanary_startCanary (113.68s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (99.94s)
--- PASS: TestAccSyntheticsCanary_vpc (2172.63s)

.changelog/23574.txt Outdated Show resolved Hide resolved
internal/service/synthetics/canary.go Outdated Show resolved Hide resolved
internal/service/synthetics/canary.go Outdated Show resolved Hide resolved
internal/service/synthetics/canary.go Outdated Show resolved Hide resolved
internal/service/synthetics/canary_test.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 9, 2022
@johnsonaj johnsonaj force-pushed the r/aws_synthetics_carany_environment_variables branch from f84fa6a to 6ad6885 Compare March 9, 2022 18:51
@johnsonaj johnsonaj force-pushed the r/aws_synthetics_carany_environment_variables branch from 6ad6885 to cc1e9db Compare March 9, 2022 19:00
@johnsonaj johnsonaj merged commit 8715267 into main Mar 9, 2022
@johnsonaj johnsonaj deleted the r/aws_synthetics_carany_environment_variables branch March 9, 2022 20:05
@github-actions github-actions bot added this to the v4.5.0 milestone Mar 9, 2022
github-actions bot pushed a commit that referenced this pull request Mar 9, 2022
@github-actions
Copy link

This functionality has been released in v4.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@anilkumarkodali
Copy link

The reason why this was not implemented until now is that CanaryRunConfigOutput of the aws-sdk-go does not return EnvironmentVariables which makes it difficult to find out any drift in case variables are updated outside of terraform. While these changes work one way, drift detection continues to be an issue until the GET call returns environment variables.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/synthetics Issues and PRs that pertain to the synthetics service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Synthetics Canary Missing support for Environment Variables
3 participants