resource/aws_s3_bucket: Add top-level object_lock_enabled parameter

[gdavison]

Adds top-level object_lock_enabled parameter to aws_s3_bucket and deprecates object_lock_configuration.object_lock_enabled.

Closes #23549

Output from acceptance testing:

$ make testacc PKG=s3 TESTS='TestAccS3Bucket_|TestAccS3BucketObject_|TestAccS3BucketObjectDataSource_|TestAccS3Object_|TestAccS3ObjectDataSource_'

--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (170.67s)
--- PASS: TestAccS3BucketObjectDataSource_basic (188.71s)
--- PASS: TestAccS3Object_objectBucketKeyEnabled (190.64s)
--- PASS: TestAccS3Object_defaultBucketSSE (196.46s)
--- PASS: TestAccS3Object_bucketBucketKeyEnabled (198.22s)
--- SKIP: TestAccS3Object_nonVersioned (0.00s)
--- PASS: TestAccS3Object_sse (244.58s)
--- PASS: TestAccS3BucketObject_sse (254.45s)
--- PASS: TestAccS3Object_kms (255.85s)
--- PASS: TestAccS3Object_ignoreTags (337.50s)
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithOn (351.01s)
--- PASS: TestAccS3ObjectDataSource_allParams (197.22s)
--- PASS: TestAccS3ObjectDataSource_bucketKeyEnabled (196.90s)
--- PASS: TestAccS3ObjectDataSource_kmsEncrypted (194.07s)
--- PASS: TestAccS3ObjectDataSource_readableBody (195.66s)
--- PASS: TestAccS3Object_objectLockRetentionStartWithNone (506.35s)
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithNone (506.70s)
--- PASS: TestAccS3Object_updatesWithVersioningViaAccessPoint (351.02s)
--- PASS: TestAccS3Object_metadata (534.27s)
--- PASS: TestAccS3ObjectDataSource_basicViaAccessPoint (200.78s)
--- PASS: TestAccS3Object_updateSameFile (348.66s)
--- PASS: TestAccS3Object_acl (548.57s)
--- PASS: TestAccS3ObjectDataSource_basic (198.60s)
--- PASS: TestAccS3Object_updatesWithVersioning (410.63s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (206.34s)
--- PASS: TestAccS3Object_updates (408.33s)
--- PASS: TestAccS3Object_noNameNoKey (83.07s)
--- PASS: TestAccS3Object_tagsMultipleSlashes (636.75s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (197.20s)
--- PASS: TestAccS3Object_tagsLeadingMultipleSlashes (645.02s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (197.56s)
--- PASS: TestAccS3Object_objectLockRetentionStartWithSet (656.26s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (252.12s)
--- PASS: TestAccS3Object_tags (707.15s)
--- PASS: TestAccS3Object_tagsLeadingSingleSlash (712.03s)
--- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOff (195.70s)
--- PASS: TestAccS3Object_withContentCharacteristics (189.98s)
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (244.88s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (247.76s)
--- PASS: TestAccS3Bucket_Manage_objectLock (243.50s)
--- PASS: TestAccS3Object_empty (243.10s)
--- PASS: TestAccS3Object_contentBase64 (180.41s)
--- PASS: TestAccS3ObjectDataSource_singleSlashAsKey (178.18s)
--- PASS: TestAccS3Object_source (240.37s)
--- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOn (182.78s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (179.10s)
--- PASS: TestAccS3Object_storageClass (828.13s)
--- PASS: TestAccS3Bucket_Basic_generatedName (230.63s)
--- SKIP: TestAccS3BucketObject_nonVersioned (0.00s)
--- PASS: TestAccS3Object_etagEncryption (229.89s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (224.72s)
--- PASS: TestAccS3Object_content (225.57s)
--- PASS: TestAccS3ObjectDataSource_multipleSlashes (310.51s)
--- PASS: TestAccS3Bucket_Tags_basic (228.77s)
--- PASS: TestAccS3ObjectDataSource_leadingSlash (310.81s)
--- PASS: TestAccS3BucketObject_source (225.66s)
--- PASS: TestAccS3Object_sourceHashTrigger (362.09s)
--- PASS: TestAccS3BucketObject_kms (225.10s)
--- PASS: TestAccS3Bucket_Basic_emptyString (225.31s)
--- PASS: TestAccS3BucketObject_noNameNoKey (67.40s)
--- PASS: TestAccS3Bucket_Basic_basic (223.41s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (171.37s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (170.21s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (311.70s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (306.17s)
--- PASS: TestAccS3BucketObject_updateSameFile (311.23s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (178.09s)
--- PASS: TestAccS3BucketObject_contentBase64 (172.33s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (362.27s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (173.43s)
--- PASS: TestAccS3BucketObject_ignoreTags (316.13s)
--- PASS: TestAccS3BucketObject_empty (223.10s)
--- PASS: TestAccS3BucketObject_etagEncryption (224.69s)
--- PASS: TestAccS3BucketObject_updates (364.70s)
--- PASS: TestAccS3BucketObject_content (227.55s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (176.07s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (354.41s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (301.93s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (302.85s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (171.22s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (168.23s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (171.02s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (159.25s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (607.39s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (289.81s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (643.39s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (138.39s)
--- PASS: TestAccS3BucketObjectDataSource_allParams (133.47s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (383.18s)
--- PASS: TestAccS3BucketObject_metadata (411.04s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (457.52s)
--- PASS: TestAccS3BucketObject_acl (361.93s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (318.26s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (447.38s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (396.65s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (431.82s)
--- PASS: TestAccS3BucketObject_tags (420.48s)
--- PASS: TestAccS3BucketObject_storageClass (447.42s)

[anGie44]

Edit: I forgot the aws_s3_bucket_object_lock_configuration documentation will also need to be updated as the example uses the now-deprecated form, otherwise LGTM 🚀

[gdavison]

Good catch on the documentation

[github-actions]

This functionality has been released in v4.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.