resource/aws_amplify_app: update repository attribute in place
#23517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @mmourick 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
bug
bschaatsbergen
approved these changes
Mar 6, 2022
martijnvdgrift
approved these changes
Mar 7, 2022
…ors like 'Rate exceeded while calling CreateApp, please slow down or try again later.'.
github-actions
bot
added
the
tests
ewbankkit
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTS=TestAccAmplify_serial/App PKG=amplify ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amplify/... -v -count 1 -parallel 3 -run='TestAccAmplify_serial/App' -timeout 180m
=== RUN TestAccAmplify_serial
=== RUN TestAccAmplify_serial/App
=== RUN TestAccAmplify_serial/App/basic
=== PAUSE TestAccAmplify_serial/App/basic
=== RUN TestAccAmplify_serial/App/disappears
=== PAUSE TestAccAmplify_serial/App/disappears
=== RUN TestAccAmplify_serial/App/AutoBranchCreationConfig
=== PAUSE TestAccAmplify_serial/App/AutoBranchCreationConfig
=== RUN TestAccAmplify_serial/App/BuildSpec
=== PAUSE TestAccAmplify_serial/App/BuildSpec
=== RUN TestAccAmplify_serial/App/CustomRules
=== PAUSE TestAccAmplify_serial/App/CustomRules
=== RUN TestAccAmplify_serial/App/IamServiceRole
=== PAUSE TestAccAmplify_serial/App/IamServiceRole
=== RUN TestAccAmplify_serial/App/Tags
=== PAUSE TestAccAmplify_serial/App/Tags
=== RUN TestAccAmplify_serial/App/BasicAuthCredentials
=== PAUSE TestAccAmplify_serial/App/BasicAuthCredentials
=== RUN TestAccAmplify_serial/App/Description
=== PAUSE TestAccAmplify_serial/App/Description
=== RUN TestAccAmplify_serial/App/EnvironmentVariables
=== PAUSE TestAccAmplify_serial/App/EnvironmentVariables
=== RUN TestAccAmplify_serial/App/Name
=== PAUSE TestAccAmplify_serial/App/Name
=== RUN TestAccAmplify_serial/App/Repository
app_test.go:541: Environment variable AMPLIFY_GITHUB_ACCESS_TOKEN is not set
=== CONT TestAccAmplify_serial/App/basic
=== CONT TestAccAmplify_serial/App/Tags
=== CONT TestAccAmplify_serial/App/BuildSpec
=== CONT TestAccAmplify_serial/App/IamServiceRole
=== CONT TestAccAmplify_serial/App/CustomRules
=== CONT TestAccAmplify_serial/App/AutoBranchCreationConfig
=== CONT TestAccAmplify_serial/App/disappears
=== CONT TestAccAmplify_serial/App/EnvironmentVariables
=== CONT TestAccAmplify_serial/App/Name
=== CONT TestAccAmplify_serial/App/Description
=== CONT TestAccAmplify_serial/App/BasicAuthCredentials
=== CONT TestAccAmplify_serial/App/Description
app_test.go:376: Step 4/4 error: Error running apply: exit status 1
Error: error creating Amplify App (tf-acc-test-5910433071672985256): BadRequestException: Rate exceeded while calling CreateApp, please slow down or try again later.
with aws_amplify_app.test,
on terraform_plugin_test.tf line 2, in resource "aws_amplify_app" "test":
2: resource "aws_amplify_app" "test" {
=== CONT TestAccAmplify_serial/App/BasicAuthCredentials
app_test.go:239: Step 1/4 error: Error running apply: exit status 1
Error: error creating Amplify App (tf-acc-test-4498095110754920113): BadRequestException: Rate exceeded while calling CreateApp, please slow down or try again later.
with aws_amplify_app.test,
on terraform_plugin_test.tf line 2, in resource "aws_amplify_app" "test":
2: resource "aws_amplify_app" "test" {
--- FAIL: TestAccAmplify_serial (191.39s)
--- FAIL: TestAccAmplify_serial/App (0.00s)
--- SKIP: TestAccAmplify_serial/App/Repository (0.00s)
--- PASS: TestAccAmplify_serial/App/basic (37.45s)
--- PASS: TestAccAmplify_serial/App/Tags (65.32s)
--- PASS: TestAccAmplify_serial/App/BuildSpec (78.60s)
--- PASS: TestAccAmplify_serial/App/IamServiceRole (71.83s)
--- PASS: TestAccAmplify_serial/App/CustomRules (59.51s)
--- PASS: TestAccAmplify_serial/App/AutoBranchCreationConfig (67.88s)
--- PASS: TestAccAmplify_serial/App/disappears (37.45s)
--- PASS: TestAccAmplify_serial/App/EnvironmentVariables (54.10s)
--- FAIL: TestAccAmplify_serial/App/Description (36.41s)
--- FAIL: TestAccAmplify_serial/App/BasicAuthCredentials (4.89s)
--- PASS: TestAccAmplify_serial/App/Name (44.91s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/amplify 195.601s
FAIL
make: *** [testacc] Error 1Errors are unrelated to this change.
…duce errors like 'Rate exceeded while calling CreateApp, please slow down or try again later.'." This reverts commit 86eaf8f.
github-actions
bot
added
size/S
|
This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where an
aws_amplify_appwill be destroyed and recreated when modifying therepositoryattribute instead of being updated in place.Closes #23499
Community Note
Output from acceptance testing:
Some tests fail due to rate limits somehow, however the relevant tests (repository related) pass.