Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs/iso: Fix describe with configuration #23341

Merged
merged 3 commits into from
Feb 23, 2022
Merged

ecs/iso: Fix describe with configuration #23341

merged 3 commits into from
Feb 23, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22532
Closes #23342

Output from acceptance testing (us-west-2):

% make testacc TESTS=TestAccECSCluster_ PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSCluster_' -short -timeout 180m
--- PASS: TestAccECSCluster_disappears (29.55s)
--- PASS: TestAccECSCluster_basic (34.73s)
--- PASS: TestAccECSCluster_capacityProviders (48.55s)
--- PASS: TestAccECSCluster_tags (55.15s)
--- PASS: TestAccECSCluster_configuration (56.29s)
--- PASS: TestAccECSCluster_capacityProvidersNoStrategy (62.52s)
--- PASS: TestAccECSCluster_singleCapacityProvider (66.22s)
--- PASS: TestAccECSCluster_containerInsights (74.17s)
--- PASS: TestAccECSCluster_capacityProvidersUpdate (82.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	84.370s

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccECSCluster_ PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSCluster_' -short -timeout 180m
--- PASS: TestAccECSCluster_disappears (24.32s)
--- PASS: TestAccECSCluster_basic (28.39s)
--- PASS: TestAccECSCluster_capacityProviders (37.61s)
--- PASS: TestAccECSCluster_tags (48.72s)
--- PASS: TestAccECSCluster_configuration (50.45s)
--- PASS: TestAccECSCluster_capacityProvidersNoStrategy (51.77s)
--- PASS: TestAccECSCluster_singleCapacityProvider (65.77s)
--- PASS: TestAccECSCluster_containerInsights (66.75s)
--- PASS: TestAccECSCluster_capacityProvidersUpdate (71.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	73.020s

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. labels Feb 23, 2022
@YakDriver YakDriver added this to the v4.3.0 milestone Feb 23, 2022
@YakDriver YakDriver added the partition/aws-iso-b Pertains to the aws-iso-b partition. label Feb 23, 2022
@YakDriver YakDriver merged commit 0619e62 into main Feb 23, 2022
@YakDriver YakDriver deleted the b-iso-ecs-include branch February 23, 2022 19:29
github-actions bot pushed a commit that referenced this pull request Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-iso-b Pertains to the aws-iso-b partition. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecs/cluster: InvalidParameterException describing cluster in ISO regions
1 participant