-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imagebuilder/image_pipeline: Add schedule.timezone
parameter
#23322
imagebuilder/image_pipeline: Add schedule.timezone
parameter
#23322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccImageBuilderImagePipeline_ PKG=imagebuilder ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 3 -run='TestAccImageBuilderImagePipeline_' -timeout 180m
=== RUN TestAccImageBuilderImagePipeline_basic
=== PAUSE TestAccImageBuilderImagePipeline_basic
=== RUN TestAccImageBuilderImagePipeline_disappears
=== PAUSE TestAccImageBuilderImagePipeline_disappears
=== RUN TestAccImageBuilderImagePipeline_description
=== PAUSE TestAccImageBuilderImagePipeline_description
=== RUN TestAccImageBuilderImagePipeline_distributionARN
=== PAUSE TestAccImageBuilderImagePipeline_distributionARN
=== RUN TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== RUN TestAccImageBuilderImagePipeline_imageRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_imageRecipeARN
=== RUN TestAccImageBuilderImagePipeline_containerRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_containerRecipeARN
=== RUN TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== RUN TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== RUN TestAccImageBuilderImagePipeline_infrastructureARN
=== PAUSE TestAccImageBuilderImagePipeline_infrastructureARN
=== RUN TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== RUN TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== RUN TestAccImageBuilderImagePipeline_Schedule_timezone
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_timezone
=== RUN TestAccImageBuilderImagePipeline_status
=== PAUSE TestAccImageBuilderImagePipeline_status
=== RUN TestAccImageBuilderImagePipeline_tags
=== PAUSE TestAccImageBuilderImagePipeline_tags
=== CONT TestAccImageBuilderImagePipeline_basic
=== CONT TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== CONT TestAccImageBuilderImagePipeline_Schedule_timezone
--- PASS: TestAccImageBuilderImagePipeline_basic (33.10s)
=== CONT TestAccImageBuilderImagePipeline_tags
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes (48.36s)
=== CONT TestAccImageBuilderImagePipeline_status
--- PASS: TestAccImageBuilderImagePipeline_Schedule_timezone (48.50s)
=== CONT TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
--- PASS: TestAccImageBuilderImagePipeline_tags (60.74s)
=== CONT TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
--- PASS: TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled (52.90s)
=== CONT TestAccImageBuilderImagePipeline_containerRecipeARN
--- PASS: TestAccImageBuilderImagePipeline_status (73.16s)
=== CONT TestAccImageBuilderImagePipeline_imageRecipeARN
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled (57.33s)
=== CONT TestAccImageBuilderImagePipeline_description
--- PASS: TestAccImageBuilderImagePipeline_containerRecipeARN (73.80s)
=== CONT TestAccImageBuilderImagePipeline_distributionARN
--- PASS: TestAccImageBuilderImagePipeline_description (50.12s)
=== CONT TestAccImageBuilderImagePipeline_disappears
--- PASS: TestAccImageBuilderImagePipeline_disappears (41.03s)
=== CONT TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
--- PASS: TestAccImageBuilderImagePipeline_imageRecipeARN (120.88s)
=== CONT TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
--- PASS: TestAccImageBuilderImagePipeline_distributionARN (88.38s)
=== CONT TestAccImageBuilderImagePipeline_infrastructureARN
--- PASS: TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition (48.85s)
--- PASS: TestAccImageBuilderImagePipeline_Schedule_scheduleExpression (60.59s)
--- PASS: TestAccImageBuilderImagePipeline_infrastructureARN (51.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder 318.662s
@mattburgess Thanks for the contribution 🎉 👏. |
@mattburgess - Thanks for handling this one! I appreciate it. 🎉 |
This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23238
Output from acceptance testing: