Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Add sts_region #23212

Merged
merged 7 commits into from
Feb 15, 2022
Merged

provider: Add sts_region #23212

merged 7 commits into from
Feb 15, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 15, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

% make testacc TESTARGS="-run TestAccProvider" PKG_NAME="internal/acctest"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/acctest/... -v -count 1 -parallel 20  -run TestAccProvider -timeout 180m
--- PASS: TestAccProvider_Region_awsSC2S (28.88s)
--- PASS: TestAccProvider_Region_stsRegion (29.69s)
--- PASS: TestAccProvider_Region_awsCommercial (31.08s)
--- PASS: TestAccProvider_Region_awsChina (31.22s)
--- PASS: TestAccProvider_Region_awsC2S (31.98s)
--- PASS: TestAccProvider_Region_awsGovCloudUs (31.99s)
--- PASS: TestAccProvider_DefaultTagsTags_one (38.09s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_one (38.54s)
--- PASS: TestAccProvider_IgnoreTagsKeys_none (38.55s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_none (38.56s)
--- PASS: TestAccProvider_DefaultAndIgnoreTags_emptyBlocks (39.05s)
--- PASS: TestAccProvider_IgnoreTagsKeys_one (39.49s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_multiple (39.49s)
--- PASS: TestAccProvider_DefaultTagsTags_multiple (39.75s)
--- PASS: TestAccProvider_DefaultTags_emptyBlock (39.85s)
--- PASS: TestAccProvider_IgnoreTags_emptyBlock (39.94s)
--- PASS: TestAccProvider_IgnoreTagsKeys_multiple (40.22s)
--- PASS: TestAccProvider_endpoints (41.17s)
--- PASS: TestAccProvider_AssumeRole_empty (43.23s)
--- PASS: TestAccProvider_DefaultTagsTags_none (18.03s)
--- PASS: TestAccProvider_unusualEndpoints (18.84s)
--- PASS: TestAccProvider_fipsEndpoint (49.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	51.785s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 15, 2022
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. sts_region should also be documented in the v4 upgrade guide

@YakDriver YakDriver merged commit bcbab5c into main Feb 15, 2022
@YakDriver YakDriver deleted the f-add-sts-region branch February 15, 2022 21:34
github-actions bot pushed a commit that referenced this pull request Feb 15, 2022
@YakDriver YakDriver added this to the v4.2.0 milestone Feb 17, 2022
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants