-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_launch_configuration: add no_device option #23152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ColtonHerrod 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
ephemeral block device
21c76c5
to
1c56d44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAutoScalingLaunchConfiguration_ PKG=autoscaling ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 5 -run='TestAccAutoScalingLaunchConfiguration_' -timeout 180m
=== RUN TestAccAutoScalingLaunchConfiguration_basic
=== PAUSE TestAccAutoScalingLaunchConfiguration_basic
=== RUN TestAccAutoScalingLaunchConfiguration_Name_generated
=== PAUSE TestAccAutoScalingLaunchConfiguration_Name_generated
=== RUN TestAccAutoScalingLaunchConfiguration_namePrefix
=== PAUSE TestAccAutoScalingLaunchConfiguration_namePrefix
=== RUN TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== RUN TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== PAUSE TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== RUN TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== RUN TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== RUN TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== RUN TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== RUN TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== PAUSE TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== RUN TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== RUN TestAccAutoScalingLaunchConfiguration_withEncryption
=== PAUSE TestAccAutoScalingLaunchConfiguration_withEncryption
=== RUN TestAccAutoScalingLaunchConfiguration_withGP3
=== PAUSE TestAccAutoScalingLaunchConfiguration_withGP3
=== RUN TestAccAutoScalingLaunchConfiguration_updateEBSBlockDevices
=== PAUSE TestAccAutoScalingLaunchConfiguration_updateEBSBlockDevices
=== RUN TestAccAutoScalingLaunchConfiguration_metadataOptions
=== PAUSE TestAccAutoScalingLaunchConfiguration_metadataOptions
=== RUN TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== RUN TestAccAutoScalingLaunchConfiguration_userData
=== PAUSE TestAccAutoScalingLaunchConfiguration_userData
=== CONT TestAccAutoScalingLaunchConfiguration_basic
=== CONT TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== CONT TestAccAutoScalingLaunchConfiguration_updateEBSBlockDevices
=== CONT TestAccAutoScalingLaunchConfiguration_userData
=== CONT TestAccAutoScalingLaunchConfiguration_EBS_noDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (47.75s)
=== CONT TestAccAutoScalingLaunchConfiguration_metadataOptions
--- PASS: TestAccAutoScalingLaunchConfiguration_EBS_noDevice (47.77s)
=== CONT TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
--- PASS: TestAccAutoScalingLaunchConfiguration_withVPCClassicLink (56.02s)
=== CONT TestAccAutoScalingLaunchConfiguration_withSpotPrice
--- PASS: TestAccAutoScalingLaunchConfiguration_userData (78.96s)
=== CONT TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_metadataOptions (37.73s)
=== CONT TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
--- PASS: TestAccAutoScalingLaunchConfiguration_updateEBSBlockDevices (86.92s)
=== CONT TestAccAutoScalingLaunchConfiguration_withBlockDevices
--- PASS: TestAccAutoScalingLaunchConfiguration_withSpotPrice (38.30s)
=== CONT TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
--- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (42.62s)
=== CONT TestAccAutoScalingLaunchConfiguration_namePrefix
--- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (40.65s)
=== CONT TestAccAutoScalingLaunchConfiguration_Name_generated
--- PASS: TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI (39.06s)
=== CONT TestAccAutoScalingLaunchConfiguration_withEncryption
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize (75.16s)
=== CONT TestAccAutoScalingLaunchConfiguration_withGP3
--- PASS: TestAccAutoScalingLaunchConfiguration_namePrefix (40.26s)
=== CONT TestAccAutoScalingLaunchConfiguration_withIAMProfile
--- PASS: TestAccAutoScalingLaunchConfiguration_Name_generated (39.74s)
--- PASS: TestAccAutoScalingLaunchConfiguration_withEncryption (42.01s)
--- PASS: TestAccAutoScalingLaunchConfiguration_withGP3 (37.58s)
--- PASS: TestAccAutoScalingLaunchConfiguration_withIAMProfile (55.84s)
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (401.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 452.962s
@ColtonHerrod Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adding a no_device option to ephemeral block devices in a launch configuration resource. This addresses issue 5464.
Community Note
Closes #5464
Output from acceptance testing: