Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_cors_configuration: add retry around Get method during read #22977

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 6, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22976

Output from acceptance testing:

--- PASS: TestAccS3BucketCorsConfiguration_MultipleRules (33.28s)
--- PASS: TestAccS3BucketCorsConfiguration_basic (33.35s)
--- PASS: TestAccS3BucketCorsConfiguration_SingleRule (33.81s)
--- PASS: TestAccS3BucketCorsConfiguration_update (81.59s)
--- PASS: TestAccS3BucketCorsConfiguration_disappears (149.95s)

@anGie44 anGie44 added this to the v4.0.0 milestone Feb 6, 2022
@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR. labels Feb 6, 2022
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 6, 2022
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 6, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccS3BucketCorsConfiguration_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketCorsConfiguration_'  -timeout 180m
=== RUN   TestAccS3BucketCorsConfiguration_basic
=== PAUSE TestAccS3BucketCorsConfiguration_basic
=== RUN   TestAccS3BucketCorsConfiguration_disappears
=== PAUSE TestAccS3BucketCorsConfiguration_disappears
=== RUN   TestAccS3BucketCorsConfiguration_update
=== PAUSE TestAccS3BucketCorsConfiguration_update
=== RUN   TestAccS3BucketCorsConfiguration_SingleRule
=== PAUSE TestAccS3BucketCorsConfiguration_SingleRule
=== RUN   TestAccS3BucketCorsConfiguration_MultipleRules
=== PAUSE TestAccS3BucketCorsConfiguration_MultipleRules
=== CONT  TestAccS3BucketCorsConfiguration_basic
=== CONT  TestAccS3BucketCorsConfiguration_SingleRule
=== CONT  TestAccS3BucketCorsConfiguration_update
=== CONT  TestAccS3BucketCorsConfiguration_MultipleRules
=== CONT  TestAccS3BucketCorsConfiguration_disappears
--- PASS: TestAccS3BucketCorsConfiguration_basic (42.77s)
--- PASS: TestAccS3BucketCorsConfiguration_MultipleRules (42.77s)
--- PASS: TestAccS3BucketCorsConfiguration_SingleRule (42.80s)
--- PASS: TestAccS3BucketCorsConfiguration_update (100.32s)
--- PASS: TestAccS3BucketCorsConfiguration_disappears (156.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	165.144s

@anGie44 anGie44 merged commit 9e49415 into main Feb 7, 2022
@anGie44 anGie44 deleted the f-add-retry-in-get-bucket-cors branch February 7, 2022 17:14
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/s3_bucket_cors_configuration: TestAccS3BucketCorsConfiguration_* failing in TeamCity
2 participants