-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/glue_trigger - add event_batching_condition
#22963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccGlueTrigger_ PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueTrigger_' -timeout 180m
=== RUN TestAccGlueTrigger_basic
=== PAUSE TestAccGlueTrigger_basic
=== RUN TestAccGlueTrigger_crawler
=== PAUSE TestAccGlueTrigger_crawler
=== RUN TestAccGlueTrigger_description
=== PAUSE TestAccGlueTrigger_description
=== RUN TestAccGlueTrigger_enabled
=== PAUSE TestAccGlueTrigger_enabled
=== RUN TestAccGlueTrigger_predicate
=== PAUSE TestAccGlueTrigger_predicate
=== RUN TestAccGlueTrigger_schedule
=== PAUSE TestAccGlueTrigger_schedule
=== RUN TestAccGlueTrigger_startOnCreate
=== PAUSE TestAccGlueTrigger_startOnCreate
=== RUN TestAccGlueTrigger_tags
=== PAUSE TestAccGlueTrigger_tags
=== RUN TestAccGlueTrigger_workflowName
=== PAUSE TestAccGlueTrigger_workflowName
=== RUN TestAccGlueTrigger_Actions_notify
=== PAUSE TestAccGlueTrigger_Actions_notify
=== RUN TestAccGlueTrigger_Actions_security
=== PAUSE TestAccGlueTrigger_Actions_security
=== RUN TestAccGlueTrigger_onDemandDisable
=== PAUSE TestAccGlueTrigger_onDemandDisable
=== RUN TestAccGlueTrigger_eventBatchingCondition
=== PAUSE TestAccGlueTrigger_eventBatchingCondition
=== RUN TestAccGlueTrigger_disappears
=== PAUSE TestAccGlueTrigger_disappears
=== CONT TestAccGlueTrigger_basic
=== CONT TestAccGlueTrigger_tags
=== CONT TestAccGlueTrigger_Actions_security
=== CONT TestAccGlueTrigger_onDemandDisable
=== CONT TestAccGlueTrigger_crawler
=== CONT TestAccGlueTrigger_Actions_notify
=== CONT TestAccGlueTrigger_workflowName
=== CONT TestAccGlueTrigger_predicate
=== CONT TestAccGlueTrigger_startOnCreate
=== CONT TestAccGlueTrigger_disappears
=== CONT TestAccGlueTrigger_enabled
=== CONT TestAccGlueTrigger_schedule
=== CONT TestAccGlueTrigger_description
=== CONT TestAccGlueTrigger_eventBatchingCondition
--- PASS: TestAccGlueTrigger_disappears (73.24s)
--- PASS: TestAccGlueTrigger_basic (75.61s)
--- PASS: TestAccGlueTrigger_Actions_security (80.75s)
--- PASS: TestAccGlueTrigger_description (113.17s)
--- PASS: TestAccGlueTrigger_eventBatchingCondition (119.44s)
--- PASS: TestAccGlueTrigger_onDemandDisable (128.45s)
--- PASS: TestAccGlueTrigger_crawler (136.95s)
--- PASS: TestAccGlueTrigger_schedule (139.46s)
--- PASS: TestAccGlueTrigger_tags (160.63s)
--- PASS: TestAccGlueTrigger_workflowName (163.02s)
--- PASS: TestAccGlueTrigger_enabled (174.32s)
--- PASS: TestAccGlueTrigger_startOnCreate (177.93s)
--- PASS: TestAccGlueTrigger_predicate (183.43s)
--- PASS: TestAccGlueTrigger_Actions_notify (624.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 630.825s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: