-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_vpc_ipam* docs and modifyIpam fixes #22863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccVPCIpam_ PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCIpam_' -timeout 180m
=== RUN TestAccVPCIpam_ByoipIPv6
vpc_byoip_test.go:21: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccVPCIpam_ByoipIPv6 (0.00s)
=== RUN TestAccVPCIpam_basic
=== PAUSE TestAccVPCIpam_basic
=== RUN TestAccVPCIpam_modify
=== PAUSE TestAccVPCIpam_modify
=== RUN TestAccVPCIpam_tags
=== PAUSE TestAccVPCIpam_tags
=== CONT TestAccVPCIpam_basic
=== CONT TestAccVPCIpam_tags
=== CONT TestAccVPCIpam_modify
--- PASS: TestAccVPCIpam_basic (32.39s)
--- PASS: TestAccVPCIpam_tags (50.61s)
--- PASS: TestAccVPCIpam_modify (61.58s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 65.517s
@drewmullen Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes:
Output from acceptance testing: