Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_vpc_ipam* docs and modifyIpam fixes #22863

Merged
merged 5 commits into from
Feb 1, 2022

Conversation

drewmullen
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes:

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccVPCIpam_" PKG_NAME="./internal/service/ec2" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCIpam_ -timeout 180m
=== RUN   TestAccVPCIpam_ByoipIPv6
    vpc_byoip_test.go:21: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccVPCIpam_ByoipIPv6 (0.00s)
=== RUN   TestAccVPCIpam_basic
=== PAUSE TestAccVPCIpam_basic
=== RUN   TestAccVPCIpam_modify
=== PAUSE TestAccVPCIpam_modify
=== RUN   TestAccVPCIpam_tags
=== PAUSE TestAccVPCIpam_tags
=== CONT  TestAccVPCIpam_basic
=== CONT  TestAccVPCIpam_tags
=== CONT  TestAccVPCIpam_modify
--- PASS: TestAccVPCIpam_basic (37.91s)
--- PASS: TestAccVPCIpam_tags (62.90s)
--- PASS: TestAccVPCIpam_modify (76.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        80.256s

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Feb 1, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 1, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Feb 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccVPCIpam_ PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCIpam_'  -timeout 180m
=== RUN   TestAccVPCIpam_ByoipIPv6
    vpc_byoip_test.go:21: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccVPCIpam_ByoipIPv6 (0.00s)
=== RUN   TestAccVPCIpam_basic
=== PAUSE TestAccVPCIpam_basic
=== RUN   TestAccVPCIpam_modify
=== PAUSE TestAccVPCIpam_modify
=== RUN   TestAccVPCIpam_tags
=== PAUSE TestAccVPCIpam_tags
=== CONT  TestAccVPCIpam_basic
=== CONT  TestAccVPCIpam_tags
=== CONT  TestAccVPCIpam_modify
--- PASS: TestAccVPCIpam_basic (32.39s)
--- PASS: TestAccVPCIpam_tags (50.61s)
--- PASS: TestAccVPCIpam_modify (61.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	65.517s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9bfc2e2 into hashicorp:main Feb 1, 2022
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 1, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants