Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_connect_queue #22768

Merged
merged 10 commits into from
Mar 3, 2022
Merged

d/aws_connect_queue #22768

merged 10 commits into from
Mar 3, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Jan 26, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21021

Depends on #22821 for a function that can read the quick_connect_ids

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectQueueDataSource PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueueDataSource'  -timeout 180m
=== RUN   TestAccConnectQueueDataSource_queueID
--- PASS: TestAccConnectQueueDataSource_queueID (133.15s)
=== RUN   TestAccConnectQueueDataSource_name
--- PASS: TestAccConnectQueueDataSource_name (133.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    275.081s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 26, 2022
@GlennChia GlennChia marked this pull request as draft January 28, 2022 15:47
AdamTylerLynch
AdamTylerLynch approved these changes Feb 4, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GlennChia GlennChia marked this pull request as ready for review February 5, 2022 00:03
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 16, 2022
@njsnx
Copy link

njsnx commented Mar 3, 2022

When is this likely to be approved/released (along with other Connect resources)

ewbankkit
ewbankkit approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccConnectQueueDataSource_ PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueueDataSource_'  -timeout 180m
=== RUN   TestAccConnectQueueDataSource_queueID
--- PASS: TestAccConnectQueueDataSource_queueID (95.87s)
=== RUN   TestAccConnectQueueDataSource_name
--- PASS: TestAccConnectQueueDataSource_name (93.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	194.910s

@ewbankkit
Copy link
Contributor

@xxx Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7a7f702 into hashicorp:main Mar 3, 2022
@github-actions github-actions bot added this to the v4.4.0 milestone Mar 3, 2022
@GlennChia GlennChia deleted the f-aws_connect_queue branch March 3, 2022 16:28
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

@YakDriver YakDriver Awaiting requested review from YakDriver

@gdavison gdavison Awaiting requested review from gdavison

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.4.0
Development

Successfully merging this pull request may close these issues.

Add new resource/data_source for aws_connect_queue
5 participants
@GlennChia @njsnx @ewbankkit @AdamTylerLynch @justinretzolk