Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transit Gateway multicast support #11120 #22756

Merged
merged 62 commits into from
Feb 23, 2022
Merged

Transit Gateway multicast support #11120 #22756

merged 62 commits into from
Feb 23, 2022

Conversation

NetDevAutomate
Copy link
Contributor

@NetDevAutomate NetDevAutomate commented Jan 25, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

PR to add multicast support to Transit Gateway.
Closes #11120.
Closes #16716.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jan 25, 2022
@NetDevAutomate NetDevAutomate mentioned this pull request Jan 25, 2022
Closed
2 tasks
@NetDevAutomate
Copy link
Contributor Author

Continued work from PR #11120

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 25, 2022
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) and removed sweeper Pertains to changes to or issues with the sweeper. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Feb 23, 2022
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed sweeper Pertains to changes to or issues with the sweeper. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Feb 23, 2022
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) and removed sweeper Pertains to changes to or issues with the sweeper. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Feb 23, 2022
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Feb 23, 2022
@ewbankkit ewbankkit removed their assignment Feb 23, 2022
@ewbankkit
Copy link
Contributor

@NetDevAutomate @AdamTylerLynch @drewmullen For a follow up should we add a aws_ec2_transit_gateway_multicast_domain_association_accepter resource for those domains where auto_accept_shared_associations = "disable"?

ewbankkit
ewbankkit approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccEC2TransitGatewayDataSource_serial/Gateway/Filter PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGatewayDataSource_serial/Gateway/Filter'  -timeout 180m
=== RUN   TestAccEC2TransitGatewayDataSource_serial
=== RUN   TestAccEC2TransitGatewayDataSource_serial/DxGatewayAttachment
=== RUN   TestAccEC2TransitGatewayDataSource_serial/DxGatewayAttachment/Filter
=== RUN   TestAccEC2TransitGatewayDataSource_serial/Gateway
=== RUN   TestAccEC2TransitGatewayDataSource_serial/Gateway/Filter
--- PASS: TestAccEC2TransitGatewayDataSource_serial (1648.95s)
    --- PASS: TestAccEC2TransitGatewayDataSource_serial/DxGatewayAttachment (1413.49s)
        --- PASS: TestAccEC2TransitGatewayDataSource_serial/DxGatewayAttachment/Filter (1413.49s)
    --- PASS: TestAccEC2TransitGatewayDataSource_serial/Gateway (235.46s)
        --- PASS: TestAccEC2TransitGatewayDataSource_serial/Gateway/Filter (235.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1652.703s
% make testacc TESTS=TestAccEC2TransitGatewayDataSource_serial/MulticastDomain PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGatewayDataSource_serial/MulticastDomain'  -timeout 180m
=== RUN   TestAccEC2TransitGatewayDataSource_serial
=== RUN   TestAccEC2TransitGatewayDataSource_serial/MulticastDomain
=== RUN   TestAccEC2TransitGatewayDataSource_serial/MulticastDomain/Filter
=== RUN   TestAccEC2TransitGatewayDataSource_serial/MulticastDomain/ID
--- PASS: TestAccEC2TransitGatewayDataSource_serial (859.82s)
    --- PASS: TestAccEC2TransitGatewayDataSource_serial/MulticastDomain (859.81s)
        --- PASS: TestAccEC2TransitGatewayDataSource_serial/MulticastDomain/Filter (378.79s)
        --- PASS: TestAccEC2TransitGatewayDataSource_serial/MulticastDomain/ID (481.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	863.406s
% make testacc TESTS=TestAccEC2TransitGateway_serial/Gateway/basic PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGateway_serial/Gateway/basic'  -timeout 180m
=== RUN   TestAccEC2TransitGateway_serial
=== RUN   TestAccEC2TransitGateway_serial/Gateway
=== RUN   TestAccEC2TransitGateway_serial/Gateway/basic
--- PASS: TestAccEC2TransitGateway_serial (216.96s)
    --- PASS: TestAccEC2TransitGateway_serial/Gateway (216.96s)
        --- PASS: TestAccEC2TransitGateway_serial/Gateway/basic (216.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	220.887s
% make testacc TESTS=TestAccEC2TransitGateway_serial/MulticastDomain PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGateway_serial/MulticastDomain'  -timeout 180m
=== RUN   TestAccEC2TransitGateway_serial
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomainAssociation
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomainAssociation/basic
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomainAssociation/disappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomainAssociation/DomainDisappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomainAssociation/TwoAssociations
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomain
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomain/basic
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomain/disappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomain/tags
=== RUN   TestAccEC2TransitGateway_serial/MulticastDomain/IGMPv2Support
--- PASS: TestAccEC2TransitGateway_serial (3435.81s)
    --- PASS: TestAccEC2TransitGateway_serial/MulticastDomainAssociation (2004.23s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastDomainAssociation/basic (482.98s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastDomainAssociation/disappears (503.32s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastDomainAssociation/DomainDisappears (536.22s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastDomainAssociation/TwoAssociations (481.72s)
    --- PASS: TestAccEC2TransitGateway_serial/MulticastDomain (1431.57s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastDomain/basic (336.97s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastDomain/disappears (317.72s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastDomain/tags (359.24s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastDomain/IGMPv2Support (417.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	3439.360s
% make testacc TESTS=TestAccEC2TransitGateway_serial/MulticastGroup PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGateway_serial/MulticastGroup'  -timeout 180m
=== RUN   TestAccEC2TransitGateway_serial
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember/basic
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember/disappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember/DomainDisappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember/TwoMembers
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupSource
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupSource/disappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupSource/DomainDisappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupSource/basic
--- PASS: TestAccEC2TransitGateway_serial (3481.58s)
    --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember (2000.02s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember/basic (437.51s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember/disappears (486.55s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember/DomainDisappears (594.82s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember/TwoMembers (481.14s)
    --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupSource (1481.56s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupSource/disappears (415.15s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupSource/DomainDisappears (585.59s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupSource/basic (480.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	3485.016s
GovCloud
% make testacc TESTS=TestAccEC2TransitGateway_serial/MulticastGroup PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGateway_serial/MulticastGroup'  -timeout 180m
=== RUN   TestAccEC2TransitGateway_serial
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupSource
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupSource/DomainDisappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupSource/basic
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupSource/disappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember/disappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember/DomainDisappears
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember/TwoMembers
=== RUN   TestAccEC2TransitGateway_serial/MulticastGroupMember/basic
--- PASS: TestAccEC2TransitGateway_serial (3184.62s)
    --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupSource (1308.87s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupSource/DomainDisappears (485.34s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupSource/basic (399.84s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupSource/disappears (423.68s)
    --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember (1875.75s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember/disappears (414.07s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember/DomainDisappears (486.08s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember/TwoMembers (414.21s)
        --- PASS: TestAccEC2TransitGateway_serial/MulticastGroupMember/basic (561.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	3188.323s

@ewbankkit
Copy link
Contributor

@NetDevAutomate Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a31f7bb into hashicorp:main Feb 23, 2022
@github-actions github-actions bot modified the milestones: Roadmap, v4.3.0 Feb 23, 2022
@NetDevAutomate
Copy link
Contributor Author

@NetDevAutomate Thanks for the contribution 🎉 👏.

@ewbankkit Thank you so much for your support, it really is greatly appreciated.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewmullen drewmullen drewmullen left review comments

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.

Transit Gateway IGMP support for multicast Transit Gateway multicast support
5 participants
@NetDevAutomate @ewbankkit @drewmullen @AdamTylerLynch @justinretzolk