r/internet_gateway: Prevent giving up on wait for attachement too early #22713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ialidzhikov <[email protected]>
github-actions
bot
added
needs-triage
Signed-off-by: ialidzhikov <[email protected]>
ewbankkit
removed
the
needs-triage
ewbankkit
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTS=TestAccEC2InternetGateway_Attachment PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InternetGateway_Attachment' -timeout 180m
=== RUN TestAccEC2InternetGateway_Attachment
=== PAUSE TestAccEC2InternetGateway_Attachment
=== CONT TestAccEC2InternetGateway_Attachment
--- PASS: TestAccEC2InternetGateway_Attachment (53.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 61.768s
|
@ialidzhikov Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ialidzhikov [email protected]
Community Note
Closes #22711
Output from acceptance testing: