Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventbridge: ISO-friendly tagging #22550

Merged
merged 3 commits into from
Jan 12, 2022
Merged

eventbridge: ISO-friendly tagging #22550

merged 3 commits into from
Jan 12, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18593
Relates #22532

Output from acceptance testing (us-west-2):

% make testacc TESTS=TestAccEventsRule_ PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsRule_'  -timeout 180m
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
--- PASS: TestAccEventsRule_scheduleAndPattern (30.65s)
--- PASS: TestAccEventsRule_namePrefix (30.74s)
--- PASS: TestAccEventsRule_Name_generated (30.78s)
--- PASS: TestAccEventsRule_eventBusARN (31.10s)
--- PASS: TestAccEventsRule_role (39.75s)
--- PASS: TestAccEventsRule_description (45.46s)
--- PASS: TestAccEventsRule_pattern (46.28s)
--- PASS: TestAccEventsRule_basic (58.69s)
--- PASS: TestAccEventsRule_isEnabled (59.40s)
--- PASS: TestAccEventsRule_eventBusName (63.28s)
--- PASS: TestAccEventsRule_tags (71.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	72.731s
% make testacc TESTS=TestAccEventsBus_ PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_'  -timeout 180m
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
--- PASS: TestAccEventsBus_default (2.31s)
--- PASS: TestAccEventsBus_disappears (13.44s)
--- PASS: TestAccEventsBus_basic (42.18s)
--- PASS: TestAccEventsBus_tags (52.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	54.505s

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccEventsRule_ PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsRule_'  -timeout 180m
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
--- PASS: TestAccEventsRule_namePrefix (31.59s)
--- PASS: TestAccEventsRule_Name_generated (31.74s)
--- PASS: TestAccEventsRule_scheduleAndPattern (31.75s)
--- PASS: TestAccEventsRule_eventBusARN (32.35s)
--- PASS: TestAccEventsRule_role (39.47s)
--- PASS: TestAccEventsRule_description (51.54s)
--- PASS: TestAccEventsRule_pattern (51.69s)
--- PASS: TestAccEventsRule_isEnabled (71.67s)
--- PASS: TestAccEventsRule_basic (72.10s)
--- PASS: TestAccEventsRule_eventBusName (75.69s)
--- PASS: TestAccEventsRule_tags (86.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	88.872s
% make testacc TESTS=TestAccEventsBus_ PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_'  -timeout 180m
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
--- PASS: TestAccEventsBus_default (2.39s)
--- PASS: TestAccEventsBus_disappears (16.42s)
--- PASS: TestAccEventsBus_basic (52.93s)
--- PASS: TestAccEventsBus_tags (67.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	68.867s

@github-actions github-actions bot added service/events Issues and PRs that pertain to the events service. size/M Managed by automation to categorize the size of a PR. and removed service/events Issues and PRs that pertain to the events service. labels Jan 12, 2022
@github-actions github-actions bot added the service/events Issues and PRs that pertain to the events service. label Jan 12, 2022
@YakDriver YakDriver mentioned this pull request Jan 12, 2022
27 tasks
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEventsRule_\|TestAccEventsBus_' PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20  -run=TestAccEventsRule_\|TestAccEventsBus_ -timeout 180m
=== RUN   TestAccEventsBus_basic
=== PAUSE TestAccEventsBus_basic
=== RUN   TestAccEventsBus_tags
=== PAUSE TestAccEventsBus_tags
=== RUN   TestAccEventsBus_default
=== PAUSE TestAccEventsBus_default
=== RUN   TestAccEventsBus_disappears
=== PAUSE TestAccEventsBus_disappears
=== RUN   TestAccEventsBus_partnerEventSource
    bus_test.go:170: Environment variable EVENT_BRIDGE_PARTNER_EVENT_SOURCE_NAME is not set
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
=== RUN   TestAccEventsRule_basic
=== PAUSE TestAccEventsRule_basic
=== RUN   TestAccEventsRule_eventBusName
=== PAUSE TestAccEventsRule_eventBusName
=== RUN   TestAccEventsRule_role
=== PAUSE TestAccEventsRule_role
=== RUN   TestAccEventsRule_description
=== PAUSE TestAccEventsRule_description
=== RUN   TestAccEventsRule_pattern
=== PAUSE TestAccEventsRule_pattern
=== RUN   TestAccEventsRule_scheduleAndPattern
=== PAUSE TestAccEventsRule_scheduleAndPattern
=== RUN   TestAccEventsRule_namePrefix
=== PAUSE TestAccEventsRule_namePrefix
=== RUN   TestAccEventsRule_Name_generated
=== PAUSE TestAccEventsRule_Name_generated
=== RUN   TestAccEventsRule_tags
=== PAUSE TestAccEventsRule_tags
=== RUN   TestAccEventsRule_isEnabled
=== PAUSE TestAccEventsRule_isEnabled
=== RUN   TestAccEventsRule_partnerEventBus
    rule_test.go:440: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
=== RUN   TestAccEventsRule_eventBusARN
=== PAUSE TestAccEventsRule_eventBusARN
=== CONT  TestAccEventsBus_basic
=== CONT  TestAccEventsRule_pattern
=== CONT  TestAccEventsRule_eventBusName
=== CONT  TestAccEventsBus_tags
=== CONT  TestAccEventsRule_basic
=== CONT  TestAccEventsRule_description
=== CONT  TestAccEventsRule_role
=== CONT  TestAccEventsBus_default
=== CONT  TestAccEventsRule_eventBusARN
=== CONT  TestAccEventsRule_isEnabled
=== CONT  TestAccEventsRule_tags
=== CONT  TestAccEventsRule_Name_generated
=== CONT  TestAccEventsRule_namePrefix
=== CONT  TestAccEventsBus_disappears
=== CONT  TestAccEventsRule_scheduleAndPattern
--- PASS: TestAccEventsBus_default (5.14s)
--- PASS: TestAccEventsBus_disappears (38.06s)
--- PASS: TestAccEventsRule_namePrefix (54.78s)
--- PASS: TestAccEventsRule_scheduleAndPattern (55.33s)
--- PASS: TestAccEventsRule_eventBusARN (56.48s)
--- PASS: TestAccEventsRule_Name_generated (56.49s)
--- PASS: TestAccEventsRule_role (65.01s)
--- PASS: TestAccEventsRule_pattern (78.91s)
--- PASS: TestAccEventsRule_description (79.16s)
--- PASS: TestAccEventsBus_basic (95.91s)
--- PASS: TestAccEventsRule_isEnabled (96.90s)
--- PASS: TestAccEventsRule_basic (96.99s)
--- PASS: TestAccEventsRule_eventBusName (101.22s)
--- PASS: TestAccEventsBus_tags (111.00s)
--- PASS: TestAccEventsRule_tags (111.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	119.159s

@YakDriver YakDriver merged commit 81b8dd1 into main Jan 12, 2022
@YakDriver YakDriver deleted the f-iso-tagging-events branch January 12, 2022 21:05
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 12, 2022
github-actions bot pushed a commit that referenced this pull request Jan 12, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/events Issues and PRs that pertain to the events service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants