Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_memorydb_snapshot #22486

Merged
merged 2 commits into from
Jan 9, 2022
Merged

New Resource: aws_memorydb_snapshot #22486

merged 2 commits into from
Jan 9, 2022

Conversation

roberth-k
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20631

Output from acceptance testing:

$ make testacc PKG=memorydb TESTS=TestAccMemoryDBSnapshot_ ACCTEST_PARALLELISM=3 ACCTEST_TIMEOUT=600m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 3 -run='TestAccMemoryDBSnapshot_' -timeout 600m
=== RUN   TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== RUN   TestAccMemoryDBSnapshot_disappears
=== PAUSE TestAccMemoryDBSnapshot_disappears
=== RUN   TestAccMemoryDBSnapshot_nameGenerated
=== PAUSE TestAccMemoryDBSnapshot_nameGenerated
=== RUN   TestAccMemoryDBSnapshot_namePrefix
=== PAUSE TestAccMemoryDBSnapshot_namePrefix
=== RUN   TestAccMemoryDBSnapshot_create_withKMS
=== PAUSE TestAccMemoryDBSnapshot_create_withKMS
=== RUN   TestAccMemoryDBSnapshot_update_tags
=== PAUSE TestAccMemoryDBSnapshot_update_tags
=== CONT  TestAccMemoryDBSnapshot_basic
=== CONT  TestAccMemoryDBSnapshot_namePrefix
=== CONT  TestAccMemoryDBSnapshot_update_tags
--- PASS: TestAccMemoryDBSnapshot_namePrefix (2116.01s)
=== CONT  TestAccMemoryDBSnapshot_nameGenerated
--- PASS: TestAccMemoryDBSnapshot_basic (2117.61s)
=== CONT  TestAccMemoryDBSnapshot_create_withKMS
--- PASS: TestAccMemoryDBSnapshot_update_tags (2219.01s)
=== CONT  TestAccMemoryDBSnapshot_disappears
--- PASS: TestAccMemoryDBSnapshot_nameGenerated (2167.53s)
--- PASS: TestAccMemoryDBSnapshot_create_withKMS (2208.95s)
--- PASS: TestAccMemoryDBSnapshot_disappears (2230.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   4450.952s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. labels Jan 8, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 8, 2022
@roberth-k roberth-k mentioned this pull request Jan 9, 2022
Merged
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 9, 2022
ewbankkit
ewbankkit approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG=memorydb TESTS=TestAccMemoryDBSnapshot_ ACCTEST_PARALLELISM=3 ACCTEST_TIMEOUT=600m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 3 -run='TestAccMemoryDBSnapshot_' -timeout 600m
=== RUN   TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== RUN   TestAccMemoryDBSnapshot_disappears
=== PAUSE TestAccMemoryDBSnapshot_disappears
=== RUN   TestAccMemoryDBSnapshot_nameGenerated
=== PAUSE TestAccMemoryDBSnapshot_nameGenerated
=== RUN   TestAccMemoryDBSnapshot_namePrefix
=== PAUSE TestAccMemoryDBSnapshot_namePrefix
=== RUN   TestAccMemoryDBSnapshot_create_withKMS
=== PAUSE TestAccMemoryDBSnapshot_create_withKMS
=== RUN   TestAccMemoryDBSnapshot_update_tags
=== PAUSE TestAccMemoryDBSnapshot_update_tags
=== CONT  TestAccMemoryDBSnapshot_basic
=== CONT  TestAccMemoryDBSnapshot_namePrefix
=== CONT  TestAccMemoryDBSnapshot_nameGenerated
--- PASS: TestAccMemoryDBSnapshot_namePrefix (2113.74s)
=== CONT  TestAccMemoryDBSnapshot_disappears
--- PASS: TestAccMemoryDBSnapshot_basic (2136.02s)
=== CONT  TestAccMemoryDBSnapshot_update_tags
--- PASS: TestAccMemoryDBSnapshot_nameGenerated (2155.22s)
=== CONT  TestAccMemoryDBSnapshot_create_withKMS
--- PASS: TestAccMemoryDBSnapshot_disappears (2171.08s)
--- PASS: TestAccMemoryDBSnapshot_create_withKMS (2145.63s)
--- PASS: TestAccMemoryDBSnapshot_update_tags (2263.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	4403.248s
GovCloud
% make testacc PKG=memorydb TESTS=TestAccMemoryDBSnapshot_ ACCTEST_PARALLELISM=3 ACCTEST_TIMEOUT=600m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 3 -run='TestAccMemoryDBSnapshot_' -timeout 600m
=== RUN   TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== RUN   TestAccMemoryDBSnapshot_disappears
=== PAUSE TestAccMemoryDBSnapshot_disappears
=== RUN   TestAccMemoryDBSnapshot_nameGenerated
=== PAUSE TestAccMemoryDBSnapshot_nameGenerated
=== RUN   TestAccMemoryDBSnapshot_namePrefix
=== PAUSE TestAccMemoryDBSnapshot_namePrefix
=== RUN   TestAccMemoryDBSnapshot_create_withKMS
=== PAUSE TestAccMemoryDBSnapshot_create_withKMS
=== RUN   TestAccMemoryDBSnapshot_update_tags
=== PAUSE TestAccMemoryDBSnapshot_update_tags
=== CONT  TestAccMemoryDBSnapshot_basic
=== CONT  TestAccMemoryDBSnapshot_create_withKMS
=== CONT  TestAccMemoryDBSnapshot_update_tags
=== CONT  TestAccMemoryDBSnapshot_basic
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBSnapshot_create_withKMS
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBSnapshot_basic (1.57s)
--- SKIP: TestAccMemoryDBSnapshot_create_withKMS (1.57s)
=== CONT  TestAccMemoryDBSnapshot_nameGenerated
=== CONT  TestAccMemoryDBSnapshot_namePrefix
=== CONT  TestAccMemoryDBSnapshot_update_tags
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBSnapshot_namePrefix
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBSnapshot_update_tags (1.58s)
=== CONT  TestAccMemoryDBSnapshot_disappears
--- SKIP: TestAccMemoryDBSnapshot_namePrefix (0.00s)
=== CONT  TestAccMemoryDBSnapshot_disappears
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBSnapshot_disappears (0.00s)
=== CONT  TestAccMemoryDBSnapshot_nameGenerated
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBSnapshot_nameGenerated (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	5.094s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3560bd8 into hashicorp:main Jan 9, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 9, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@roberth-k roberth-k deleted the f-aws_memorydb_snapshot branch January 16, 2022 20:23
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.
2 participants
@roberth-k @ewbankkit