Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_eks_cluster: Add ip_family argument #22485

Merged
merged 5 commits into from
Jan 10, 2022

Conversation

mKeRix
Copy link
Contributor

@mKeRix mKeRix commented Jan 8, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22407

Output from acceptance testing:

$ make testacc TESTS=TestAccEKSCluster_Network_ipFamily PKG=eks

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_Network_ipFamily'  -timeout 180m
=== RUN   TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== CONT  TestAccEKSCluster_Network_ipFamily
--- PASS: TestAccEKSCluster_Network_ipFamily (1469.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1473.522s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 8, 2022
@mKeRix mKeRix marked this pull request as ready for review January 8, 2022 12:16
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mKeRix 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Tabs were the culprit...
@mKeRix
Copy link
Contributor Author

mKeRix commented Jan 8, 2022

Apologies for the terrafmt fail - looks like my IDE was misconfigured and put in tabs instead of spaces.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSClusterDataSource_\|TestAccEKSCluster_' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSClusterDataSource_\|TestAccEKSCluster_ -timeout 180m
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_disappears
=== PAUSE TestAccEKSCluster_disappears
=== RUN   TestAccEKSCluster_Encryption_create
=== PAUSE TestAccEKSCluster_Encryption_create
=== RUN   TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== RUN   TestAccEKSCluster_Encryption_versionUpdate
=== PAUSE TestAccEKSCluster_Encryption_versionUpdate
=== RUN   TestAccEKSCluster_version
=== PAUSE TestAccEKSCluster_version
=== RUN   TestAccEKSCluster_logging
=== PAUSE TestAccEKSCluster_logging
=== RUN   TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN   TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN   TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN   TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN   TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== RUN   TestAccEKSCluster_Network_serviceIPv4CIDR
=== PAUSE TestAccEKSCluster_Network_serviceIPv4CIDR
=== RUN   TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== CONT  TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSCluster_tags
=== CONT  TestAccEKSCluster_VPC_publicAccessCIDRs
=== CONT  TestAccEKSCluster_logging
=== CONT  TestAccEKSCluster_Network_serviceIPv4CIDR
=== CONT  TestAccEKSCluster_Network_ipFamily
=== CONT  TestAccEKSCluster_basic
=== CONT  TestAccEKSCluster_VPC_securityGroupIDs
=== CONT  TestAccEKSCluster_disappears
=== CONT  TestAccEKSCluster_VPC_endpointPublicAccess
=== CONT  TestAccEKSCluster_version
=== CONT  TestAccEKSCluster_Encryption_create
=== CONT  TestAccEKSCluster_Encryption_versionUpdate
=== CONT  TestAccEKSCluster_VPC_endpointPrivateAccess
=== CONT  TestAccEKSCluster_Encryption_update
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (736.83s)
--- PASS: TestAccEKSCluster_basic (739.51s)
--- PASS: TestAccEKSCluster_disappears (781.59s)
--- PASS: TestAccEKSClusterDataSource_basic (842.62s)
--- PASS: TestAccEKSCluster_Encryption_create (849.00s)
--- PASS: TestAccEKSCluster_tags (881.16s)
--- PASS: TestAccEKSCluster_logging (1005.45s)
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (1318.84s)
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1625.26s)
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1640.25s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1736.00s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (2162.98s)
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (2802.85s)
--- PASS: TestAccEKSCluster_version (2907.74s)
--- PASS: TestAccEKSCluster_Encryption_update (3607.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	3611.277s

@ewbankkit
Copy link
Contributor

@mKeRix Thanks for the contribution 🎉 👏.

@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@mKeRix mKeRix deleted the f-aws_eks_cluster-ipfamily branch January 14, 2022 05:23
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS: add support to kubernetes_network_config for ipFamily
2 participants