-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_eks_cluster: Add ip_family argument #22485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @mKeRix 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Tabs were the culprit...
Apologies for the terrafmt fail - looks like my IDE was misconfigured and put in tabs instead of spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSClusterDataSource_\|TestAccEKSCluster_' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSClusterDataSource_\|TestAccEKSCluster_ -timeout 180m
=== RUN TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN TestAccEKSCluster_disappears
=== PAUSE TestAccEKSCluster_disappears
=== RUN TestAccEKSCluster_Encryption_create
=== PAUSE TestAccEKSCluster_Encryption_create
=== RUN TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== RUN TestAccEKSCluster_Encryption_versionUpdate
=== PAUSE TestAccEKSCluster_Encryption_versionUpdate
=== RUN TestAccEKSCluster_version
=== PAUSE TestAccEKSCluster_version
=== RUN TestAccEKSCluster_logging
=== PAUSE TestAccEKSCluster_logging
=== RUN TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== RUN TestAccEKSCluster_Network_serviceIPv4CIDR
=== PAUSE TestAccEKSCluster_Network_serviceIPv4CIDR
=== RUN TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== CONT TestAccEKSClusterDataSource_basic
=== CONT TestAccEKSCluster_tags
=== CONT TestAccEKSCluster_VPC_publicAccessCIDRs
=== CONT TestAccEKSCluster_logging
=== CONT TestAccEKSCluster_Network_serviceIPv4CIDR
=== CONT TestAccEKSCluster_Network_ipFamily
=== CONT TestAccEKSCluster_basic
=== CONT TestAccEKSCluster_VPC_securityGroupIDs
=== CONT TestAccEKSCluster_disappears
=== CONT TestAccEKSCluster_VPC_endpointPublicAccess
=== CONT TestAccEKSCluster_version
=== CONT TestAccEKSCluster_Encryption_create
=== CONT TestAccEKSCluster_Encryption_versionUpdate
=== CONT TestAccEKSCluster_VPC_endpointPrivateAccess
=== CONT TestAccEKSCluster_Encryption_update
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (736.83s)
--- PASS: TestAccEKSCluster_basic (739.51s)
--- PASS: TestAccEKSCluster_disappears (781.59s)
--- PASS: TestAccEKSClusterDataSource_basic (842.62s)
--- PASS: TestAccEKSCluster_Encryption_create (849.00s)
--- PASS: TestAccEKSCluster_tags (881.16s)
--- PASS: TestAccEKSCluster_logging (1005.45s)
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (1318.84s)
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1625.26s)
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1640.25s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1736.00s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (2162.98s)
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (2802.85s)
--- PASS: TestAccEKSCluster_version (2907.74s)
--- PASS: TestAccEKSCluster_Encryption_update (3607.58s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 3611.277s
@mKeRix Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22407
Output from acceptance testing: