-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/appsync_function - Support sync_config
and max_batch_size
#22484
Conversation
eb21f9d
to
0dec61f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAppSync_serial/Function PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20 -run='TestAccAppSync_serial/Function' -timeout 180m
=== RUN TestAccAppSync_serial
=== RUN TestAccAppSync_serial/Function
=== RUN TestAccAppSync_serial/Function/description
=== RUN TestAccAppSync_serial/Function/responseMappingTemplate
=== RUN TestAccAppSync_serial/Function/sync
=== RUN TestAccAppSync_serial/Function/basic
=== RUN TestAccAppSync_serial/Function/disappears
--- PASS: TestAccAppSync_serial (195.92s)
--- PASS: TestAccAppSync_serial/Function (195.92s)
--- PASS: TestAccAppSync_serial/Function/description (42.38s)
--- PASS: TestAccAppSync_serial/Function/responseMappingTemplate (26.53s)
--- PASS: TestAccAppSync_serial/Function/sync (40.18s)
--- PASS: TestAccAppSync_serial/Function/basic (53.85s)
--- PASS: TestAccAppSync_serial/Function/disappears (32.98s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appsync 200.972s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Requires #22411 (sync config only works for versioned data sources)
Output from acceptance testing: