Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/appsync_function - Support sync_config and max_batch_size #22484

Merged
merged 8 commits into from
Jan 10, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 8, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Requires #22411 (sync config only works for versioned data sources)

Output from acceptance testing:

$ make testacc TESTS=TestAccAppSync_serial/Function/sync PKG=appsync > a.txt
--- PASS: TestAccAppSync_serial (76.11s)
    --- PASS: TestAccAppSync_serial/Function (76.11s)
        --- PASS: TestAccAppSync_serial/Function/sync (76.11s)

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 8, 2022
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 8, 2022
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Jan 10, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review January 10, 2022 10:50
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAppSync_serial/Function PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20 -run='TestAccAppSync_serial/Function'  -timeout 180m
=== RUN   TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/Function
=== RUN   TestAccAppSync_serial/Function/description
=== RUN   TestAccAppSync_serial/Function/responseMappingTemplate
=== RUN   TestAccAppSync_serial/Function/sync
=== RUN   TestAccAppSync_serial/Function/basic
=== RUN   TestAccAppSync_serial/Function/disappears
--- PASS: TestAccAppSync_serial (195.92s)
    --- PASS: TestAccAppSync_serial/Function (195.92s)
        --- PASS: TestAccAppSync_serial/Function/description (42.38s)
        --- PASS: TestAccAppSync_serial/Function/responseMappingTemplate (26.53s)
        --- PASS: TestAccAppSync_serial/Function/sync (40.18s)
        --- PASS: TestAccAppSync_serial/Function/basic (53.85s)
        --- PASS: TestAccAppSync_serial/Function/disappears (32.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	200.972s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9dc28ee into hashicorp:main Jan 10, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 10, 2022
@DrFaust92 DrFaust92 deleted the appsync_func branch January 10, 2022 20:39
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants