-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added nil check for nfs exports #22480
added nil check for nfs exports #22480
Conversation
Seems problem is nfs exports returns an array with a single Null value instead just an overall Null. When iterator reaches first value it tries to read property of the null. Add check to the loop to check if each item is a null and skip if it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccFSxOpenzfsFileSystem_rootVolume PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenzfsFileSystem_rootVolume' -timeout 180m
=== RUN TestAccFSxOpenzfsFileSystem_rootVolume
=== PAUSE TestAccFSxOpenzfsFileSystem_rootVolume
=== CONT TestAccFSxOpenzfsFileSystem_rootVolume
--- PASS: TestAccFSxOpenzfsFileSystem_rootVolume (1423.10s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 1426.744s
@awsaxeman Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22475
Output from acceptance testing: