-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/devicefarm_network_profile - new resource #22448
r/devicefarm_network_profile - new resource #22448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDeviceFarmNetworkProfile_\|TestAccDeviceFarmDevicePool_' PKG_NAME=internal/service/devicefarm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/devicefarm/... -v -count 1 -parallel 20 -run=TestAccDeviceFarmNetworkProfile_\|TestAccDeviceFarmDevicePool_ -timeout 180m
=== RUN TestAccDeviceFarmDevicePool_basic
=== PAUSE TestAccDeviceFarmDevicePool_basic
=== RUN TestAccDeviceFarmDevicePool_tags
=== PAUSE TestAccDeviceFarmDevicePool_tags
=== RUN TestAccDeviceFarmDevicePool_disappears
=== PAUSE TestAccDeviceFarmDevicePool_disappears
=== RUN TestAccDeviceFarmDevicePool_disappears_project
=== PAUSE TestAccDeviceFarmDevicePool_disappears_project
=== RUN TestAccDeviceFarmNetworkProfile_basic
=== PAUSE TestAccDeviceFarmNetworkProfile_basic
=== RUN TestAccDeviceFarmNetworkProfile_tags
=== PAUSE TestAccDeviceFarmNetworkProfile_tags
=== RUN TestAccDeviceFarmNetworkProfile_disappears
=== PAUSE TestAccDeviceFarmNetworkProfile_disappears
=== RUN TestAccDeviceFarmNetworkProfile_disappears_project
=== PAUSE TestAccDeviceFarmNetworkProfile_disappears_project
=== CONT TestAccDeviceFarmDevicePool_basic
=== CONT TestAccDeviceFarmNetworkProfile_tags
=== CONT TestAccDeviceFarmDevicePool_disappears_project
=== CONT TestAccDeviceFarmNetworkProfile_basic
=== CONT TestAccDeviceFarmNetworkProfile_disappears_project
=== CONT TestAccDeviceFarmNetworkProfile_disappears
=== CONT TestAccDeviceFarmDevicePool_tags
=== CONT TestAccDeviceFarmDevicePool_disappears
--- PASS: TestAccDeviceFarmNetworkProfile_disappears_project (18.05s)
--- PASS: TestAccDeviceFarmDevicePool_disappears_project (20.38s)
--- PASS: TestAccDeviceFarmNetworkProfile_disappears (20.56s)
--- PASS: TestAccDeviceFarmDevicePool_disappears (23.14s)
--- PASS: TestAccDeviceFarmNetworkProfile_basic (36.87s)
--- PASS: TestAccDeviceFarmDevicePool_basic (41.65s)
--- PASS: TestAccDeviceFarmNetworkProfile_tags (47.70s)
--- PASS: TestAccDeviceFarmDevicePool_tags (53.73s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm 57.386s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing:
$ make testacc TESTS=TestAccDeviceFarmUpload_ PKG=devicefarm
--- PASS: TestAccDeviceFarmUpload_disappears_project (52.51s)
--- PASS: TestAccDeviceFarmUpload_disappears (59.99s)
--- PASS: TestAccDeviceFarmUpload_basic (104.69s)