Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/devicefarm_network_profile - new resource #22448

Merged
merged 5 commits into from
Jan 6, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 6, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccDeviceFarmNetworkProfile_ PKG=devicefarm
--- PASS: TestAccDeviceFarmNetworkProfile_disappears_project (86.85s)
--- PASS: TestAccDeviceFarmNetworkProfile_disappears (96.35s)
--- PASS: TestAccDeviceFarmNetworkProfile_basic (182.20s)
--- PASS: TestAccDeviceFarmNetworkProfile_tags (242.36s)

$ make testacc TESTS=TestAccDeviceFarmUpload_ PKG=devicefarm
--- PASS: TestAccDeviceFarmUpload_disappears_project (52.51s)
--- PASS: TestAccDeviceFarmUpload_disappears (59.99s)
--- PASS: TestAccDeviceFarmUpload_basic (104.69s)


$ make testacc TESTS= TestAccDeviceFarmDevicePool_ PKG=devicefarm
--- PASS: TestAccDeviceFarmDevicePool_disappears_project (84.65s)
--- PASS: TestAccDeviceFarmDevicePool_disappears (91.34s)
--- PASS: TestAccDeviceFarmDevicePool_basic (164.37s)
--- PASS: TestAccDeviceFarmDevicePool_tags (206.97s)

@DrFaust92 DrFaust92 marked this pull request as draft January 6, 2022 19:16
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/devicefarm Issues and PRs that pertain to the devicefarm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 6, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 6, 2022
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jan 6, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review January 6, 2022 19:44
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDeviceFarmNetworkProfile_\|TestAccDeviceFarmDevicePool_' PKG_NAME=internal/service/devicefarm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/devicefarm/... -v -count 1 -parallel 20 -run=TestAccDeviceFarmNetworkProfile_\|TestAccDeviceFarmDevicePool_ -timeout 180m
=== RUN   TestAccDeviceFarmDevicePool_basic
=== PAUSE TestAccDeviceFarmDevicePool_basic
=== RUN   TestAccDeviceFarmDevicePool_tags
=== PAUSE TestAccDeviceFarmDevicePool_tags
=== RUN   TestAccDeviceFarmDevicePool_disappears
=== PAUSE TestAccDeviceFarmDevicePool_disappears
=== RUN   TestAccDeviceFarmDevicePool_disappears_project
=== PAUSE TestAccDeviceFarmDevicePool_disappears_project
=== RUN   TestAccDeviceFarmNetworkProfile_basic
=== PAUSE TestAccDeviceFarmNetworkProfile_basic
=== RUN   TestAccDeviceFarmNetworkProfile_tags
=== PAUSE TestAccDeviceFarmNetworkProfile_tags
=== RUN   TestAccDeviceFarmNetworkProfile_disappears
=== PAUSE TestAccDeviceFarmNetworkProfile_disappears
=== RUN   TestAccDeviceFarmNetworkProfile_disappears_project
=== PAUSE TestAccDeviceFarmNetworkProfile_disappears_project
=== CONT  TestAccDeviceFarmDevicePool_basic
=== CONT  TestAccDeviceFarmNetworkProfile_tags
=== CONT  TestAccDeviceFarmDevicePool_disappears_project
=== CONT  TestAccDeviceFarmNetworkProfile_basic
=== CONT  TestAccDeviceFarmNetworkProfile_disappears_project
=== CONT  TestAccDeviceFarmNetworkProfile_disappears
=== CONT  TestAccDeviceFarmDevicePool_tags
=== CONT  TestAccDeviceFarmDevicePool_disappears
--- PASS: TestAccDeviceFarmNetworkProfile_disappears_project (18.05s)
--- PASS: TestAccDeviceFarmDevicePool_disappears_project (20.38s)
--- PASS: TestAccDeviceFarmNetworkProfile_disappears (20.56s)
--- PASS: TestAccDeviceFarmDevicePool_disappears (23.14s)
--- PASS: TestAccDeviceFarmNetworkProfile_basic (36.87s)
--- PASS: TestAccDeviceFarmDevicePool_basic (41.65s)
--- PASS: TestAccDeviceFarmNetworkProfile_tags (47.70s)
--- PASS: TestAccDeviceFarmDevicePool_tags (53.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm	57.386s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0c1b2e4 into hashicorp:main Jan 6, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the devicefarm_network_profile branch February 12, 2022 12:47
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/devicefarm Issues and PRs that pertain to the devicefarm service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants