r/networkfirewall_resource_policy: add error handling during delete for possible RAM related error

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22174

Notes

• error seems to occur only during immediate delete-after-create behavior seen during disappears acceptance testing as other tests were passing before code change

Output from acceptance testing:

--- PASS: TestAccNetworkFirewallResourcePolicy_disappears (131.81s)
--- PASS: TestAccNetworkFirewallResourcePolicy_ruleGroup (138.82s)
--- PASS: TestAccNetworkFirewallResourcePolicy_basic (139.01s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy (146.00s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup (146.00s)
--- PASS: TestAccNetworkFirewallResourcePolicy_ignoreEquivalent (148.07s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccNetworkFirewallResourcePolicy_ PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallResourcePolicy_' -timeout 180m
=== RUN   TestAccNetworkFirewallResourcePolicy_basic
=== PAUSE TestAccNetworkFirewallResourcePolicy_basic
=== RUN   TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== PAUSE TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== RUN   TestAccNetworkFirewallResourcePolicy_ruleGroup
=== PAUSE TestAccNetworkFirewallResourcePolicy_ruleGroup
=== RUN   TestAccNetworkFirewallResourcePolicy_disappears
=== PAUSE TestAccNetworkFirewallResourcePolicy_disappears
=== RUN   TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== RUN   TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== CONT  TestAccNetworkFirewallResourcePolicy_basic
=== CONT  TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== CONT  TestAccNetworkFirewallResourcePolicy_disappears
=== CONT  TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== CONT  TestAccNetworkFirewallResourcePolicy_ruleGroup
=== CONT  TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
--- PASS: TestAccNetworkFirewallResourcePolicy_ruleGroup (136.73s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup (142.25s)
--- PASS: TestAccNetworkFirewallResourcePolicy_basic (156.44s)
--- PASS: TestAccNetworkFirewallResourcePolicy_disappears (157.25s)
--- PASS: TestAccNetworkFirewallResourcePolicy_ignoreEquivalent (158.06s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy (161.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	166.810s

[github-actions]

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.