Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11511: Added data source aws_organizations_resource_tags #22371

Merged
merged 11 commits into from
Jan 3, 2022
Merged

11511: Added data source aws_organizations_resource_tags #22371

merged 11 commits into from
Jan 3, 2022

Conversation

gramsa49
Copy link
Contributor

@gramsa49 gramsa49 commented Dec 29, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11511

Given the following HCL:

data "aws_organizations_resource_tags" "test" {
  resource_id = "12345"
}

output "test" {
  value = data.aws_organizations_resource_tags.test
}

This data source returns the following:

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

test = {
  "id" = "12345"
  "resource_id" = "12345"
  "tags" = tomap({
    "testtagkey1" = "testtagval1"
    "testtagkey2" = "testtagval2"
  })
}

This data source supports any AWS Organization resource as supported by API_ListTagsForResource:

You can specify any of the following taggable resources.

  • AWS account – specify the account ID number.
  • Organizational unit – specify the OU ID that begins with ou- and looks similar to: ou-1a2b-34uvwxyz
  • Root – specify the root ID that begins with r- and looks similar to: r-1a2b
  • Policy – specify the policy ID that begins with p- andlooks similar to: p-12abcdefg3

Output from acceptance testing:

$ make testacc TESTS=testAccOrganizationResourceTagsDataSource_basic PKG=organizations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20 -run='testAccOrganizationResourceTagsDataSource_basic' -timeout 180m
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/organizations      0.088s [no tests to run]

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/organizations Issues and PRs that pertain to the organizations service. size/M Managed by automation to categorize the size of a PR. labels Dec 29, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @gramsa49 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 29, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 29, 2021
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 2, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOrganizations_serial/ResourceTags' PKG_NAME=internal/service/organizations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20 -run=TestAccOrganizations_serial/ResourceTags -timeout 180m
=== RUN   TestAccOrganizations_serial
=== RUN   TestAccOrganizations_serial/ResourceTags
=== RUN   TestAccOrganizations_serial/ResourceTags/basic
=== PAUSE TestAccOrganizations_serial/ResourceTags/basic
=== CONT  TestAccOrganizations_serial/ResourceTags/basic
--- PASS: TestAccOrganizations_serial (20.44s)
    --- PASS: TestAccOrganizations_serial/ResourceTags (0.00s)
        --- PASS: TestAccOrganizations_serial/ResourceTags/basic (20.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	28.309s

@ewbankkit
Copy link
Contributor

@gramsa49 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bbecf0c into hashicorp:main Jan 3, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/organizations Issues and PRs that pertain to the organizations service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data source for AWS Organizations account tagging
2 participants