Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 Subnet: Add DNS64, IPv6-only and Resource-based Name attributes #22339

Merged
merged 17 commits into from
Dec 24, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21791.
Closes #22316.

Adds:

  • enable_dns64 boolean argument in support of DNS64
  • ipv6_native boolean argument in support of IPv6-only subnets
  • enable_resource_name_dns_aaaa_record_on_launch and enable_resource_name_dns_a_record_on_launch boolean arguments and private_dns_hostname_type_on_launch string argument in support of Resource-based Names for EC2 instances

to the aws_subnet resource and equivalent attributes to the aws_subnet data source.

Output from acceptance testing:

Commercial

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2Subnet_\|TestAccEC2SubnetIDsDataSource_\|TestAccEC2SubnetsDataSource_\|TestAccEC2SubnetDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2Subnet_\|TestAccEC2SubnetIDsDataSource_\|TestAccEC2SubnetsDataSource_\|TestAccEC2SubnetDataSource_ -timeout 180m
=== RUN   TestAccEC2SubnetDataSource_basic
=== PAUSE TestAccEC2SubnetDataSource_basic
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== RUN   TestAccEC2SubnetIDsDataSource_basic
=== PAUSE TestAccEC2SubnetIDsDataSource_basic
=== RUN   TestAccEC2SubnetIDsDataSource_filter
=== PAUSE TestAccEC2SubnetIDsDataSource_filter
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2Subnet_ipv6Native
=== PAUSE TestAccEC2Subnet_ipv6Native
=== RUN   TestAccEC2SubnetsDataSource_basic
=== PAUSE TestAccEC2SubnetsDataSource_basic
=== RUN   TestAccEC2SubnetsDataSource_filter
=== PAUSE TestAccEC2SubnetsDataSource_filter
=== CONT  TestAccEC2SubnetDataSource_basic
=== CONT  TestAccEC2Subnet_ignoreTags
=== CONT  TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccEC2SubnetsDataSource_filter
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== CONT  TestAccEC2Subnet_availabilityZoneID
=== CONT  TestAccEC2Subnet_enableIPv6
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2Subnet_disappears
=== CONT  TestAccEC2SubnetsDataSource_basic
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== CONT  TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_enableDNS64
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (1.64s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (1.71s)
=== CONT  TestAccEC2SubnetIDsDataSource_filter
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (2.02s)
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (9.21s)
=== CONT  TestAccEC2Subnet_tags
--- PASS: TestAccEC2Subnet_disappears (56.82s)
=== CONT  TestAccEC2Subnet_basic
--- PASS: TestAccEC2SubnetDataSource_basic (58.52s)
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
--- PASS: TestAccEC2SubnetIDsDataSource_filter (58.76s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
--- PASS: TestAccEC2SubnetsDataSource_filter (62.18s)
=== CONT  TestAccEC2SubnetIDsDataSource_basic
--- PASS: TestAccEC2Subnet_availabilityZoneID (63.79s)
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccEC2Subnet_ipv6Native (70.74s)
--- PASS: TestAccEC2SubnetsDataSource_basic (89.40s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (91.34s)
--- PASS: TestAccEC2Subnet_basic (44.52s)
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (106.25s)
--- PASS: TestAccEC2Subnet_ignoreTags (109.57s)
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (112.20s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (114.54s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (120.07s)
--- PASS: TestAccEC2Subnet_tags (110.99s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (120.07s)
--- PASS: TestAccEC2Subnet_enableIPv6 (122.08s)
--- PASS: TestAccEC2Subnet_ipv6 (122.63s)
--- PASS: TestAccEC2SubnetIDsDataSource_basic (62.40s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock (66.48s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (65.95s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6Filter (64.74s)
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (137.74s)
--- PASS: TestAccEC2Subnet_enableDNS64 (140.04s)
--- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (160.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	164.406s

GovCloud

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2Subnet_\|TestAccEC2SubnetIDsDataSource_\|TestAccEC2SubnetsDataSource_\|TestAccEC2SubnetDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2Subnet_\|TestAccEC2SubnetIDsDataSource_\|TestAccEC2SubnetsDataSource_\|TestAccEC2SubnetDataSource_ -timeout 180m
=== RUN   TestAccEC2SubnetDataSource_basic
=== PAUSE TestAccEC2SubnetDataSource_basic
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== RUN   TestAccEC2SubnetIDsDataSource_basic
=== PAUSE TestAccEC2SubnetIDsDataSource_basic
=== RUN   TestAccEC2SubnetIDsDataSource_filter
=== PAUSE TestAccEC2SubnetIDsDataSource_filter
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2Subnet_ipv6Native
=== PAUSE TestAccEC2Subnet_ipv6Native
=== RUN   TestAccEC2SubnetsDataSource_basic
=== PAUSE TestAccEC2SubnetsDataSource_basic
=== RUN   TestAccEC2SubnetsDataSource_filter
=== PAUSE TestAccEC2SubnetsDataSource_filter
=== CONT  TestAccEC2SubnetDataSource_basic
=== CONT  TestAccEC2Subnet_ignoreTags
=== CONT  TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== CONT  TestAccEC2SubnetsDataSource_filter
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
=== CONT  TestAccEC2Subnet_disappears
=== CONT  TestAccEC2Subnet_availabilityZoneID
=== CONT  TestAccEC2Subnet_enableIPv6
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2SubnetsDataSource_basic
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (2.17s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (2.33s)
=== CONT  TestAccEC2Subnet_enableDNS64
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (2.39s)
=== CONT  TestAccEC2SubnetIDsDataSource_filter
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (5.16s)
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
--- PASS: TestAccEC2Subnet_disappears (46.79s)
=== CONT  TestAccEC2Subnet_tags
--- PASS: TestAccEC2SubnetIDsDataSource_filter (49.30s)
=== CONT  TestAccEC2Subnet_basic
--- PASS: TestAccEC2Subnet_availabilityZoneID (54.57s)
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
--- PASS: TestAccEC2SubnetDataSource_basic (55.79s)
=== CONT  TestAccEC2SubnetIDsDataSource_basic
--- PASS: TestAccEC2SubnetsDataSource_filter (58.15s)
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccEC2Subnet_ipv6Native (68.42s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (81.16s)
--- PASS: TestAccEC2SubnetsDataSource_basic (82.82s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (83.67s)
--- PASS: TestAccEC2Subnet_ignoreTags (100.38s)
--- PASS: TestAccEC2Subnet_basic (49.09s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (102.23s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (105.61s)
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (106.13s)
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (108.74s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (103.08s)
--- PASS: TestAccEC2Subnet_ipv6 (120.16s)
--- PASS: TestAccEC2Subnet_enableIPv6 (120.16s)
--- PASS: TestAccEC2SubnetIDsDataSource_basic (68.27s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock (69.66s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6Filter (68.38s)
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (140.95s)
--- PASS: TestAccEC2Subnet_enableDNS64 (142.20s)
--- PASS: TestAccEC2Subnet_tags (97.73s)
--- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (162.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	166.376s

Acceptance test output:

% make testacc PKG=ec2 TESTS=TestAccEC2Subnet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Subnet_' -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_ignoreTags
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
=== CONT  TestAccEC2Subnet_disappears
=== CONT  TestAccEC2Subnet_availabilityZoneID
=== CONT  TestAccEC2Subnet_enableIPv6
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== CONT  TestAccEC2Subnet_tags
=== CONT  TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (1.48s)
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (1.53s)
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (1.60s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (6.71s)
--- PASS: TestAccEC2Subnet_disappears (43.98s)
--- PASS: TestAccEC2Subnet_basic (48.25s)
--- PASS: TestAccEC2Subnet_availabilityZoneID (48.45s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (68.48s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (70.67s)
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (83.56s)
--- PASS: TestAccEC2Subnet_ignoreTags (83.58s)
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (85.68s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (89.37s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (91.52s)
--- PASS: TestAccEC2Subnet_tags (93.09s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (94.98s)
--- PASS: TestAccEC2Subnet_ipv6 (96.26s)
--- PASS: TestAccEC2Subnet_enableIPv6 (99.16s)
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (119.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	123.363s
…itSubnetIPv6CIDRBlockAssociationDeleted'.

Acceptance test output:

% make testacc PKG=ec2 TESTS=TestAccEC2Subnet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Subnet_' -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_ignoreTags
=== CONT  TestAccEC2Subnet_disappears
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== CONT  TestAccEC2Subnet_availabilityZoneID
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Subnet_enableIPv6
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
=== CONT  TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_tags
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (1.63s)
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (1.63s)
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (1.65s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (6.15s)
--- PASS: TestAccEC2Subnet_disappears (40.68s)
--- PASS: TestAccEC2Subnet_basic (50.94s)
--- PASS: TestAccEC2Subnet_availabilityZoneID (51.98s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (86.02s)
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (95.92s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (98.62s)
--- PASS: TestAccEC2Subnet_ignoreTags (98.65s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (100.88s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (105.88s)
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (111.71s)
--- PASS: TestAccEC2Subnet_tags (112.73s)
--- PASS: TestAccEC2Subnet_enableIPv6 (112.74s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (119.37s)
--- PASS: TestAccEC2Subnet_ipv6 (129.33s)
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (135.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	139.657s
Acceptance test output:

% make testacc PKG=ec2 TESTS=TestAccEC2SubnetDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SubnetDataSource_' -timeout 180m
=== RUN   TestAccEC2SubnetDataSource_basic
=== PAUSE TestAccEC2SubnetDataSource_basic
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== CONT  TestAccEC2SubnetDataSource_basic
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccEC2SubnetDataSource_basic (28.75s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock (51.50s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6Filter (51.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	56.688s
d/aws_subnet_ids: Use 'FindSubnets'.

Acceptance test output:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2SubnetIDsDataSource_\|TestAccEC2SubnetsDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2SubnetIDsDataSource_\|TestAccEC2SubnetsDataSource_ -timeout 180m
=== RUN   TestAccEC2SubnetIDsDataSource_basic
=== PAUSE TestAccEC2SubnetIDsDataSource_basic
=== RUN   TestAccEC2SubnetIDsDataSource_filter
=== PAUSE TestAccEC2SubnetIDsDataSource_filter
=== RUN   TestAccEC2SubnetsDataSource_basic
=== PAUSE TestAccEC2SubnetsDataSource_basic
=== RUN   TestAccEC2SubnetsDataSource_filter
=== PAUSE TestAccEC2SubnetsDataSource_filter
=== CONT  TestAccEC2SubnetIDsDataSource_basic
=== CONT  TestAccEC2SubnetsDataSource_filter
=== CONT  TestAccEC2SubnetIDsDataSource_filter
=== CONT  TestAccEC2SubnetsDataSource_basic
--- PASS: TestAccEC2SubnetIDsDataSource_filter (28.35s)
--- PASS: TestAccEC2SubnetsDataSource_filter (30.39s)
--- PASS: TestAccEC2SubnetsDataSource_basic (43.29s)
--- PASS: TestAccEC2SubnetIDsDataSource_basic (43.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	47.055s
Acceptance test output:

% make testacc PKG=ec2 TESTS=TestAccEC2Subnet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Subnet_' -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== CONT  TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccEC2Subnet_ignoreTags
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
=== CONT  TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== CONT  TestAccEC2Subnet_disappears
=== CONT  TestAccEC2Subnet_enableDNS64
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
=== CONT  TestAccEC2Subnet_availabilityZoneID
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
=== CONT  TestAccEC2Subnet_tags
=== CONT  TestAccEC2Subnet_enableIPv6
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (1.59s)
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (1.62s)
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (1.68s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (6.17s)
--- PASS: TestAccEC2Subnet_disappears (43.34s)
--- PASS: TestAccEC2Subnet_basic (48.42s)
--- PASS: TestAccEC2Subnet_availabilityZoneID (48.45s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (67.18s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (68.57s)
--- PASS: TestAccEC2Subnet_ignoreTags (79.65s)
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (82.49s)
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (84.98s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (87.77s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (88.85s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (89.11s)
--- PASS: TestAccEC2Subnet_tags (90.93s)
--- PASS: TestAccEC2Subnet_ipv6 (94.52s)
--- PASS: TestAccEC2Subnet_enableIPv6 (96.98s)
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (115.57s)
--- PASS: TestAccEC2Subnet_enableDNS64 (119.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	123.259s
Acceptance test output:

% make testacc PKG=ec2 TESTS=TestAccEC2SubnetDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SubnetDataSource_' -timeout 180m
=== RUN   TestAccEC2SubnetDataSource_basic
=== PAUSE TestAccEC2SubnetDataSource_basic
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== CONT  TestAccEC2SubnetDataSource_basic
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccEC2SubnetDataSource_basic (27.79s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6Filter (45.22s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock (45.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	49.526s
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Dec 23, 2021
…enable_resource_name_dns_a_record_on_launch' and 'private_dns_hostname_type_on_launch' arguments.

Acceptance test output:

% make testacc PKG=ec2 TESTS=TestAccEC2Subnet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Subnet_' -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== CONT  TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccEC2Subnet_ignoreTags
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
=== CONT  TestAccEC2Subnet_disappears
=== CONT  TestAccEC2Subnet_availabilityZoneID
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
=== CONT  TestAccEC2Subnet_enableDNS64
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccEC2Subnet_enableIPv6
=== CONT  TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
=== CONT  TestAccEC2Subnet_tags
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (1.74s)
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (1.74s)
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (1.74s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (6.18s)
--- PASS: TestAccEC2Subnet_disappears (41.57s)
--- PASS: TestAccEC2Subnet_availabilityZoneID (46.97s)
--- PASS: TestAccEC2Subnet_basic (47.07s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (67.21s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (74.46s)
--- PASS: TestAccEC2Subnet_ignoreTags (83.13s)
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (83.56s)
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (84.71s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (91.13s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (91.29s)
--- PASS: TestAccEC2Subnet_tags (94.37s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (95.25s)
--- PASS: TestAccEC2Subnet_enableIPv6 (96.52s)
--- PASS: TestAccEC2Subnet_ipv6 (98.29s)
--- PASS: TestAccEC2Subnet_enableDNS64 (120.47s)
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (120.47s)
--- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (136.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	141.719s
…enable_resource_name_dns_a_record_on_launch' and 'private_dns_hostname_type_on_launch' attributes.

Acceptance test output:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2SubnetIDsDataSource_\|TestAccEC2SubnetsDataSource_\|TestAccEC2SubnetDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2SubnetIDsDataSource_\|TestAccEC2SubnetsDataSource_\|TestAccEC2SubnetDataSource_ -timeout 180m
=== RUN   TestAccEC2SubnetDataSource_basic
=== PAUSE TestAccEC2SubnetDataSource_basic
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== RUN   TestAccEC2SubnetIDsDataSource_basic
=== PAUSE TestAccEC2SubnetIDsDataSource_basic
=== RUN   TestAccEC2SubnetIDsDataSource_filter
=== PAUSE TestAccEC2SubnetIDsDataSource_filter
=== RUN   TestAccEC2SubnetsDataSource_basic
=== PAUSE TestAccEC2SubnetsDataSource_basic
=== RUN   TestAccEC2SubnetsDataSource_filter
=== PAUSE TestAccEC2SubnetsDataSource_filter
=== CONT  TestAccEC2SubnetDataSource_basic
=== CONT  TestAccEC2SubnetIDsDataSource_filter
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== CONT  TestAccEC2SubnetsDataSource_filter
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== CONT  TestAccEC2SubnetIDsDataSource_basic
=== CONT  TestAccEC2SubnetsDataSource_basic
--- PASS: TestAccEC2SubnetDataSource_basic (30.40s)
--- PASS: TestAccEC2SubnetIDsDataSource_filter (30.47s)
--- PASS: TestAccEC2SubnetsDataSource_filter (31.83s)
--- PASS: TestAccEC2SubnetsDataSource_basic (45.73s)
--- PASS: TestAccEC2SubnetIDsDataSource_basic (47.15s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6Filter (48.22s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock (48.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	52.212s
@ewbankkit ewbankkit changed the title [WIP] EC2 Subnet: Add enable_dns64 attribute [WIP] EC2 Subnet: Add DNS64, IPv6-only and Resource-based Name attributes Dec 23, 2021
Acceptance test output:

% make testacc PKG=ec2 TESTS=TestAccEC2Subnet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Subnet_' -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2Subnet_ipv6Native
=== PAUSE TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccEC2Subnet_enableIPv6
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
=== CONT  TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== CONT  TestAccEC2Subnet_disappears
=== CONT  TestAccEC2Subnet_enableDNS64
=== CONT  TestAccEC2Subnet_outpost
=== CONT  TestAccEC2Subnet_tags
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
=== CONT  TestAccEC2Subnet_availabilityZoneID
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2Subnet_ignoreTags
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (1.73s)
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (1.73s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (1.86s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (4.54s)
--- PASS: TestAccEC2Subnet_disappears (41.56s)
--- PASS: TestAccEC2Subnet_basic (46.30s)
--- PASS: TestAccEC2Subnet_availabilityZoneID (46.75s)
--- PASS: TestAccEC2Subnet_ipv6Native (60.82s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (69.42s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (70.31s)
--- PASS: TestAccEC2Subnet_ignoreTags (82.79s)
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (83.09s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (85.54s)
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (88.14s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (88.46s)
--- PASS: TestAccEC2Subnet_tags (90.63s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (92.69s)
--- PASS: TestAccEC2Subnet_enableIPv6 (95.35s)
--- PASS: TestAccEC2Subnet_ipv6 (95.40s)
--- PASS: TestAccEC2Subnet_enableDNS64 (120.57s)
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (121.00s)
--- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (135.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	139.400s
Acceptance test output:

% make testacc PKG=ec2 TESTS=TestAccEC2SubnetDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SubnetDataSource_' -timeout 180m
=== RUN   TestAccEC2SubnetDataSource_basic
=== PAUSE TestAccEC2SubnetDataSource_basic
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== CONT  TestAccEC2SubnetDataSource_basic
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock
=== CONT  TestAccEC2SubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccEC2SubnetDataSource_basic (30.20s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6Filter (46.63s)
--- PASS: TestAccEC2SubnetDataSource_ipv6ByIPv6CIDRBlock (46.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	52.138s
@ewbankkit ewbankkit changed the title [WIP] EC2 Subnet: Add DNS64, IPv6-only and Resource-based Name attributes EC2 Subnet: Add DNS64, IPv6-only and Resource-based Name attributes Dec 24, 2021
@ewbankkit ewbankkit merged commit 44e4255 into main Dec 24, 2021
@ewbankkit ewbankkit deleted the td-aws_subnet-modernize branch December 24, 2021 13:38
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 24, 2021
github-actions bot pushed a commit that referenced this pull request Dec 24, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_subnet should support IPv6-only subnets aws_subnet - Add enable_dns64 argument
1 participant