-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_memorydb_parameter_group #22304
New Resource: aws_memorydb_parameter_group #22304
Conversation
d158df6
to
7099014
Compare
7099014
to
7c11802
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc PKG=memorydb TESTS=TestAccMemoryDBParameterGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBParameterGroup_' -timeout 180m
=== RUN TestAccMemoryDBParameterGroup_basic
=== PAUSE TestAccMemoryDBParameterGroup_basic
=== RUN TestAccMemoryDBParameterGroup_disappears
=== PAUSE TestAccMemoryDBParameterGroup_disappears
=== RUN TestAccMemoryDBParameterGroup_update_parameters
=== PAUSE TestAccMemoryDBParameterGroup_update_parameters
=== RUN TestAccMemoryDBParameterGroup_update_tags
=== PAUSE TestAccMemoryDBParameterGroup_update_tags
=== CONT TestAccMemoryDBParameterGroup_basic
=== CONT TestAccMemoryDBParameterGroup_update_tags
=== CONT TestAccMemoryDBParameterGroup_update_parameters
=== CONT TestAccMemoryDBParameterGroup_disappears
--- PASS: TestAccMemoryDBParameterGroup_disappears (19.89s)
--- PASS: TestAccMemoryDBParameterGroup_basic (27.09s)
--- PASS: TestAccMemoryDBParameterGroup_update_tags (88.76s)
--- PASS: TestAccMemoryDBParameterGroup_update_parameters (128.71s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 135.832s
GovCloud
% make testacc PKG=memorydb TESTS=TestAccMemoryDBParameterGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBParameterGroup_' -timeout 180m
=== RUN TestAccMemoryDBParameterGroup_basic
=== PAUSE TestAccMemoryDBParameterGroup_basic
=== RUN TestAccMemoryDBParameterGroup_disappears
=== PAUSE TestAccMemoryDBParameterGroup_disappears
=== RUN TestAccMemoryDBParameterGroup_update_parameters
=== PAUSE TestAccMemoryDBParameterGroup_update_parameters
=== RUN TestAccMemoryDBParameterGroup_update_tags
=== PAUSE TestAccMemoryDBParameterGroup_update_tags
=== CONT TestAccMemoryDBParameterGroup_basic
=== CONT TestAccMemoryDBParameterGroup_update_parameters
=== CONT TestAccMemoryDBParameterGroup_update_tags
=== CONT TestAccMemoryDBParameterGroup_disappears
=== CONT TestAccMemoryDBParameterGroup_basic
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT TestAccMemoryDBParameterGroup_update_parameters
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBParameterGroup_basic (1.26s)
--- SKIP: TestAccMemoryDBParameterGroup_update_parameters (1.26s)
=== CONT TestAccMemoryDBParameterGroup_update_tags
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBParameterGroup_update_tags (1.26s)
=== CONT TestAccMemoryDBParameterGroup_disappears
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBParameterGroup_disappears (1.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 4.730s
@roberth-k Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #20631
Output from acceptance testing: