Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_connect_contact_flow: add delete function #22303

Merged
merged 4 commits into from
Jan 11, 2022
Merged

resource/aws_connect_contact_flow: add delete function #22303

merged 4 commits into from
Jan 11, 2022

Conversation

rahul-amzn
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #21935

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnectContactFlow_serial' PKG_NAME=internal/service/connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccConnectContactFlow_serial -timeout 180m
=== RUN   TestAccConnectContactFlow_serial
=== RUN   TestAccConnectContactFlow_serial/basic
=== RUN   TestAccConnectContactFlow_serial/filename
=== RUN   TestAccConnectContactFlow_serial/disappears
--- PASS: TestAccConnectContactFlow_serial (436.99s)
    --- PASS: TestAccConnectContactFlow_serial/basic (166.09s)
    --- PASS: TestAccConnectContactFlow_serial/filename (166.40s)
    --- PASS: TestAccConnectContactFlow_serial/disappears (104.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    440.123s
...

we evaluated the acceptance tests and determined that no changes were required. would love feedback on this decision

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Dec 21, 2021
github-actions[bot]
github-actions bot reviewed Dec 21, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @rahul-amzn 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

AdamTylerLynch
AdamTylerLynch approved these changes Dec 23, 2021
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

AdamTylerLynch
AdamTylerLynch suggested changes Dec 27, 2021
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional changes requested thanks to @GlennChia 's eagle eyes.

internal/service/connect/contact_flow_test.go Outdated
@@ -131,7 +131,6 @@ func testAccContactFlow_filename(t *testing.T) {
})
}

// Can't delete an contact flow. Test deletion of entire connect instance
func testAccContactFlow_disappears_ConnectInstance(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name and implementation should be changed to the ContactFlow:
testAccContactFlow_disappears

And the on line 152, we need to test the Contact Flow resource itself, not the Connect Instance:
acctest.CheckResourceDisappears(acctest.Provider, tfconnect.ResourceContactFlow(), resourceName),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamTylerLynch @GlennChia Thanks for review, made requested changes. Please check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamTylerLynch Here is the AccTest output:

$ date                                         
Mon 27 Dec 2021 22:38:27 IST
$ make testacc TESTARGS='-run=TestAccConnectContactFlow_serial' PKG_NAME=internal/service/connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccConnectContactFlow_serial -timeout 180m
=== RUN   TestAccConnectContactFlow_serial
=== RUN   TestAccConnectContactFlow_serial/disappears
=== RUN   TestAccConnectContactFlow_serial/basic
=== RUN   TestAccConnectContactFlow_serial/filename
--- PASS: TestAccConnectContactFlow_serial (552.29s)
    --- PASS: TestAccConnectContactFlow_serial/disappears (149.91s)
    --- PASS: TestAccConnectContactFlow_serial/basic (202.02s)
    --- PASS: TestAccConnectContactFlow_serial/filename (200.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    555.793s
...

AdamTylerLynch
AdamTylerLynch approved these changes Dec 28, 2021
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

AdamTylerLynch
AdamTylerLynch approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breathingdust
Copy link
Member

LGTM 🚀

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccConnectContactFlow_serial' PKG_NAME=internal/service/connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccConnectContactFlow_serial -timeout 180m
=== RUN   TestAccConnectContactFlow_serial
=== RUN   TestAccConnectContactFlow_serial/basic
=== RUN   TestAccConnectContactFlow_serial/filename
=== RUN   TestAccConnectContactFlow_serial/disappears
--- PASS: TestAccConnectContactFlow_serial (333.11s)
    --- PASS: TestAccConnectContactFlow_serial/basic (144.93s)
    --- PASS: TestAccConnectContactFlow_serial/filename (102.31s)
    --- PASS: TestAccConnectContactFlow_serial/disappears (85.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	336.684s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccConnectContactFlow_serial' PKG_NAME=internal/service/connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccConnectContactFlow_serial -timeout 180m
=== RUN   TestAccConnectContactFlow_serial
=== RUN   TestAccConnectContactFlow_serial/basic
=== RUN   TestAccConnectContactFlow_serial/filename
=== RUN   TestAccConnectContactFlow_serial/disappears
--- PASS: TestAccConnectContactFlow_serial (296.24s)
    --- PASS: TestAccConnectContactFlow_serial/basic (130.28s)
    --- PASS: TestAccConnectContactFlow_serial/filename (96.57s)
    --- PASS: TestAccConnectContactFlow_serial/disappears (69.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	299.776s

@breathingdust breathingdust merged commit 58a84f1 into hashicorp:main Jan 11, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 11, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

@breathingdust breathingdust Awaiting requested review from breathingdust

Assignees

@AdamTylerLynch AdamTylerLynch

@rahul-amzn rahul-amzn

Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/connect Issues and PRs that pertain to the connect service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add delete feature to Amazon Connect Contact Flow
4 participants
@rahul-amzn @breathingdust @AdamTylerLynch @justinretzolk